bert.hausmans
0e986f42cb
Three renames (registry → matches actual Eloquent model column):
- person.phone_number → person.phone
- company.email → company.contact_email
- company.phone_number → company.contact_phone
Six removals (registry attribute does not exist as model column,
intentionally deferred):
- person.dietary_preferences (custom_fields JSON path; BACKLOG
FORM-BINDING-JSON-PATH)
- artist.email (Artist model absent + column absent)
- artist.stage_name (column absent)
- artist.tech_rider (column absent)
- artist.hospitality_rider (column absent)
- artist entity removed entirely (no v1 bindable attributes)
Decisions documented inline in binding_targets.php and tracked
via BACKLOG entries (Task 4 of this session).
Tests touched:
- BindingTypeRegistryTest:
test_resolve_person_dietary_preferences_returns_collection_array →
renamed test_resolve_collection_attribute_returns_collection_array,
uses Config::set to inject a synthetic 'test_entity.tags' collection
target. v1 has no production collection targets (BACKLOG
FORM-BINDING-JSON-PATH).
test_validate_append_strategy_accepts_collection_target — same pattern.
test_entities_returns_known_entities — drop 'artist' from expected list.
test_attributes_for_person_includes_email_and_dietary_preferences →
renamed _includes_email_and_phone (the renamed attribute).
- AppendStrategyRequiresCollectionTargetTest:
test_passes_with_collection_target — same Config::set synthetic-
target pattern.
- MaxOneIdentityKeyPerTargetEntityTest:
test_passes_with_one_identity_key_each_on_different_entities —
'company.email' → 'company.contact_email' to match registry rename.
Refs: WS-6 sessie 3a binding-target drift audit
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
64 lines
3.1 KiB
PHP
64 lines
3.1 KiB
PHP
<?php
|
|
|
|
declare(strict_types=1);
|
|
|
|
/**
|
|
* RFC-WS-6 §4 (V1) — single source of truth for binding-target storage
|
|
* shape. Consulted by `BindingTypeRegistry`, `AppendStrategyRequiresCollectionTarget`
|
|
* publish guard, and `FormBindingApplicator`.
|
|
*
|
|
* `type` values:
|
|
* - 'scalar' — single column (string/int/datetime/email/...)
|
|
* - 'collection' — JSON array column or pivot relation with set semantics
|
|
* - 'relation' — FK column resolving to another entity
|
|
*
|
|
* `php` values map to native PHP / cast types: 'string', 'int', 'bool',
|
|
* 'date', 'datetime', 'array'. Validated by
|
|
* BindingTypeRegistryConsistencyTest.
|
|
*
|
|
* `identity_key_eligible` permits a binding to set `is_identity_key=true`
|
|
* on this attribute. PurposeGuardProvider's RequiresIdentityKeyBinding
|
|
* may only target attributes that are eligible.
|
|
*
|
|
* Every entry MUST map 1:1 to a real Eloquent model column on the
|
|
* corresponding entity model — enforced by
|
|
* BindingTypeRegistryConsistencyTest's model-existence + column-existence
|
|
* assertions (sessie 3a.5).
|
|
*
|
|
* Intentional gaps (Crewli v1):
|
|
*
|
|
* - 'artist' entity has NO registry entries in v1. The artist_advance
|
|
* purpose accepts schemas without bindings (subject is resolved via
|
|
* portal_token, not via field-to-attribute mapping). The Artist
|
|
* Eloquent model class does not exist; the artists table is reachable
|
|
* only via the morph map. Tracked: BACKLOG ARTIST-ADV-BINDING-MODEL.
|
|
*
|
|
* - person.dietary_preferences is NOT in the registry. Person-level
|
|
* dietary preferences live inside the persons.custom_fields JSON
|
|
* column. JSON-path bindings are out of scope for v1 binding pipeline.
|
|
* For v1, model dietary_preferences as a TAG_PICKER form_field with
|
|
* tag_categories config; see ARCH-FORM-BUILDER §31.10 for the
|
|
* TAG_PICKER → user_organisation_tags sync path.
|
|
* Tracked: BACKLOG FORM-BINDING-JSON-PATH.
|
|
*/
|
|
return [
|
|
'person' => [
|
|
'email' => ['type' => 'scalar', 'php' => 'string', 'identity_key_eligible' => true],
|
|
'first_name' => ['type' => 'scalar', 'php' => 'string', 'identity_key_eligible' => false],
|
|
'last_name' => ['type' => 'scalar', 'php' => 'string', 'identity_key_eligible' => false],
|
|
'date_of_birth' => ['type' => 'scalar', 'php' => 'date', 'identity_key_eligible' => false],
|
|
'phone' => ['type' => 'scalar', 'php' => 'string', 'identity_key_eligible' => false],
|
|
],
|
|
'company' => [
|
|
'name' => ['type' => 'scalar', 'php' => 'string', 'identity_key_eligible' => true],
|
|
'contact_email' => ['type' => 'scalar', 'php' => 'string', 'identity_key_eligible' => true],
|
|
'contact_phone' => ['type' => 'scalar', 'php' => 'string', 'identity_key_eligible' => false],
|
|
'kvk_number' => ['type' => 'scalar', 'php' => 'string', 'identity_key_eligible' => true],
|
|
],
|
|
'user' => [
|
|
'email' => ['type' => 'scalar', 'php' => 'string', 'identity_key_eligible' => true],
|
|
'first_name' => ['type' => 'scalar', 'php' => 'string', 'identity_key_eligible' => false],
|
|
'last_name' => ['type' => 'scalar', 'php' => 'string', 'identity_key_eligible' => false],
|
|
],
|
|
];
|