bert.hausmans
4cbb7f9497
Test infrastructure now uses the same MySQL 8.0 engine as local dev
and production. SQLite is no longer used anywhere in the project.
Eliminates the SQLite "rebuild on FK add" quirk that forced session 2.5
to omit a foreign key on form_schemas.default_crowd_type_id (Task 2 of
this session restores it).
Configuration:
- phpunit.xml: DB_CONNECTION=sqlite (:memory:) replaced with mysql
pointing at crewli_test database (127.0.0.1:3306, crewli/secret)
- Makefile: new test-db-create target creates crewli_test in the
bm_mysql Docker container; make test ensures it exists before
running suite
Latent-bug surfacing — fixes that MySQL exposed:
1. form_submissions.idempotency_key was declared `ulid()` (VARCHAR 26)
while FormRequest validates `string|max:30`. SQLite ignored the cap;
MySQL truncated and rejected. Column widened to string(30) to match
validation.
2. FormFieldValidationRuleService / FormFieldConfigService /
FormFieldBindingService::snapshotShapesFor — toJsonShape iterated
collection in DB-default order (insertion-stable on SQLite, undefined
on MySQL). Schema_snapshot bytes drifted across re-emits, breaking
audit-replay. Added `->sortBy('id')` (ULID = insertion-order
semantics, deterministic) on all three.
3. FormSubmissionObserverTest::test_denormalized_indexes_exist queried
sqlite_master directly. Replaced with the cross-engine
information_schema.STATISTICS query (the real production check is
on MySQL anyway).
4. JSON column key order non-determinism: MySQL JSON columns may
round-trip associative-array keys in a different order than they
were inserted. assertSame on JSON-derived associative arrays now
uses assertEquals (structural equality) where the test was previously
over-asserting on key order:
- ConditionalLogicActivityLogPayloadTest
- ConditionalLogicBackfillTest::test_rollback_reconstructs_canonical_json
- FormFieldBindingMigrationTest::test_rollback_reconstructs_json_and_drops_table
- FormFieldOptionServiceAndScopeTest::test_replace_options_emits_activity_log_on_field_only
- FormFieldOptionsActivityLogTest::test_field_updated_payload_contains_options_diff_when_options_change
- FormFieldOptionsBackfillTest::test_forward_migration_backfills_rows_strips_translations_and_rewrites_snapshot
- FormFieldOptionsSnapshotAndStrictRequestTest::test_submission_snapshot_embeds_rich_shape_options
5. Backfill / migration tests (4 classes, 21 tests) ran migrate:rollback
then migrate inside RefreshDatabase's wrapping transaction. MySQL
DDL implicit-commits the surrounding transaction, leaving Laravel
unable to ROLLBACK TO SAVEPOINT at end-of-test (1305 SAVEPOINT
does not exist). Replaced RefreshDatabase with a per-test
migrate:fresh in setUp + RefreshDatabaseState::\$migrated = false to
force the next RefreshDatabase test to re-migrate cleanly:
- FormFieldBindingMigrationTest
- ConditionalLogicBackfillTest
- FormFieldOptionsBackfillTest
- FormFieldValidationRuleBackfillTest
All 1386 tests now pass on MySQL. Larastan baseline unchanged.
Refs: WS-6 session 2.5 deviation #1 cleanup, RFC-WS-6.md v1.1
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
84 lines
3.2 KiB
Makefile
84 lines
3.2 KiB
Makefile
.PHONY: help services services-stop api app portal docs migrate fresh db-shell test test-db-create
|
|
|
|
# Colors
|
|
GREEN := \033[0;32m
|
|
YELLOW := \033[0;33m
|
|
CYAN := \033[0;36m
|
|
NC := \033[0m
|
|
|
|
help:
|
|
@echo ""
|
|
@echo "$(GREEN)╔══════════════════════════════════════════════════════════════╗$(NC)"
|
|
@echo "$(GREEN)║ CREWLI - Development Commands ║$(NC)"
|
|
@echo "$(GREEN)╚══════════════════════════════════════════════════════════════╝$(NC)"
|
|
@echo ""
|
|
@echo " $(YELLOW)Services (Docker):$(NC)"
|
|
@echo " make services Start MySQL, Redis, Mailpit"
|
|
@echo " make services-stop Stop all Docker services"
|
|
@echo ""
|
|
@echo " $(YELLOW)Development Servers:$(NC)"
|
|
@echo " make api Laravel API → http://localhost:8000"
|
|
@echo " make app Organizer SPA → http://localhost:5174"
|
|
@echo " make portal Portal SPA → http://localhost:5175"
|
|
@echo " make docs VitePress docs → http://localhost:5176"
|
|
@echo ""
|
|
@echo " $(YELLOW)Database:$(NC)"
|
|
@echo " make migrate Run migrations"
|
|
@echo " make fresh Fresh migrate + seed"
|
|
@echo " make db-shell Open MySQL shell"
|
|
@echo " make test-db-create Create crewli_test database (one-time)"
|
|
@echo ""
|
|
@echo " $(YELLOW)Testing:$(NC)"
|
|
@echo " make test Run PHPUnit suite (creates crewli_test if needed)"
|
|
@echo ""
|
|
|
|
services:
|
|
@echo "$(GREEN)Starting Docker services...$(NC)"
|
|
@docker compose up -d
|
|
@echo ""
|
|
@echo "$(GREEN)Services:$(NC)"
|
|
@echo " $(CYAN)MySQL:$(NC) localhost:3306 (crewli / secret)"
|
|
@echo " $(CYAN)Redis:$(NC) localhost:6379"
|
|
@echo " $(CYAN)Mailpit:$(NC) http://localhost:8025"
|
|
@echo ""
|
|
@echo "$(YELLOW)Waiting for MySQL...$(NC)"
|
|
@until docker exec bm_mysql mysqladmin ping -h localhost -u root -proot --silent 2>/dev/null; do sleep 1; done
|
|
@echo "$(GREEN)✓ Ready!$(NC)"
|
|
|
|
services-stop:
|
|
@docker compose down
|
|
@echo "$(GREEN)✓ Services stopped$(NC)"
|
|
|
|
api:
|
|
@echo "$(GREEN)Starting Laravel API → http://localhost:8000$(NC)"
|
|
@cd api && php artisan serve
|
|
|
|
app:
|
|
@echo "$(GREEN)Starting Organizer SPA → http://localhost:5174$(NC)"
|
|
@cd apps/app && pnpm dev
|
|
|
|
portal:
|
|
@echo "$(GREEN)Starting Portal SPA → http://localhost:5175$(NC)"
|
|
@cd apps/portal && pnpm dev
|
|
|
|
docs:
|
|
@echo "$(GREEN)Starting VitePress docs → http://localhost:5176$(NC)"
|
|
@cd docs && npm run docs:dev
|
|
|
|
migrate:
|
|
@cd api && php artisan migrate
|
|
|
|
fresh:
|
|
@cd api && php artisan migrate:fresh --seed
|
|
|
|
db-shell:
|
|
@docker exec -it bm_mysql mysql -u crewli -psecret crewli
|
|
|
|
test-db-create:
|
|
@echo "$(GREEN)Creating crewli_test database...$(NC)"
|
|
@docker exec bm_mysql mysql -u root -proot -e "CREATE DATABASE IF NOT EXISTS crewli_test CHARACTER SET utf8mb4 COLLATE utf8mb4_unicode_ci; GRANT ALL PRIVILEGES ON crewli_test.* TO 'crewli'@'%'; FLUSH PRIVILEGES;"
|
|
@echo "$(GREEN)✓ crewli_test ready$(NC)"
|
|
|
|
test: test-db-create
|
|
@cd api && php artisan test
|