bert.hausmans/crewli
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

fix(app): collapse nested if in useImpersonationStore

Browse Source 
WS-3 session 1b-iii follow-up — sonarjs/no-collapsible-if.

useImpersonationStore.ts:103: collapsed nested 'if (state.value)'
into the parent 'else if (data.data.session)' clause. Both legs
are AND-conditions on the same path, so the merge is semantically
identical. Brings the apps/app lint baseline to 0 problems.

Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
This commit is contained in:
bert.hausmans
2026-04-29 23:05:29 +02:00
parent 5512e22f2b
commit e4c99e23e9
1 changed files with 3 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
apps/app/src/stores/useImpersonationStore.ts
View File

@@ -100,12 +100,10 @@ export const useImpersonationStore = defineStore('impersonation', () => {
clearState() clearState()
window.location.href = '/platform' window.location.href = '/platform'
} }
else if (data.data.session) { else if (data.data.session && state.value) {
// Update expiry from server // Update expiry from server
if (state.value) { state.value.expiresAt = data.data.session.expires_at
state.value.expiresAt = data.data.session.expires_at persistState()
persistState()
}
} }
} }
catch { catch {