From e4c99e23e98ef9357c5fec785412f9814a2c6b29 Mon Sep 17 00:00:00 2001 From: "bert.hausmans" Date: Wed, 29 Apr 2026 23:05:29 +0200 Subject: [PATCH] fix(app): collapse nested if in useImpersonationStore MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit WS-3 session 1b-iii follow-up — sonarjs/no-collapsible-if. useImpersonationStore.ts:103: collapsed nested 'if (state.value)' into the parent 'else if (data.data.session)' clause. Both legs are AND-conditions on the same path, so the merge is semantically identical. Brings the apps/app lint baseline to 0 problems. Co-Authored-By: Claude Opus 4.7 --- apps/app/src/stores/useImpersonationStore.ts | 8 +++----- 1 file changed, 3 insertions(+), 5 deletions(-) diff --git a/apps/app/src/stores/useImpersonationStore.ts b/apps/app/src/stores/useImpersonationStore.ts index 2577bbd9..26fc568d 100644 --- a/apps/app/src/stores/useImpersonationStore.ts +++ b/apps/app/src/stores/useImpersonationStore.ts @@ -100,12 +100,10 @@ export const useImpersonationStore = defineStore('impersonation', () => { clearState() window.location.href = '/platform' } - else if (data.data.session) { + else if (data.data.session && state.value) { // Update expiry from server - if (state.value) { - state.value.expiresAt = data.data.session.expires_at - persistState() - } + state.value.expiresAt = data.data.session.expires_at + persistState() } } catch {