feat(form-builder): add PublishGuard framework + 9 concrete guards (WS-6)

Per-purpose schema validation composes a PurposeGuardProvider returning
a list of guards. Errors collected (not first-fail) so the builder UI
surfaces every issue per save. ConditionalRequirement composes higher-
order without proliferating one-off classes.

RequiresIdentityKeyBinding checks the is_identity_key flag specifically;
the binding-existence check is handled additively by the existing
assertRequiredBindingsPresent in FormSchemaService.

SchemaHasLinkedEvent checks owner_type='event' + owner_id (FormSchema
uses polymorphic owner; there is no direct event_id column).

i18n messages live in lang/nl/form_builder_publish_guards.php.

Refs: RFC-WS-6.md §3 (Q13), §4 (V1, V3)

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This commit is contained in:
2026-04-25 22:55:42 +02:00
parent c5b0210ae7
commit 81a8120f98
21 changed files with 1156 additions and 0 deletions

View File

@@ -0,0 +1,75 @@
<?php
declare(strict_types=1);
namespace App\FormBuilder\Publishing;
use App\Enums\FormBuilder\BindingTargetType;
use App\Enums\FormBuilder\FormFieldBindingMergeStrategy;
use App\Exceptions\FormBuilder\UnknownBindingTargetException;
use App\FormBuilder\Bindings\BindingTypeRegistry;
use App\Models\FormBuilder\FormField;
use App\Models\FormBuilder\FormFieldBinding;
use App\Models\FormBuilder\FormSchema;
/**
* RFC-WS-6 §4 (V1) Append is collection-only. Targets unknown to
* BindingTypeRegistry fail with a distinct context payload so admins
* see the actionable distinction.
*/
final readonly class AppendStrategyRequiresCollectionTarget implements PublishGuard
{
public function __construct(private BindingTypeRegistry $registry) {}
public function code(): string
{
return 'append_strategy_requires_collection_target';
}
public function evaluate(FormSchema $schema): PublishGuardResult
{
/** @var FormField $field */
foreach ($schema->fields as $field) {
/** @var FormFieldBinding $binding */
foreach ($field->bindings as $binding) {
if ($binding->merge_strategy !== FormFieldBindingMergeStrategy::Append) {
continue;
}
$entity = (string) $binding->target_entity;
$attribute = (string) $binding->target_attribute;
try {
$meta = $this->registry->resolve($entity, $attribute);
} catch (UnknownBindingTargetException) {
return PublishGuardResult::failed(
guardCode: $this->code(),
messageKey: 'form_builder_publish_guards.append_strategy_requires_collection_target',
offendingFormFieldId: (string) $field->id,
context: [
'reason' => 'unknown_target',
'entity' => $entity,
'attribute' => $attribute,
],
);
}
if ($meta->type !== BindingTargetType::COLLECTION) {
return PublishGuardResult::failed(
guardCode: $this->code(),
messageKey: 'form_builder_publish_guards.append_strategy_requires_collection_target',
offendingFormFieldId: (string) $field->id,
context: [
'reason' => 'scalar_target',
'entity' => $entity,
'attribute' => $attribute,
'target_type' => $meta->type->value,
],
);
}
}
}
return PublishGuardResult::passed($this->code());
}
}

View File

@@ -0,0 +1,52 @@
<?php
declare(strict_types=1);
namespace App\FormBuilder\Publishing;
use App\Models\FormBuilder\FormSchema;
use Closure;
/**
* RFC-WS-6 §3 (Q13) higher-order composer. Runs the predicate first;
* delegates to the sub-guard only if the predicate returns true.
* Otherwise returns passed().
*/
final readonly class ConditionalRequirement implements PublishGuard
{
/**
* @param Closure(FormSchema): bool $predicate
*/
public function __construct(
private Closure $predicate,
private PublishGuard $subGuard,
private string $code,
) {}
public function code(): string
{
return "conditional:{$this->code}";
}
public function evaluate(FormSchema $schema): PublishGuardResult
{
if (! ($this->predicate)($schema)) {
return PublishGuardResult::passed($this->code());
}
$subResult = $this->subGuard->evaluate($schema);
if ($subResult->passed) {
return PublishGuardResult::passed($this->code());
}
return PublishGuardResult::failed(
guardCode: $this->code(),
messageKey: $subResult->messageKey ?? 'form_builder_publish_guards.conditional',
offendingFormFieldId: $subResult->offendingFormFieldId,
context: array_merge(
$subResult->context,
['delegated_to' => $this->subGuard->code()],
),
);
}
}

View File

@@ -0,0 +1,67 @@
<?php
declare(strict_types=1);
namespace App\FormBuilder\Publishing;
use App\Models\FormBuilder\FormField;
use App\Models\FormBuilder\FormFieldBinding;
use App\Models\FormBuilder\FormSchema;
use App\Models\FormBuilder\FormSchemaSection;
/**
* RFC-WS-6 §3 (Q10) when section_level_submit is active, identity-key
* bindings must live in the first section (lowest sort_order).
*
* No-op when section_level_submit is false. Universal: wires into every
* PurposeGuardProvider.
*/
final class IdentityKeyBindingsOnlyInFirstSection implements PublishGuard
{
public function code(): string
{
return 'identity_key_bindings_only_in_first_section';
}
public function evaluate(FormSchema $schema): PublishGuardResult
{
if (! (bool) $schema->section_level_submit) {
return PublishGuardResult::passed($this->code());
}
$sections = $schema->sections;
if ($sections->isEmpty()) {
return PublishGuardResult::passed($this->code());
}
/** @var FormSchemaSection $first */
$first = $sections->sortBy('sort_order')->first();
$firstSectionId = (string) $first->id;
/** @var FormField $field */
foreach ($schema->fields as $field) {
$hasIdentityKey = false;
/** @var FormFieldBinding $binding */
foreach ($field->bindings as $binding) {
if ((bool) $binding->is_identity_key) {
$hasIdentityKey = true;
break;
}
}
if (! $hasIdentityKey) {
continue;
}
if ((string) $field->form_schema_section_id !== $firstSectionId) {
return PublishGuardResult::failed(
guardCode: $this->code(),
messageKey: 'form_builder_publish_guards.identity_key_bindings_only_in_first_section',
offendingFormFieldId: (string) $field->id,
);
}
}
return PublishGuardResult::passed($this->code());
}
}

View File

@@ -0,0 +1,50 @@
<?php
declare(strict_types=1);
namespace App\FormBuilder\Publishing;
use App\Models\FormBuilder\FormField;
use App\Models\FormBuilder\FormFieldBinding;
use App\Models\FormBuilder\FormSchema;
/**
* RFC-WS-6 §3 (Q8) composite identity-key resolution is out of scope
* for v1; this guard enforces single-key per target_entity at publish
* time. Universal: wires into every PurposeGuardProvider.
*/
final class MaxOneIdentityKeyPerTargetEntity implements PublishGuard
{
public function code(): string
{
return 'max_one_identity_key_per_target_entity';
}
public function evaluate(FormSchema $schema): PublishGuardResult
{
$countsByEntity = [];
/** @var FormField $field */
foreach ($schema->fields as $field) {
/** @var FormFieldBinding $binding */
foreach ($field->bindings as $binding) {
if (! (bool) $binding->is_identity_key) {
continue;
}
$entity = (string) $binding->target_entity;
$countsByEntity[$entity] = ($countsByEntity[$entity] ?? 0) + 1;
}
}
foreach ($countsByEntity as $entity => $count) {
if ($count > 1) {
return PublishGuardResult::failed(
guardCode: $this->code(),
messageKey: 'form_builder_publish_guards.max_one_identity_key_per_target_entity',
context: ['entity' => $entity, 'count' => $count],
);
}
}
return PublishGuardResult::passed($this->code());
}
}

View File

@@ -0,0 +1,57 @@
<?php
declare(strict_types=1);
namespace App\FormBuilder\Publishing;
use App\Models\FormBuilder\FormField;
use App\Models\FormBuilder\FormFieldBinding;
use App\Models\FormBuilder\FormSchema;
/**
* RFC-WS-6 §3 (Q7) within any (target_entity, target_attribute) group,
* no two bindings may share the same trust_level. Tie-breaker exists
* (sort_order) but ambiguity at config time is rejected.
*/
final class NoAmbiguousTrustLevels implements PublishGuard
{
public function code(): string
{
return 'no_ambiguous_trust_levels';
}
public function evaluate(FormSchema $schema): PublishGuardResult
{
/** @var array<string, array<int, array<int, string>>> $byTargetTrust */
$byTargetTrust = [];
/** @var FormField $field */
foreach ($schema->fields as $field) {
/** @var FormFieldBinding $binding */
foreach ($field->bindings as $binding) {
$key = $binding->target_entity . '.' . $binding->target_attribute;
$trust = (int) $binding->trust_level;
$byTargetTrust[$key][$trust][] = (string) $field->id;
}
}
foreach ($byTargetTrust as $target => $trustGroups) {
foreach ($trustGroups as $trust => $fieldIds) {
if (count($fieldIds) > 1) {
return PublishGuardResult::failed(
guardCode: $this->code(),
messageKey: 'form_builder_publish_guards.no_ambiguous_trust_levels',
offendingFormFieldId: $fieldIds[0],
context: [
'target' => $target,
'trust_level' => $trust,
'form_field_ids' => $fieldIds,
],
);
}
}
}
return PublishGuardResult::passed($this->code());
}
}

View File

@@ -0,0 +1,29 @@
<?php
declare(strict_types=1);
namespace App\FormBuilder\Publishing;
use App\Models\FormBuilder\FormSchema;
/**
* RFC-WS-6 §3 (Q13) pre-publish constraint contract.
*
* `FormSchemaService::publish()` walks every guard returned by the
* purpose's `PurposeGuardProvider`, collecting all violations (not
* first-fail) before throwing `PublishGuardViolationException`.
*
* Guards must NOT issue N+1 queries; the service eager-loads
* `fields.bindings` and `sections` before evaluation.
*/
interface PublishGuard
{
public function evaluate(FormSchema $schema): PublishGuardResult;
/**
* Stable identifier used in error responses and tests.
* Examples: 'requires_identity_key_binding:person:email',
* 'append_strategy_requires_collection_target'.
*/
public function code(): string;
}

View File

@@ -0,0 +1,47 @@
<?php
declare(strict_types=1);
namespace App\FormBuilder\Publishing;
/**
* RFC-WS-6 §3 (Q13) outcome of evaluating a single {@see PublishGuard}.
* Sealed via two named constructors: callers cannot construct
* inconsistent states (passed-with-message, etc.).
*/
final readonly class PublishGuardResult
{
/**
* @param array<string, mixed> $context
*/
private function __construct(
public string $guardCode,
public bool $passed,
public ?string $messageKey = null,
public ?string $offendingFormFieldId = null,
public array $context = [],
) {}
public static function passed(string $guardCode): self
{
return new self(guardCode: $guardCode, passed: true);
}
/**
* @param array<string, mixed> $context
*/
public static function failed(
string $guardCode,
string $messageKey,
?string $offendingFormFieldId = null,
array $context = [],
): self {
return new self(
guardCode: $guardCode,
passed: false,
messageKey: $messageKey,
offendingFormFieldId: $offendingFormFieldId,
context: $context,
);
}
}

View File

@@ -0,0 +1,52 @@
<?php
declare(strict_types=1);
namespace App\FormBuilder\Publishing;
use App\Enums\FormBuilder\FormFieldType;
use App\Models\FormBuilder\FormField;
use App\Models\FormBuilder\FormSchema;
/**
* RFC-WS-6 §3 (Q13) at least N fields of the given FormFieldType
* must be present.
*/
final readonly class RequiresFieldType implements PublishGuard
{
public function __construct(
private FormFieldType $type,
private int $minCount = 1,
) {}
public function code(): string
{
return "requires_field_type:{$this->type->value}";
}
public function evaluate(FormSchema $schema): PublishGuardResult
{
$expected = $this->type->value;
$count = 0;
/** @var FormField $field */
foreach ($schema->fields as $field) {
if ($field->field_type === $expected) {
$count++;
}
}
if ($count >= $this->minCount) {
return PublishGuardResult::passed($this->code());
}
return PublishGuardResult::failed(
guardCode: $this->code(),
messageKey: 'form_builder_publish_guards.requires_field_type',
context: [
'type' => $this->type->value,
'min_count' => $this->minCount,
'actual_count' => $count,
],
);
}
}

View File

@@ -0,0 +1,49 @@
<?php
declare(strict_types=1);
namespace App\FormBuilder\Publishing;
use App\Models\FormBuilder\FormField;
use App\Models\FormBuilder\FormFieldBinding;
use App\Models\FormBuilder\FormSchema;
/**
* RFC-WS-6 §3 (Q13) given that the binding's existence is enforced
* upstream by FormSchemaService::assertRequiredBindingsPresent(), this
* guard adds the `is_identity_key=true` flag check.
*/
final readonly class RequiresIdentityKeyBinding implements PublishGuard
{
public function __construct(
private string $entity,
private string $attribute,
) {}
public function code(): string
{
return "requires_identity_key_binding:{$this->entity}:{$this->attribute}";
}
public function evaluate(FormSchema $schema): PublishGuardResult
{
/** @var FormField $field */
foreach ($schema->fields as $field) {
/** @var FormFieldBinding $binding */
foreach ($field->bindings as $binding) {
if ($binding->target_entity === $this->entity
&& $binding->target_attribute === $this->attribute
&& (bool) $binding->is_identity_key
) {
return PublishGuardResult::passed($this->code());
}
}
}
return PublishGuardResult::failed(
guardCode: $this->code(),
messageKey: 'form_builder_publish_guards.requires_identity_key_binding',
context: ['entity' => $this->entity, 'attribute' => $this->attribute],
);
}
}

View File

@@ -0,0 +1,33 @@
<?php
declare(strict_types=1);
namespace App\FormBuilder\Publishing;
use App\Models\FormBuilder\FormSchema;
/**
* RFC-WS-6 §3 (Q13) schema is bound to an event. FormSchema uses a
* polymorphic owner (owner_type/owner_id); this guard accepts only
* `owner_type === 'event'` with a non-null owner_id. Used as the
* sub-guard of ConditionalRequirement when AVAILABILITY_PICKER is present.
*/
final class SchemaHasLinkedEvent implements PublishGuard
{
public function code(): string
{
return 'schema_has_linked_event';
}
public function evaluate(FormSchema $schema): PublishGuardResult
{
if ($schema->owner_type === 'event' && $schema->owner_id !== null) {
return PublishGuardResult::passed($this->code());
}
return PublishGuardResult::failed(
guardCode: $this->code(),
messageKey: 'form_builder_publish_guards.schema_has_linked_event',
);
}
}

View File

@@ -0,0 +1,62 @@
<?php
declare(strict_types=1);
namespace App\FormBuilder\Publishing;
use App\Enums\FormBuilder\FormFieldConfigType;
use App\Enums\FormBuilder\FormFieldType;
use App\Models\FormBuilder\FormField;
use App\Models\FormBuilder\FormFieldConfig;
use App\Models\FormBuilder\FormSchema;
/**
* RFC-WS-6 §3 (Q13) every TAG_PICKER field must have a
* form_field_configs row with config_type=tag_categories and a
* non-empty parameters payload.
*/
final class TagCategoriesConfiguredOnAllPickers implements PublishGuard
{
public function code(): string
{
return 'tag_categories_configured_on_all_pickers';
}
public function evaluate(FormSchema $schema): PublishGuardResult
{
$tagPickerValue = FormFieldType::TAG_PICKER->value;
/** @var FormField $field */
foreach ($schema->fields as $field) {
if ($field->field_type !== $tagPickerValue) {
continue;
}
$hasCategories = false;
/** @var FormFieldConfig $config */
foreach ($field->configs as $config) {
if ($config->config_type !== FormFieldConfigType::TagCategories) {
continue;
}
$params = $config->parameters;
if ($params === []) {
continue;
}
$categories = $params['categories'] ?? null;
if (is_array($categories) && $categories !== []) {
$hasCategories = true;
break;
}
}
if (! $hasCategories) {
return PublishGuardResult::failed(
guardCode: $this->code(),
messageKey: 'form_builder_publish_guards.tag_categories_configured_on_all_pickers',
offendingFormFieldId: (string) $field->id,
);
}
}
return PublishGuardResult::passed($this->code());
}
}

View File

@@ -0,0 +1,19 @@
<?php
declare(strict_types=1);
/**
* RFC-WS-6 §3 (Q13) i18n keys for PublishGuardResult::failed() messages.
* Dutch only for v1 per CLAUDE.md (Crewli is Dutch-first).
*/
return [
'requires_identity_key_binding' => 'Het veld voor :entity.:attribute moet als identity-key zijn aangemerkt.',
'max_one_identity_key_per_target_entity' => 'Per doel-entiteit mag maximaal één binding identity-key zijn.',
'requires_field_type' => 'Dit formulier moet ten minste :min_count veld(en) van type :type bevatten.',
'schema_has_linked_event' => 'Dit formulier moet aan een evenement gekoppeld zijn.',
'tag_categories_configured_on_all_pickers' => 'Alle TAG_PICKER-velden moeten een geconfigureerde categorie hebben.',
'identity_key_bindings_only_in_first_section' => 'Identity-key bindings zijn alleen toegestaan in de eerste sectie wanneer per-sectie inzenden actief is.',
'append_strategy_requires_collection_target' => 'Append-strategie is alleen toegestaan op collectie-typen.',
'no_ambiguous_trust_levels' => 'Twee of meer bindings naar hetzelfde doel hebben hetzelfde trust-niveau — kies een uniek niveau om volgorde te bepalen.',
'conditional' => 'Conditionele eis niet voldaan.',
];

View File

@@ -0,0 +1,80 @@
<?php
declare(strict_types=1);
namespace Tests\Unit\FormBuilder\Publishing;
use App\Enums\FormBuilder\FormFieldBindingMergeStrategy;
use App\FormBuilder\Bindings\BindingTypeRegistry;
use App\FormBuilder\Publishing\AppendStrategyRequiresCollectionTarget;
use App\Models\FormBuilder\FormField;
use App\Models\FormBuilder\FormFieldBinding;
use App\Models\FormBuilder\FormSchema;
use Illuminate\Foundation\Testing\RefreshDatabase;
use Tests\TestCase;
final class AppendStrategyRequiresCollectionTargetTest extends TestCase
{
use RefreshDatabase;
public function test_passes_when_no_append_strategy_present(): void
{
$schema = FormSchema::factory()->create();
$field = FormField::factory()->create(['form_schema_id' => $schema->id]);
FormFieldBinding::factory()->forField($field)->entityOwned('person', 'email')->create([
'merge_strategy' => FormFieldBindingMergeStrategy::Overwrite->value,
]);
$schema->load('fields.bindings');
$result = $this->guard()->evaluate($schema);
$this->assertTrue($result->passed);
}
public function test_fails_with_scalar_target_reason(): void
{
$schema = FormSchema::factory()->create();
$field = FormField::factory()->create(['form_schema_id' => $schema->id]);
FormFieldBinding::factory()->forField($field)->entityOwned('person', 'email')->create([
'merge_strategy' => FormFieldBindingMergeStrategy::Append->value,
]);
$schema->load('fields.bindings');
$result = $this->guard()->evaluate($schema);
$this->assertFalse($result->passed);
$this->assertSame('scalar_target', $result->context['reason']);
}
public function test_passes_with_collection_target(): void
{
$schema = FormSchema::factory()->create();
$field = FormField::factory()->create(['form_schema_id' => $schema->id]);
FormFieldBinding::factory()->forField($field)->entityOwned('person', 'dietary_preferences')->create([
'merge_strategy' => FormFieldBindingMergeStrategy::Append->value,
]);
$schema->load('fields.bindings');
$result = $this->guard()->evaluate($schema);
$this->assertTrue($result->passed);
}
public function test_fails_with_unknown_target_reason(): void
{
$schema = FormSchema::factory()->create();
$field = FormField::factory()->create(['form_schema_id' => $schema->id]);
FormFieldBinding::factory()->forField($field)->entityOwned('person', 'unknown_attr')->create([
'merge_strategy' => FormFieldBindingMergeStrategy::Append->value,
]);
$schema->load('fields.bindings');
$result = $this->guard()->evaluate($schema);
$this->assertFalse($result->passed);
$this->assertSame('unknown_target', $result->context['reason']);
}
private function guard(): AppendStrategyRequiresCollectionTarget
{
return new AppendStrategyRequiresCollectionTarget(
$this->app->make(BindingTypeRegistry::class),
);
}
}

View File

@@ -0,0 +1,85 @@
<?php
declare(strict_types=1);
namespace Tests\Unit\FormBuilder\Publishing;
use App\FormBuilder\Publishing\ConditionalRequirement;
use App\FormBuilder\Publishing\PublishGuard;
use App\FormBuilder\Publishing\PublishGuardResult;
use App\Models\FormBuilder\FormSchema;
use Illuminate\Foundation\Testing\RefreshDatabase;
use Tests\TestCase;
final class ConditionalRequirementTest extends TestCase
{
use RefreshDatabase;
public function test_passes_when_predicate_false_regardless_of_sub_guard(): void
{
$schema = FormSchema::factory()->create();
$guard = new ConditionalRequirement(
predicate: fn (): bool => false,
subGuard: $this->alwaysFails(),
code: 'test_predicate_false',
);
$result = $guard->evaluate($schema);
$this->assertTrue($result->passed);
$this->assertSame('conditional:test_predicate_false', $result->guardCode);
}
public function test_passes_when_predicate_true_and_sub_passes(): void
{
$schema = FormSchema::factory()->create();
$guard = new ConditionalRequirement(
predicate: fn (): bool => true,
subGuard: $this->alwaysPasses(),
code: 'test_sub_passes',
);
$result = $guard->evaluate($schema);
$this->assertTrue($result->passed);
}
public function test_fails_when_predicate_true_and_sub_fails(): void
{
$schema = FormSchema::factory()->create();
$guard = new ConditionalRequirement(
predicate: fn (): bool => true,
subGuard: $this->alwaysFails(),
code: 'test_sub_fails',
);
$result = $guard->evaluate($schema);
$this->assertFalse($result->passed);
$this->assertSame('conditional:test_sub_fails', $result->guardCode);
$this->assertSame('inner_failure', $result->messageKey);
$this->assertSame('inner_guard', $result->context['delegated_to']);
}
private function alwaysPasses(): PublishGuard
{
return new class implements PublishGuard {
public function code(): string { return 'inner_guard'; }
public function evaluate(FormSchema $schema): PublishGuardResult
{
return PublishGuardResult::passed($this->code());
}
};
}
private function alwaysFails(): PublishGuard
{
return new class implements PublishGuard {
public function code(): string { return 'inner_guard'; }
public function evaluate(FormSchema $schema): PublishGuardResult
{
return PublishGuardResult::failed($this->code(), 'inner_failure');
}
};
}
}

View File

@@ -0,0 +1,70 @@
<?php
declare(strict_types=1);
namespace Tests\Unit\FormBuilder\Publishing;
use App\FormBuilder\Publishing\IdentityKeyBindingsOnlyInFirstSection;
use App\Models\FormBuilder\FormField;
use App\Models\FormBuilder\FormFieldBinding;
use App\Models\FormBuilder\FormSchema;
use App\Models\FormBuilder\FormSchemaSection;
use Illuminate\Foundation\Testing\RefreshDatabase;
use Tests\TestCase;
final class IdentityKeyBindingsOnlyInFirstSectionTest extends TestCase
{
use RefreshDatabase;
public function test_no_op_when_section_level_submit_is_false(): void
{
$schema = FormSchema::factory()->create(['section_level_submit' => false]);
FormSchemaSection::factory()->create(['form_schema_id' => $schema->id, 'sort_order' => 0]);
$section2 = FormSchemaSection::factory()->create(['form_schema_id' => $schema->id, 'sort_order' => 1]);
$field = FormField::factory()->create([
'form_schema_id' => $schema->id,
'form_schema_section_id' => $section2->id, // identity key in 2nd section
]);
FormFieldBinding::factory()->forField($field)->entityOwned('person', 'email')
->create(['is_identity_key' => true]);
$schema->load(['fields.bindings', 'sections']);
$result = (new IdentityKeyBindingsOnlyInFirstSection())->evaluate($schema);
$this->assertTrue($result->passed);
}
public function test_passes_when_identity_key_in_first_section(): void
{
$schema = FormSchema::factory()->create(['section_level_submit' => true]);
$section1 = FormSchemaSection::factory()->create(['form_schema_id' => $schema->id, 'sort_order' => 0]);
FormSchemaSection::factory()->create(['form_schema_id' => $schema->id, 'sort_order' => 1]);
$field = FormField::factory()->create([
'form_schema_id' => $schema->id,
'form_schema_section_id' => $section1->id,
]);
FormFieldBinding::factory()->forField($field)->entityOwned('artist', 'email')
->create(['is_identity_key' => true]);
$schema->load(['fields.bindings', 'sections']);
$result = (new IdentityKeyBindingsOnlyInFirstSection())->evaluate($schema);
$this->assertTrue($result->passed);
}
public function test_fails_when_identity_key_in_later_section(): void
{
$schema = FormSchema::factory()->create(['section_level_submit' => true]);
FormSchemaSection::factory()->create(['form_schema_id' => $schema->id, 'sort_order' => 0]);
$section2 = FormSchemaSection::factory()->create(['form_schema_id' => $schema->id, 'sort_order' => 1]);
$field = FormField::factory()->create([
'form_schema_id' => $schema->id,
'form_schema_section_id' => $section2->id,
]);
FormFieldBinding::factory()->forField($field)->entityOwned('artist', 'email')
->create(['is_identity_key' => true]);
$schema->load(['fields.bindings', 'sections']);
$result = (new IdentityKeyBindingsOnlyInFirstSection())->evaluate($schema);
$this->assertFalse($result->passed);
$this->assertSame((string) $field->id, $result->offendingFormFieldId);
}
}

View File

@@ -0,0 +1,70 @@
<?php
declare(strict_types=1);
namespace Tests\Unit\FormBuilder\Publishing;
use App\FormBuilder\Publishing\MaxOneIdentityKeyPerTargetEntity;
use App\Models\FormBuilder\FormField;
use App\Models\FormBuilder\FormFieldBinding;
use App\Models\FormBuilder\FormSchema;
use Illuminate\Foundation\Testing\RefreshDatabase;
use Tests\TestCase;
final class MaxOneIdentityKeyPerTargetEntityTest extends TestCase
{
use RefreshDatabase;
public function test_passes_with_zero_identity_keys(): void
{
$schema = FormSchema::factory()->create();
FormField::factory()->create(['form_schema_id' => $schema->id]);
$schema->load('fields.bindings');
$result = (new MaxOneIdentityKeyPerTargetEntity())->evaluate($schema);
$this->assertTrue($result->passed);
}
public function test_passes_with_one_identity_key_per_entity(): void
{
$schema = FormSchema::factory()->create();
$field = FormField::factory()->create(['form_schema_id' => $schema->id]);
FormFieldBinding::factory()->forField($field)->entityOwned('person', 'email')
->create(['is_identity_key' => true]);
$schema->load('fields.bindings');
$result = (new MaxOneIdentityKeyPerTargetEntity())->evaluate($schema);
$this->assertTrue($result->passed);
}
public function test_fails_with_two_identity_keys_same_entity(): void
{
$schema = FormSchema::factory()->create();
$f1 = FormField::factory()->create(['form_schema_id' => $schema->id]);
$f2 = FormField::factory()->create(['form_schema_id' => $schema->id]);
FormFieldBinding::factory()->forField($f1)->entityOwned('person', 'email')
->create(['is_identity_key' => true]);
FormFieldBinding::factory()->forField($f2)->entityOwned('person', 'first_name')
->create(['is_identity_key' => true]);
$schema->load('fields.bindings');
$result = (new MaxOneIdentityKeyPerTargetEntity())->evaluate($schema);
$this->assertFalse($result->passed);
$this->assertSame('person', $result->context['entity']);
}
public function test_passes_with_one_identity_key_each_on_different_entities(): void
{
$schema = FormSchema::factory()->create();
$f1 = FormField::factory()->create(['form_schema_id' => $schema->id]);
$f2 = FormField::factory()->create(['form_schema_id' => $schema->id]);
FormFieldBinding::factory()->forField($f1)->entityOwned('person', 'email')
->create(['is_identity_key' => true]);
FormFieldBinding::factory()->forField($f2)->entityOwned('company', 'email')
->create(['is_identity_key' => true]);
$schema->load('fields.bindings');
$result = (new MaxOneIdentityKeyPerTargetEntity())->evaluate($schema);
$this->assertTrue($result->passed);
}
}

View File

@@ -0,0 +1,48 @@
<?php
declare(strict_types=1);
namespace Tests\Unit\FormBuilder\Publishing;
use App\FormBuilder\Publishing\NoAmbiguousTrustLevels;
use App\Models\FormBuilder\FormField;
use App\Models\FormBuilder\FormFieldBinding;
use App\Models\FormBuilder\FormSchema;
use Illuminate\Foundation\Testing\RefreshDatabase;
use Tests\TestCase;
final class NoAmbiguousTrustLevelsTest extends TestCase
{
use RefreshDatabase;
public function test_passes_with_unique_trust_levels(): void
{
$schema = FormSchema::factory()->create();
$f1 = FormField::factory()->create(['form_schema_id' => $schema->id]);
$f2 = FormField::factory()->create(['form_schema_id' => $schema->id]);
FormFieldBinding::factory()->forField($f1)->entityOwned('person', 'email')
->create(['trust_level' => 80]);
FormFieldBinding::factory()->forField($f2)->entityOwned('person', 'email')
->create(['trust_level' => 60]);
$schema->load('fields.bindings');
$result = (new NoAmbiguousTrustLevels())->evaluate($schema);
$this->assertTrue($result->passed);
}
public function test_fails_with_duplicate_trust_levels(): void
{
$schema = FormSchema::factory()->create();
$f1 = FormField::factory()->create(['form_schema_id' => $schema->id]);
$f2 = FormField::factory()->create(['form_schema_id' => $schema->id]);
FormFieldBinding::factory()->forField($f1)->entityOwned('person', 'email')
->create(['trust_level' => 50]);
FormFieldBinding::factory()->forField($f2)->entityOwned('person', 'email')
->create(['trust_level' => 50]);
$schema->load('fields.bindings');
$result = (new NoAmbiguousTrustLevels())->evaluate($schema);
$this->assertFalse($result->passed);
$this->assertSame('person.email', $result->context['target']);
}
}

View File

@@ -0,0 +1,50 @@
<?php
declare(strict_types=1);
namespace Tests\Unit\FormBuilder\Publishing;
use App\Enums\FormBuilder\FormFieldType;
use App\FormBuilder\Publishing\RequiresFieldType;
use App\Models\FormBuilder\FormField;
use App\Models\FormBuilder\FormSchema;
use Illuminate\Foundation\Testing\RefreshDatabase;
use Tests\TestCase;
final class RequiresFieldTypeTest extends TestCase
{
use RefreshDatabase;
public function test_passes_when_min_count_satisfied(): void
{
$schema = FormSchema::factory()->create();
FormField::factory()->create([
'form_schema_id' => $schema->id,
'field_type' => FormFieldType::EMAIL->value,
]);
$schema->load('fields');
$result = (new RequiresFieldType(FormFieldType::EMAIL, 1))->evaluate($schema);
$this->assertTrue($result->passed);
}
public function test_fails_when_no_fields_of_type(): void
{
$schema = FormSchema::factory()->create();
FormField::factory()->create([
'form_schema_id' => $schema->id,
'field_type' => FormFieldType::TEXT->value,
]);
$schema->load('fields');
$result = (new RequiresFieldType(FormFieldType::EMAIL, 1))->evaluate($schema);
$this->assertFalse($result->passed);
$this->assertSame(0, $result->context['actual_count']);
}
public function test_code_includes_type_value(): void
{
$guard = new RequiresFieldType(FormFieldType::EMAIL);
$this->assertSame('requires_field_type:EMAIL', $guard->code());
}
}

View File

@@ -0,0 +1,57 @@
<?php
declare(strict_types=1);
namespace Tests\Unit\FormBuilder\Publishing;
use App\FormBuilder\Publishing\RequiresIdentityKeyBinding;
use App\Models\FormBuilder\FormField;
use App\Models\FormBuilder\FormFieldBinding;
use App\Models\FormBuilder\FormSchema;
use Illuminate\Foundation\Testing\RefreshDatabase;
use Tests\TestCase;
final class RequiresIdentityKeyBindingTest extends TestCase
{
use RefreshDatabase;
public function test_code_format(): void
{
$guard = new RequiresIdentityKeyBinding('person', 'email');
$this->assertSame('requires_identity_key_binding:person:email', $guard->code());
}
public function test_passes_when_identity_key_binding_exists(): void
{
$schema = FormSchema::factory()->create();
$field = FormField::factory()->create(['form_schema_id' => $schema->id]);
FormFieldBinding::factory()
->forField($field)
->entityOwned('person', 'email')
->create(['is_identity_key' => true]);
$schema->load('fields.bindings');
$result = (new RequiresIdentityKeyBinding('person', 'email'))->evaluate($schema);
$this->assertTrue($result->passed);
}
public function test_fails_when_binding_present_without_identity_key_flag(): void
{
$schema = FormSchema::factory()->create();
$field = FormField::factory()->create(['form_schema_id' => $schema->id]);
FormFieldBinding::factory()
->forField($field)
->entityOwned('person', 'email')
->create(['is_identity_key' => false]);
$schema->load('fields.bindings');
$result = (new RequiresIdentityKeyBinding('person', 'email'))->evaluate($schema);
$this->assertFalse($result->passed);
$this->assertSame(
'form_builder_publish_guards.requires_identity_key_binding',
$result->messageKey,
);
}
}

View File

@@ -0,0 +1,39 @@
<?php
declare(strict_types=1);
namespace Tests\Unit\FormBuilder\Publishing;
use App\FormBuilder\Publishing\SchemaHasLinkedEvent;
use App\Models\Event;
use App\Models\FormBuilder\FormSchema;
use Illuminate\Foundation\Testing\RefreshDatabase;
use Tests\TestCase;
final class SchemaHasLinkedEventTest extends TestCase
{
use RefreshDatabase;
public function test_passes_when_owner_type_event_with_owner_id(): void
{
$event = Event::factory()->create();
$schema = FormSchema::factory()->create([
'owner_type' => 'event',
'owner_id' => $event->id,
]);
$result = (new SchemaHasLinkedEvent())->evaluate($schema);
$this->assertTrue($result->passed);
}
public function test_fails_when_owner_type_is_not_event(): void
{
$schema = FormSchema::factory()->create([
'owner_type' => 'organisation',
'owner_id' => null,
]);
$result = (new SchemaHasLinkedEvent())->evaluate($schema);
$this->assertFalse($result->passed);
}
}

View File

@@ -0,0 +1,65 @@
<?php
declare(strict_types=1);
namespace Tests\Unit\FormBuilder\Publishing;
use App\Enums\FormBuilder\FormFieldConfigType;
use App\Enums\FormBuilder\FormFieldType;
use App\FormBuilder\Publishing\TagCategoriesConfiguredOnAllPickers;
use App\Models\FormBuilder\FormField;
use App\Models\FormBuilder\FormFieldConfig;
use App\Models\FormBuilder\FormSchema;
use Illuminate\Foundation\Testing\RefreshDatabase;
use Tests\TestCase;
final class TagCategoriesConfiguredOnAllPickersTest extends TestCase
{
use RefreshDatabase;
public function test_passes_when_no_tag_pickers(): void
{
$schema = FormSchema::factory()->create();
FormField::factory()->create([
'form_schema_id' => $schema->id,
'field_type' => FormFieldType::TEXT->value,
]);
$schema->load('fields.configs');
$result = (new TagCategoriesConfiguredOnAllPickers())->evaluate($schema);
$this->assertTrue($result->passed);
}
public function test_passes_when_tag_picker_has_categories_config(): void
{
$schema = FormSchema::factory()->create();
$field = FormField::factory()->create([
'form_schema_id' => $schema->id,
'field_type' => FormFieldType::TAG_PICKER->value,
]);
FormFieldConfig::query()->withoutGlobalScopes()->create([
'owner_type' => 'form_field',
'owner_id' => $field->id,
'config_type' => FormFieldConfigType::TagCategories->value,
'parameters' => ['categories' => ['Veiligheid', 'Horeca']],
]);
$schema->load('fields.configs');
$result = (new TagCategoriesConfiguredOnAllPickers())->evaluate($schema);
$this->assertTrue($result->passed);
}
public function test_fails_when_tag_picker_has_no_categories(): void
{
$schema = FormSchema::factory()->create();
$field = FormField::factory()->create([
'form_schema_id' => $schema->id,
'field_type' => FormFieldType::TAG_PICKER->value,
]);
$schema->load('fields.configs');
$result = (new TagCategoriesConfiguredOnAllPickers())->evaluate($schema);
$this->assertFalse($result->passed);
$this->assertSame((string) $field->id, $result->offendingFormFieldId);
}
}