bert.hausmans/crewli
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

style: pint new-without-parens fix on WS-6 session-2.5 unit tests

Browse Source 
Trailing housekeeping after Task 1 (default_crowd_type_id) commit
d2059e3. The codebase pint config uses `new_with_parentheses = false`
(no `()` after class name when constructor has no args). Two new
tests slipped past with `new FormValue()` / `new RequiresDefaultCrowdType()`
patterns; pint converts them to `new FormValue` / `new RequiresDefaultCrowdType`.

No behavioural change.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This commit is contained in:
bert.hausmans
2026-04-28 09:47:47 +02:00
parent 85f4777e0c
commit 6f1d1a895a
2 changed files with 3 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
api/tests/Unit/FormBuilder/Bindings/PersonProvisionerTest.php
View File

@@ -251,7 +251,7 @@ final class PersonProvisionerTest extends TestCase
private function writeValue(string $submissionId, string $fieldId, mixed $value): void
{
$row = new FormValue();
$row = new FormValue;
$row->form_submission_id = $submissionId;
$row->form_field_id = $fieldId;
// NOT NULL column; empty-string for the explicit-null test scenario.

4
api/tests/Unit/FormBuilder/Publishing/RequiresDefaultCrowdTypeTest.php
View File

@@ -23,7 +23,7 @@ final class RequiresDefaultCrowdTypeTest extends TestCase
$schema->default_crowd_type_id = $crowdType->id;
$schema->save();
$result = (new RequiresDefaultCrowdType())->evaluate($schema->fresh());
$result = (new RequiresDefaultCrowdType)->evaluate($schema->fresh());
$this->assertTrue($result->passed);
$this->assertSame('requires_default_crowd_type', $result->guardCode);
}
@@ -33,7 +33,7 @@ final class RequiresDefaultCrowdTypeTest extends TestCase
$schema = FormSchema::factory()->create();
$this->assertNull($schema->default_crowd_type_id);
$result = (new RequiresDefaultCrowdType())->evaluate($schema);
$result = (new RequiresDefaultCrowdType)->evaluate($schema);
$this->assertFalse($result->passed);
$this->assertSame('requires_default_crowd_type', $result->guardCode);
$this->assertSame(