bert.hausmans
d407cd17de
WS-3 session 1b-ii Task 3 (audit Bucket B — 34 items: 21 absorbed
via ignorePatterns + 14 real fixes; the count of 21 is the actual
non-Tier-3 lint-count drop from the .eslintrc edit, slightly above
the audit's predicted 20 because additional vendored-Vuexy items
beyond the 23 no-explicit-any landed in those paths too).
Config:
- .eslintrc.cjs: add src/@core/** and src/@layouts/** to ignorePatterns.
Vendored Vuexy code, precedent: src/plugins/iconify/*.js. The
CLAUDE.md no-any rule remains in force for our own code under src/.
Real type-safety fixes:
- B.1 ref<any> in our code (3 occurrences):
* blank.vue / default.vue: AppLoadingIndicator template ref now
typed as InstanceType<typeof AppLoadingIndicator> | null. Picks
up the defineExpose'd fallbackHandle / resolveHandle methods.
* NavSearchBar.vue:109: useApi<any>(...) → useApi<SearchResults[]>(...)
matching the existing searchResult ref type.
- B.2 ShiftDetailPanel.vue: moved the Cancel-dialog ref declarations
(isCancelDialogOpen, cancellingAssignment) from line 305-307 to
line 248 — directly above the onCancel handler that uses them.
Resolves all 7 no-use-before-define items in one move. Same-file,
no logic change.
- B.3 useImpersonationStore.ts:119: renamed inner 'stored' to
'storedSnapshot' to resolve shadowing of the outer 'stored' on
line 18.
- B.4 useFormSchemas.ts:97-99: renamed local mutationFn parameter
'confirmed_name' to camelCase 'confirmedName'. Wire-format key
stays snake_case via destructure-alias:
params: confirmedName ? { confirmed_name: confirmedName } : undefined
No callers found in apps/app/src — safe rename.
Tests + typecheck verified green.
Lint baseline: 97 → 62.
Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
48 lines
1.3 KiB
Vue
48 lines
1.3 KiB
Vue
<script lang="ts" setup>
|
||
import type AppLoadingIndicator from '@/components/AppLoadingIndicator.vue'
|
||
|
||
const { injectSkinClasses } = useSkins()
|
||
|
||
// ℹ️ This will inject classes in body tag for accurate styling
|
||
injectSkinClasses()
|
||
|
||
// SECTION: Loading Indicator
|
||
const isFallbackStateActive = ref(false)
|
||
const refLoadingIndicator = ref<InstanceType<typeof AppLoadingIndicator> | null>(null)
|
||
|
||
// watching if the fallback state is active and the refLoadingIndicator component is available
|
||
watch([isFallbackStateActive, refLoadingIndicator], () => {
|
||
if (isFallbackStateActive.value && refLoadingIndicator.value)
|
||
refLoadingIndicator.value.fallbackHandle()
|
||
|
||
if (!isFallbackStateActive.value && refLoadingIndicator.value)
|
||
refLoadingIndicator.value.resolveHandle()
|
||
}, { immediate: true })
|
||
// !SECTION
|
||
</script>
|
||
|
||
<template>
|
||
<AppLoadingIndicator ref="refLoadingIndicator" />
|
||
|
||
<div
|
||
class="layout-wrapper layout-blank"
|
||
data-allow-mismatch
|
||
>
|
||
<RouterView #="{Component}">
|
||
<Suspense
|
||
:timeout="0"
|
||
@fallback="isFallbackStateActive = true"
|
||
@resolve="isFallbackStateActive = false"
|
||
>
|
||
<Component :is="Component" />
|
||
</Suspense>
|
||
</RouterView>
|
||
</div>
|
||
</template>
|
||
|
||
<style>
|
||
.layout-wrapper.layout-blank {
|
||
flex-direction: column;
|
||
}
|
||
</style>
|