Files
crewli/api/app/Models/FormBuilder/FormSchema.php
bert.hausmans d2059e3cff feat(form-builder): per-schema default_crowd_type_id replaces silent oldest() heuristic (WS-6)
Session 2's PersonProvisioner picked CrowdType::oldest() for the org —
silently wrong for multi-crowd_type orgs (Volunteer + Crew + Press are
three distinct crowd_types in one org). Schemas now declare their
target crowd_type explicitly via form_schemas.default_crowd_type_id.
RequiresDefaultCrowdType publish guard prevents misconfigured
event_registration schemas from publishing.

PersonProvisioner: oldest() fallback removed entirely. Misconfiguration
throws no_default_crowd_type at runtime; publish guard prevents it at
config time.

Migration uses a plain ulid() column without DB-level FK because
SQLite's table-rebuild on ALTER ADD FOREIGN KEY cascade-deletes
form_fields rows (form_fields.form_schema_id has cascadeOnDelete on
form_schemas). Application-level integrity via FormSchema::defaultCrowdType()
belongsTo + the publish guard + the runtime failsafe — three load-bearing
checks, none of which require the DB-level constraint.

Three pre-existing migration backfill tests bumped step counts +1 to
account for the new migration sitting between WS-5c and WS-5d:
FormFieldBindingMigrationTest (16→17, 14→15), FormFieldConfigBackfillAndDropTest
(11→12), FormFieldValidationRuleBackfillTest (14→15),
ConditionalLogicBackfillTest (5→6).

Six event_registration test fixtures updated to set default_crowd_type_id
to satisfy the new publish guard.

FormBuilderDevSeeder.resolveDefaultCrowdTypeId() — VOLUNTEER → first-active
→ create-as-needed fallback chain; documented contract for future seeders.

SCHEMA.md updated to v2.7.
Refs: RFC-WS-6.md v1.1 §3 Q8 addendum (Task 4 of this session)

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
2026-04-27 23:47:32 +02:00

161 lines
4.6 KiB
PHP

<?php
declare(strict_types=1);
namespace App\Models\FormBuilder;
use App\Enums\FormBuilder\FormPurpose;
use App\Enums\FormBuilder\FormSchemaSnapshotMode;
use App\Enums\FormBuilder\FormSubmissionMode;
use App\Models\CrowdType;
use App\Models\Organisation;
use App\Models\Scopes\OrganisationScope;
use App\Models\User;
use Illuminate\Database\Eloquent\Concerns\HasUlids;
use Illuminate\Database\Eloquent\Factories\HasFactory;
use Illuminate\Database\Eloquent\Model;
use Illuminate\Database\Eloquent\Relations\BelongsTo;
use Illuminate\Database\Eloquent\Relations\HasMany;
use Illuminate\Database\Eloquent\Relations\MorphTo;
use Illuminate\Database\Eloquent\SoftDeletes;
/**
* Activity log strategy: explicit calls via logSchemaChange() — no LogsActivity
* trait (would produce noise). See ARCH-FORM-BUILDER.md §17.1 and S1 Phase 4b.
*/
final class FormSchema extends Model
{
use HasFactory;
use HasUlids;
use SoftDeletes;
public string $organisationScopeColumn = 'organisation_id';
protected static function booted(): void
{
static::addGlobalScope(new OrganisationScope());
}
protected $fillable = [
'organisation_id',
'owner_type',
'owner_id',
'name',
'slug',
'purpose',
'default_crowd_type_id',
'description',
'is_published',
'submission_mode',
'public_token',
'public_token_previous',
'public_token_rotated_at',
'submission_deadline',
'locale',
'settings',
'version',
'snapshot_mode',
'freeze_on_submit',
'retention_days',
'consent_version',
'section_level_submit',
'auto_save_enabled',
'max_submissions',
'created_by_user_id',
'last_updated_by_user_id',
'edit_lock_user_id',
'edit_lock_expires_at',
];
/** @var array<string, string> */
protected $casts = [
'purpose' => FormPurpose::class,
'submission_mode' => FormSubmissionMode::class,
'snapshot_mode' => FormSchemaSnapshotMode::class,
'is_published' => 'bool',
'freeze_on_submit' => 'bool',
'section_level_submit' => 'bool',
'auto_save_enabled' => 'bool',
'settings' => 'array',
'submission_deadline' => 'datetime',
'public_token_rotated_at' => 'datetime',
'edit_lock_expires_at' => 'datetime',
'version' => 'int',
'retention_days' => 'int',
'max_submissions' => 'int',
];
public function organisation(): BelongsTo
{
return $this->belongsTo(Organisation::class);
}
/** @return BelongsTo<CrowdType, $this> */
public function defaultCrowdType(): BelongsTo
{
return $this->belongsTo(CrowdType::class, 'default_crowd_type_id');
}
public function owner(): MorphTo
{
return $this->morphTo();
}
public function fields(): HasMany
{
return $this->hasMany(FormField::class);
}
public function sections(): HasMany
{
return $this->hasMany(FormSchemaSection::class);
}
public function submissions(): HasMany
{
return $this->hasMany(FormSubmission::class);
}
public function webhooks(): HasMany
{
return $this->hasMany(FormSchemaWebhook::class);
}
public function createdBy(): BelongsTo
{
return $this->belongsTo(User::class, 'created_by_user_id');
}
public function lastUpdatedBy(): BelongsTo
{
return $this->belongsTo(User::class, 'last_updated_by_user_id');
}
public function editLockUser(): BelongsTo
{
return $this->belongsTo(User::class, 'edit_lock_user_id');
}
/**
* Nuanced activity log (ARCH §17.1; S1 Phase 4b). Callers choose which
* events are worth logging — e.g. created/deleted/restored, published
* toggled, purpose changed, freeze_on_submit toggled, retention_days
* changed, consent_version changed, public_token rotated, snapshot_mode
* changed. NOT logged (noise): name/description/slug, settings, locale.
*
* Bulk-fixture suppression: the activitylog.enabled config key is the
* kill-switch. Seeders and one-shot commands wrap themselves in
* App\Support\ActivityLog::suppressed(...). activity()->log() becomes
* a silent no-op while disabled, so no guard is needed here.
*
* @param array<string, mixed> $properties
*/
public function logSchemaChange(string $event, array $properties = []): void
{
activity()
->performedOn($this)
->withProperties($properties)
->log($event);
}
}