bert.hausmans
192353f4bc
Closes the four production gaps that emerged from sessie 3b's admin UI.
What we ship here is final: no further rework planned before production.
Backend
- IndexFailuresRequest validates state/search/failed_at_from/failed_at_to/
listener_class. orgIndex + platformIndex apply them via a single
applyIndexFilters() helper. Search runs case-insensitive `LIKE` on
exception_message; SQL wildcards in user input are escaped.
- New /kpis aggregate endpoint per scope (orgKpis, platformKpis) returns
open / resolved_30d / dismissed_30d / total_submissions in O(1) COUNTs.
Replaces sessie 3b's client-side bucketing of an oversized list.
- Resource expansion: organisation_name, form_schema_label,
resolved_by_user_name, dismissed_by_user_name, exception_trace,
retry_history[]. Eager-loading via indexEagerLoads()/detailEagerLoads()
prevents N+1 (verified by query-count assertion in test).
- New 2026_04_28_181000 migration adds exception_trace (longtext nullable)
to form_submission_action_failures. ApplyBindingsOnFormSubmit listener
now captures $e->getTraceAsString() at failure time.
- New FormSubmissionActionFailureRetryAttemptResource exposes per-attempt
data (timestamp, actor name, outcome, exception details) inside
retry_history[]. Index payloads omit the field via whenLoaded() to keep
list responses lean.
Frontend (apps/app)
- Types updated to mirror the expanded resource shape and the new KPI
endpoint contract. FormFailuresKpis is now { open, resolved_30d,
dismissed_30d, total_submissions } (server-aggregate).
- useFormFailures composable forwards all 5 server filters via
buildIndexParams() (strips empty/whitespace). useFormFailuresKpis hits
the dedicated /kpis endpoint per scope.
- FormFailuresTable replaces client-side bucketing with server-side
filtering, adds listener_class + date-range filter inputs, and renames
the 4th KPI tile to "Submissions" (was "Totaal").
- FormFailureDetail renders organisation_name + form_schema_label in the
header, surfaces an expandable stack-trace card, names the resolved/
dismissed actor in the timeline, and replaces the "v1 placeholder"
retry-history card with a full per-attempt timeline.
ESLint config gap (apps/app)
- New .eslintrc.cjs adapted from the Vuexy reference, minus Vuexy-internal
rules. `pnpm lint` now runs successfully (was previously broken — the
package.json script referenced a missing config). The 80 baseline
violations across the codebase are pre-existing and out of scope for
this session.
Tests + gates
- 24 new backend tests across filter, kpis, and resource-shape suites.
Backend: 1462 → 1486 passing, 0 → 0 failing. Larastan clean. Rector
dry-run unchanged at 354 (pre-Task-1 baseline from f18b55b).
- 3 new vitest tests in apps/app (filter wiring, KPI endpoint, KPI tile
values from /kpis). Vitest: 38 → 41 passing. tsc clean. Portal
unchanged (113 vitest, tsc clean).
- 5 backfill rollback tests bumped --step counts +1 for the new migration.
- Ws6FoundationMigrationTest down/up chain now includes exception_trace
before the parent table is restored.
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
71 lines
2.8 KiB
PHP
71 lines
2.8 KiB
PHP
<?php
|
|
|
|
declare(strict_types=1);
|
|
|
|
namespace App\Http\Resources\FormBuilder;
|
|
|
|
use App\Models\FormBuilder\FormSchema;
|
|
use App\Models\FormBuilder\FormSubmission;
|
|
use App\Models\FormBuilder\FormSubmissionActionFailure;
|
|
use App\Models\Organisation;
|
|
use Illuminate\Http\Request;
|
|
use Illuminate\Http\Resources\Json\JsonResource;
|
|
|
|
/**
|
|
* Sessie 3c (WS-6) — admin UI consumes denormalized labels
|
|
* (`organisation_name`, `form_schema_label`, user names) plus a full
|
|
* stack trace and per-attempt retry history. The relations are
|
|
* eager-loaded by the controller via {@see FormSubmissionActionFailure::loadAdminListContext()}.
|
|
*
|
|
* @mixin FormSubmissionActionFailure
|
|
*/
|
|
final class FormSubmissionActionFailureResource extends JsonResource
|
|
{
|
|
/**
|
|
* @return array<string, mixed>
|
|
*/
|
|
public function toArray(Request $request): array
|
|
{
|
|
/** @var FormSubmission|null $submission */
|
|
$submission = $this->submission;
|
|
/** @var Organisation|null $organisation */
|
|
$organisation = $submission?->organisation;
|
|
/** @var FormSchema|null $schema */
|
|
$schema = $submission?->schema;
|
|
|
|
return [
|
|
'id' => $this->id,
|
|
'form_submission_id' => $this->form_submission_id,
|
|
'binding_id' => $this->binding_id,
|
|
'listener_class' => $this->listener_class,
|
|
'failed_at' => $this->failed_at->toIso8601String(),
|
|
'exception_class' => $this->exception_class,
|
|
'exception_message' => $this->exception_message,
|
|
'exception_trace' => $this->exception_trace,
|
|
'context' => $this->context,
|
|
'retry_count' => $this->retry_count,
|
|
'resolved_at' => $this->resolved_at?->toIso8601String(),
|
|
'resolved_by_user_id' => $this->resolved_by_user_id,
|
|
'resolved_by_user_name' => $this->resolvedBy?->name,
|
|
'resolved_note' => $this->resolved_note,
|
|
'dismissed_at' => $this->dismissed_at?->toIso8601String(),
|
|
'dismissed_by_user_id' => $this->dismissed_by_user_id,
|
|
'dismissed_by_user_name' => $this->dismissedBy?->name,
|
|
'dismissed_reason_type' => $this->dismissed_reason_type?->value,
|
|
'dismissed_reason_note' => $this->dismissed_reason_note,
|
|
'state' => match (true) {
|
|
$this->resolved_at !== null => 'resolved',
|
|
$this->dismissed_at !== null => 'dismissed',
|
|
default => 'open',
|
|
},
|
|
'organisation_id' => $organisation?->id,
|
|
'organisation_name' => $organisation?->name,
|
|
'form_schema_id' => $schema?->id,
|
|
'form_schema_label' => $schema?->name,
|
|
'retry_history' => FormSubmissionActionFailureRetryAttemptResource::collection(
|
|
$this->whenLoaded('retryAttempts'),
|
|
),
|
|
];
|
|
}
|
|
}
|