Files
crewli/api/tests/Feature/FormBuilder/Bindings/Pipeline/SignatureContractPurposePipelineTest.php
bert.hausmans e1551b24bc test(form-builder): per-purpose pipeline smoke for the 6 non-event_registration purposes (WS-6)
RFC §3 Q9 contract — applicator is purpose-agnostic; per-purpose
differences live in PurposeSubjectResolver. Sessie 2's smoke matrix
covered only event_registration; this commit fills the remaining six.

Coverage per file (18 tests total, all passing):

  - SignatureContractPurposePipelineTest (3 tests)
    happy path + conflict resolution + no_auth missing-context
    target: User via auth (User::email/first_name/last_name)

  - UserProfilePurposePipelineTest (3 tests)
    happy path + conflict resolution + no_auth missing-context
    target: User via auth

  - SupplierIntakePurposePipelineTest (3 tests)
    happy path + conflict resolution + no_production_request missing-context
    target: Company subject pre-set by production_request flow

  - PostEventEvaluationPurposePipelineTest (4 tests)
    happy path + conflict resolution + no_person_for_user + no_auth
    target: Person via auth user → Person.event_id link

  - IncidentReportPurposePipelineTest (4 tests)
    happy path (auth + Person link)
    + conflict resolution
    + anonymous-allowed (null subject → COMPLETED, empty applications)
    + auth-without-Person (null subject branch)
    Unique purpose: only one allowed to legitimately resolve to no subject.

  - ArtistAdvancePurposePipelineTest (1 test)
    no_portal_token missing-context only.
    Happy path + subject_not_found branches require the Artist model
    (BACKLOG: ARCH-09); morphTo can't materialise a non-existent class.
    Documented inline; full coverage follows once ARCH-09 lands.

Each test wires the schema_snapshot directly with the applicator-shape
binding entries (matches sessie 2's FormBindingApplicatorIntegrationTest
pattern). All bindings use registered binding-target attributes from
config/form_builder/binding_targets.php to satisfy BindingTypeRegistry's
strict resolve() at apply time.

Refs: RFC-WS-6.md §3 Q9, ARCH-BINDINGS.md § 6.5

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
2026-04-29 00:14:11 +02:00

168 lines
6.2 KiB
PHP

<?php
declare(strict_types=1);
namespace Tests\Feature\FormBuilder\Bindings\Pipeline;
use App\Enums\FormBuilder\ApplyStatus;
use App\Enums\FormBuilder\FormFieldBindingMergeStrategy;
use App\Enums\FormBuilder\FormPurpose;
use App\Exceptions\FormBuilder\PurposeSubjectResolutionException;
use App\FormBuilder\Bindings\BindingPassResult;
use App\FormBuilder\Bindings\FormBindingApplicator;
use App\Models\FormBuilder\FormField;
use App\Models\FormBuilder\FormFieldBinding;
use App\Models\FormBuilder\FormSchema;
use App\Models\FormBuilder\FormSubmission;
use App\Models\FormBuilder\FormValue;
use App\Models\Organisation;
use App\Models\User;
use Illuminate\Foundation\Testing\RefreshDatabase;
use Illuminate\Support\Facades\DB;
use Tests\TestCase;
/**
* End-to-end pipeline smoke for the signature_contract purpose.
*
* RFC §3 Q9 case matrix:
* - Happy path
* - Conflict resolution (trust precedence)
* - Missing required context (no auth user)
*
* Subject resolution: SignatureContractSubjectResolver returns the
* authenticated User (via submission.submitted_by_user_id).
*
* Ref: ARCH-BINDINGS.md § 6.5
*/
final class SignatureContractPurposePipelineTest extends TestCase
{
use RefreshDatabase;
public function test_happy_path_applies_bindings_and_marks_completed(): void
{
$user = User::factory()->create(['first_name' => 'Old', 'last_name' => 'Name']);
$submission = $this->makeSubmission($user, [
'first_name' => ['value' => 'Jan', 'trust' => 70],
'last_name' => ['value' => 'Jansen', 'trust' => 60],
]);
$result = DB::transaction(fn (): BindingPassResult => resolve(FormBindingApplicator::class)->apply($submission));
$this->assertSame(ApplyStatus::COMPLETED, $result->applyStatus());
$this->assertSame('user', $result->provisionedSubjectType);
$this->assertSame((string) $user->id, $result->provisionedSubjectId);
$user->refresh();
$this->assertSame('Jan', $user->first_name);
$this->assertSame('Jansen', $user->last_name);
}
public function test_conflict_resolution_picks_highest_trust(): void
{
$user = User::factory()->create(['first_name' => 'Initial']);
// Two bindings to the same target attribute, different trust levels.
$submission = $this->makeSubmission($user, [
'first_name__low' => ['value' => 'LowTrust', 'trust' => 30, 'attribute' => 'first_name'],
'first_name__high' => ['value' => 'HighTrust', 'trust' => 90, 'attribute' => 'first_name'],
]);
$result = DB::transaction(fn (): BindingPassResult => resolve(FormBindingApplicator::class)->apply($submission));
$this->assertSame(ApplyStatus::COMPLETED, $result->applyStatus());
$user->refresh();
$this->assertSame('HighTrust', $user->first_name);
}
public function test_missing_auth_user_throws_resolution_exception(): void
{
$org = Organisation::factory()->create();
$schema = FormSchema::factory()->create([
'organisation_id' => $org->id,
'purpose' => FormPurpose::SIGNATURE_CONTRACT->value,
]);
// submitted_by_user_id deliberately null + subject_type/id null.
$submission = FormSubmission::factory()->create([
'form_schema_id' => $schema->id,
'submitted_by_user_id' => null,
'subject_type' => null,
'subject_id' => null,
]);
$submission->schema_snapshot = ['fields' => []];
$submission->save();
try {
DB::transaction(fn () => resolve(FormBindingApplicator::class)->apply($submission->fresh()));
$this->fail('Expected PurposeSubjectResolutionException');
} catch (PurposeSubjectResolutionException $e) {
$this->assertSame('signature_contract', $e->purposeSlug);
$this->assertSame('no_auth', $e->reasonCode);
}
}
/**
* @param array<string, array{value:string, trust:int, attribute?:string}> $bindingSpecs
*/
private function makeSubmission(User $user, array $bindingSpecs): FormSubmission
{
$org = Organisation::factory()->create();
$schema = FormSchema::factory()->create([
'organisation_id' => $org->id,
'purpose' => FormPurpose::SIGNATURE_CONTRACT->value,
]);
$submission = FormSubmission::factory()->create([
'form_schema_id' => $schema->id,
'submitted_by_user_id' => $user->id,
'subject_type' => 'user',
'subject_id' => $user->id,
]);
$snapshotFields = [];
foreach ($bindingSpecs as $slug => $spec) {
$attribute = $spec['attribute'] ?? $slug;
$field = FormField::factory()->create([
'form_schema_id' => $schema->id,
'slug' => $slug,
]);
$binding = FormFieldBinding::factory()->forField($field)
->entityOwned('user', $attribute)
->create([
'merge_strategy' => FormFieldBindingMergeStrategy::Overwrite->value,
'trust_level' => $spec['trust'],
]);
$snapshotFields[] = [
'id' => (string) $field->id,
'slug' => (string) $field->slug,
'sort_order' => (int) $field->sort_order,
'bindings' => [[
'id' => (string) $binding->id,
'mode' => 'entity_owned',
'entity' => 'user',
'column' => $attribute,
'merge_strategy' => 'overwrite',
'trust_level' => $spec['trust'],
'is_identity_key' => false,
]],
];
$this->writeValue($submission->id, $field->id, $spec['value']);
}
$submission->schema_snapshot = ['fields' => $snapshotFields];
$submission->save();
return $submission->fresh();
}
private function writeValue(string $submissionId, string $fieldId, mixed $value): void
{
$row = new FormValue;
$row->form_submission_id = $submissionId;
$row->form_field_id = $fieldId;
$row->setAttribute('value', $value);
$row->value_anonymised = false;
$row->save();
}
}