Session 2's PersonProvisioner picked CrowdType::oldest() for the org — silently wrong for multi-crowd_type orgs (Volunteer + Crew + Press are three distinct crowd_types in one org). Schemas now declare their target crowd_type explicitly via form_schemas.default_crowd_type_id. RequiresDefaultCrowdType publish guard prevents misconfigured event_registration schemas from publishing. PersonProvisioner: oldest() fallback removed entirely. Misconfiguration throws no_default_crowd_type at runtime; publish guard prevents it at config time. Migration uses a plain ulid() column without DB-level FK because SQLite's table-rebuild on ALTER ADD FOREIGN KEY cascade-deletes form_fields rows (form_fields.form_schema_id has cascadeOnDelete on form_schemas). Application-level integrity via FormSchema::defaultCrowdType() belongsTo + the publish guard + the runtime failsafe — three load-bearing checks, none of which require the DB-level constraint. Three pre-existing migration backfill tests bumped step counts +1 to account for the new migration sitting between WS-5c and WS-5d: FormFieldBindingMigrationTest (16→17, 14→15), FormFieldConfigBackfillAndDropTest (11→12), FormFieldValidationRuleBackfillTest (14→15), ConditionalLogicBackfillTest (5→6). Six event_registration test fixtures updated to set default_crowd_type_id to satisfy the new publish guard. FormBuilderDevSeeder.resolveDefaultCrowdTypeId() — VOLUNTEER → first-active → create-as-needed fallback chain; documented contract for future seeders. SCHEMA.md updated to v2.7. Refs: RFC-WS-6.md v1.1 §3 Q8 addendum (Task 4 of this session) Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
129 lines
4.8 KiB
PHP
129 lines
4.8 KiB
PHP
<?php
|
|
|
|
declare(strict_types=1);
|
|
|
|
namespace Tests\Feature\FormBuilder\Bindings;
|
|
|
|
use App\Enums\FormBuilder\FormFieldType;
|
|
use App\Enums\FormBuilder\FormPurpose;
|
|
use App\Exceptions\FormBuilder\PurposeRequirementsNotMetException;
|
|
use App\Models\FormBuilder\FormField;
|
|
use App\Models\FormBuilder\FormFieldBinding;
|
|
use App\Models\FormBuilder\FormSchema;
|
|
use App\Models\Organisation;
|
|
use App\Models\User;
|
|
use App\Services\FormBuilder\FormSchemaService;
|
|
use Database\Seeders\RoleSeeder;
|
|
use Illuminate\Foundation\Testing\RefreshDatabase;
|
|
use Tests\TestCase;
|
|
|
|
/**
|
|
* The pre-publish check (`FormSchemaService::publish()`,
|
|
* `PurposeRequirementsNotMetException`, ARCH §17.3) now reads from
|
|
* `form_field_bindings`. External contract (purposeSlug +
|
|
* missingBindings[]) unchanged.
|
|
*/
|
|
final class PublishChecksRelationalBindingsTest extends TestCase
|
|
{
|
|
use RefreshDatabase;
|
|
|
|
private Organisation $org;
|
|
|
|
private User $actor;
|
|
|
|
private FormSchemaService $service;
|
|
|
|
protected function setUp(): void
|
|
{
|
|
parent::setUp();
|
|
$this->seed(RoleSeeder::class);
|
|
|
|
$this->org = Organisation::factory()->create();
|
|
$this->actor = User::factory()->create();
|
|
$this->org->users()->attach($this->actor, ['role' => 'org_admin']);
|
|
$this->actor->assignRole('org_admin');
|
|
setPermissionsTeamId($this->org->id);
|
|
|
|
$this->service = $this->app->make(FormSchemaService::class);
|
|
}
|
|
|
|
public function test_publish_succeeds_when_all_required_bindings_are_in_relational_table(): void
|
|
{
|
|
$schema = $this->service->create(
|
|
$this->org,
|
|
['name' => 'ER', 'purpose' => FormPurpose::EVENT_REGISTRATION->value],
|
|
$this->actor,
|
|
);
|
|
// RFC v1.1 §3 Q8 addendum: event_registration schemas need a
|
|
// default_crowd_type_id (RequiresDefaultCrowdType publish guard).
|
|
$crowdType = \App\Models\CrowdType::factory()->create([
|
|
'organisation_id' => $this->org->id,
|
|
]);
|
|
$schema->default_crowd_type_id = $crowdType->id;
|
|
$schema->save();
|
|
|
|
// WS-6 publish guards require: EMAIL field type, identity_key flag
|
|
// on person.email, unique trust levels per (entity, attribute).
|
|
$emailField = FormField::factory()->create([
|
|
'form_schema_id' => $schema->id,
|
|
'field_type' => FormFieldType::EMAIL->value,
|
|
]);
|
|
FormFieldBinding::factory()->forField($emailField)->entityOwned('person', 'email')
|
|
->create(['is_identity_key' => true, 'trust_level' => 80]);
|
|
|
|
$firstField = FormField::factory()->create(['form_schema_id' => $schema->id]);
|
|
FormFieldBinding::factory()->forField($firstField)->entityOwned('person', 'first_name')
|
|
->create(['trust_level' => 70]);
|
|
|
|
$lastField = FormField::factory()->create(['form_schema_id' => $schema->id]);
|
|
FormFieldBinding::factory()->forField($lastField)->entityOwned('person', 'last_name')
|
|
->create(['trust_level' => 60]);
|
|
|
|
$published = $this->service->publish($schema->fresh(), $this->actor);
|
|
|
|
$this->assertTrue((bool) $published->is_published);
|
|
}
|
|
|
|
public function test_publish_fails_when_required_binding_missing_reports_exact_paths(): void
|
|
{
|
|
$schema = $this->service->create(
|
|
$this->org,
|
|
['name' => 'ER-partial', 'purpose' => FormPurpose::EVENT_REGISTRATION->value],
|
|
$this->actor,
|
|
);
|
|
FormField::factory()->withEntityBinding('person', 'email')->create(['form_schema_id' => $schema->id]);
|
|
|
|
try {
|
|
$this->service->publish($schema->fresh(), $this->actor);
|
|
$this->fail('Expected PurposeRequirementsNotMetException');
|
|
} catch (PurposeRequirementsNotMetException $e) {
|
|
$this->assertSame('event_registration', $e->purposeSlug);
|
|
$this->assertSame(['person.first_name', 'person.last_name'], $e->missingBindings);
|
|
}
|
|
}
|
|
|
|
public function test_publish_ignores_bindings_belonging_to_other_schemas(): void
|
|
{
|
|
$schemaA = $this->service->create(
|
|
$this->org,
|
|
['name' => 'A', 'purpose' => FormPurpose::SUPPLIER_INTAKE->value],
|
|
$this->actor,
|
|
);
|
|
$schemaB = $this->service->create(
|
|
$this->org,
|
|
['name' => 'B', 'purpose' => FormPurpose::SUPPLIER_INTAKE->value],
|
|
$this->actor,
|
|
);
|
|
|
|
FormField::factory()->withEntityBinding('company', 'contact_email')->create(['form_schema_id' => $schemaB->id]);
|
|
|
|
try {
|
|
$this->service->publish($schemaA->fresh(), $this->actor);
|
|
$this->fail('Expected PurposeRequirementsNotMetException');
|
|
} catch (PurposeRequirementsNotMetException $e) {
|
|
$this->assertSame('supplier_intake', $e->purposeSlug);
|
|
$this->assertSame(['company.name'], $e->missingBindings);
|
|
}
|
|
}
|
|
}
|