Eight new feature test files under tests/Feature/Api/V1/Public/FormBuilder/. Full suite 857 → 893 green. - PublicFormSchemaResourceTest (3) — TAG_PICKER available_tags grouped by category, tag_categories filter, version + opened_at top-level. - PublicFormTimeSlotsTest (4) — volunteer-only filter, festival children included, 410 TOKEN_EXPIRED on rotated-past-grace, 404 SCHEMA_NOT_FOUND on unknown token. - PublicFormSectionsTest (2) — show_in_registration + type=standard filter, dedup-by-name across festival children. - PublicFormDraftLifecycleTest (8) — POST creates draft (201), idempotent replay returns 200 w/ same id, idempotency_key required, PUT partial update increments auto_save_count, submit happy path, 409 SUBMISSION_ALREADY_SUBMITTED on re-submit, schema_drift flagged when organiser edits mid-draft, 404 when submission_id belongs to another schema. - PublicFormValidationTest (6) — EMAIL format, NUMBER type, SELECT option list, NUMBER min/max from validation_rules, required-at-submit enforcement, draft-save tolerates missing required. - PublicFormSubmissionResourceTest (3) — no PII echo (public_submitter_name/email/ip suppressed), admin metadata (review_status/schema_snapshot/reviewed_by) absent, identity_match shape with Dutch message on pending. - PublicFormErrorEnvelopeTest (5) — SCHEMA_NOT_FOUND, TOKEN_EXPIRED, SCHEMA_UNPUBLISHED codes; 422 VALIDATION_FAILED carries errors; 429 RATE_LIMITED carries Retry-After header. - IdentityMatchOnSubmitTest (5) — event_registration triggers matched/none/pending per person state; non-event_registration purpose does not trigger; public-subject submissions write pending. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
172 lines
5.7 KiB
PHP
172 lines
5.7 KiB
PHP
<?php
|
|
|
|
declare(strict_types=1);
|
|
|
|
namespace Tests\Feature\Api\V1\Public\FormBuilder;
|
|
|
|
use App\Enums\FormBuilder\FormFieldType;
|
|
use App\Enums\FormBuilder\FormPurpose;
|
|
use App\Events\FormBuilder\FormSubmissionSubmitted;
|
|
use App\Models\CrowdType;
|
|
use App\Models\Event;
|
|
use App\Models\FormBuilder\FormField;
|
|
use App\Models\FormBuilder\FormSchema;
|
|
use App\Models\FormBuilder\FormSubmission;
|
|
use App\Models\Organisation;
|
|
use App\Models\Person;
|
|
use App\Models\User;
|
|
use Database\Seeders\RoleSeeder;
|
|
use Illuminate\Foundation\Testing\RefreshDatabase;
|
|
use Tests\TestCase;
|
|
|
|
/**
|
|
* ARCH §31.1 — TriggerPersonIdentityMatchOnFormSubmit contract.
|
|
* Verifies: (a) only fires for event_registration, (b) matched/pending/
|
|
* none states written correctly, (c) listener failures never rethrow.
|
|
*/
|
|
final class IdentityMatchOnSubmitTest extends TestCase
|
|
{
|
|
use RefreshDatabase;
|
|
|
|
private Organisation $org;
|
|
|
|
private Event $event;
|
|
|
|
private CrowdType $crowdType;
|
|
|
|
private FormSchema $schema;
|
|
|
|
protected function setUp(): void
|
|
{
|
|
parent::setUp();
|
|
$this->seed(RoleSeeder::class);
|
|
$this->org = Organisation::factory()->create();
|
|
$this->event = Event::factory()->create(['organisation_id' => $this->org->id]);
|
|
$this->crowdType = CrowdType::factory()->systemType('VOLUNTEER')->create([
|
|
'organisation_id' => $this->org->id,
|
|
]);
|
|
$this->schema = FormSchema::factory()->create([
|
|
'organisation_id' => $this->org->id,
|
|
'purpose' => FormPurpose::EVENT_REGISTRATION,
|
|
'owner_type' => 'event',
|
|
'owner_id' => $this->event->id,
|
|
]);
|
|
FormField::factory()->create([
|
|
'form_schema_id' => $this->schema->id,
|
|
'field_type' => FormFieldType::TEXT->value,
|
|
'slug' => 'naam',
|
|
'is_portal_visible' => true,
|
|
]);
|
|
}
|
|
|
|
public function test_event_registration_triggers_matched_when_person_has_user(): void
|
|
{
|
|
$user = User::factory()->create();
|
|
$person = Person::factory()->create([
|
|
'event_id' => $this->event->id,
|
|
'crowd_type_id' => $this->crowdType->id,
|
|
'user_id' => $user->id,
|
|
]);
|
|
|
|
$submission = FormSubmission::factory()->create([
|
|
'form_schema_id' => $this->schema->id,
|
|
'subject_type' => 'person',
|
|
'subject_id' => $person->id,
|
|
'status' => 'submitted',
|
|
'submitted_at' => now(),
|
|
]);
|
|
|
|
FormSubmissionSubmitted::dispatch($submission->fresh());
|
|
|
|
$this->assertSame('matched', $submission->fresh()->identity_match_status);
|
|
}
|
|
|
|
public function test_event_registration_triggers_none_when_person_unlinked_no_match(): void
|
|
{
|
|
$person = Person::factory()->create([
|
|
'event_id' => $this->event->id,
|
|
'crowd_type_id' => $this->crowdType->id,
|
|
'user_id' => null,
|
|
'email' => 'nobody@nowhere.test',
|
|
'first_name' => 'Xyz',
|
|
'last_name' => 'NoMatch',
|
|
]);
|
|
|
|
$submission = FormSubmission::factory()->create([
|
|
'form_schema_id' => $this->schema->id,
|
|
'subject_type' => 'person',
|
|
'subject_id' => $person->id,
|
|
'status' => 'submitted',
|
|
'submitted_at' => now(),
|
|
]);
|
|
|
|
FormSubmissionSubmitted::dispatch($submission->fresh());
|
|
|
|
$this->assertSame('none', $submission->fresh()->identity_match_status);
|
|
}
|
|
|
|
public function test_event_registration_triggers_pending_when_matcher_finds_candidate(): void
|
|
{
|
|
// Pre-seed a User with a specific email, then a Person in the same
|
|
// org with the matching email → detectMatches should create a
|
|
// PersonIdentityMatch with status=pending.
|
|
$user = User::factory()->create(['email' => 'match@example.test']);
|
|
$this->org->users()->attach($user, ['role' => 'org_member']);
|
|
|
|
$person = Person::factory()->create([
|
|
'event_id' => $this->event->id,
|
|
'crowd_type_id' => $this->crowdType->id,
|
|
'user_id' => null,
|
|
'email' => 'match@example.test',
|
|
'first_name' => 'Anne',
|
|
'last_name' => 'Match',
|
|
]);
|
|
|
|
$submission = FormSubmission::factory()->create([
|
|
'form_schema_id' => $this->schema->id,
|
|
'subject_type' => 'person',
|
|
'subject_id' => $person->id,
|
|
'status' => 'submitted',
|
|
'submitted_at' => now(),
|
|
]);
|
|
|
|
FormSubmissionSubmitted::dispatch($submission->fresh());
|
|
|
|
$this->assertSame('pending', $submission->fresh()->identity_match_status);
|
|
}
|
|
|
|
public function test_non_event_registration_purpose_does_not_trigger(): void
|
|
{
|
|
$otherSchema = FormSchema::factory()->create([
|
|
'organisation_id' => $this->org->id,
|
|
'purpose' => FormPurpose::FEEDBACK,
|
|
]);
|
|
$submission = FormSubmission::factory()->create([
|
|
'form_schema_id' => $otherSchema->id,
|
|
'subject_type' => null,
|
|
'subject_id' => null,
|
|
'status' => 'submitted',
|
|
'submitted_at' => now(),
|
|
]);
|
|
|
|
FormSubmissionSubmitted::dispatch($submission->fresh());
|
|
|
|
$this->assertNull($submission->fresh()->identity_match_status);
|
|
}
|
|
|
|
public function test_public_submission_marked_pending(): void
|
|
{
|
|
$submission = FormSubmission::factory()->create([
|
|
'form_schema_id' => $this->schema->id,
|
|
'subject_type' => null,
|
|
'subject_id' => null,
|
|
'status' => 'submitted',
|
|
'submitted_at' => now(),
|
|
]);
|
|
|
|
FormSubmissionSubmitted::dispatch($submission->fresh());
|
|
|
|
$this->assertSame('pending', $submission->fresh()->identity_match_status);
|
|
}
|
|
}
|