bert.hausmans 96eb7e91e7 test(timetable): Phase C — observer, resolver, seeder, portal controller tests ...

22 new tests across four files:
  - AdvanceSectionObserverTest (7) — counter recompute on create / status
    transition / delete / is_open toggle no-op / orphaned-section guard /
    no activity-log noise on counter writes
  - ArtistResolverTest (4) — happy path / invalid token / soft-deleted
    artist / SHA-256 digest verification
  - ArtistAdvanceDefaultTest (6) — five-section + slug shape / idempotency
    / per-section field shape / observer-invocation outside tests /
    artisan one-org + all-orgs paths
  - EngagementPortalControllerTest (6) — show 200/404/410 / show-section
    schema + draft values / submit happy-path with submission persistence
    + counter recompute / cross-engagement section returns 404

Implementation tweaks driven by test feedback:
  - OrganisationObserver gated by `app()->runningUnitTests()` — auto-seed
    runs in production but is silent in CI so existing FormSchema-counting
    tests are unperturbed. Tests that need the seeded schema invoke
    `ArtistAdvanceDefault::seedFor()` explicitly.
  - EngagementPortalController idempotency_key uses `aa-` + sha1 prefix
    (28 chars) so it fits the form_submissions.idempotency_key
    varchar(30) column.

Test count: 1709 (Session 2 close) → 1731 (+22).
Larastan: 0 new errors over baseline.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

2026-05-08 22:39:04 +02:00

..

Admin

feat: replace token-based impersonation with enterprise-grade header-based system

2026-04-16 02:42:53 +02:00

Artist

feat(timetable): six artist-domain controllers + RFC §6 routes

2026-05-08 20:56:43 +02:00

Auth

refactor(auth): consolidate to single cookie post single-SPA

2026-05-06 00:24:01 +02:00

FormBuilder

feat(form-builder): admin UI completion — server filters, KPIs, resource expansion (WS-6 sessie 3c)

2026-04-29 00:14:20 +02:00

Portal

test(timetable): Phase C — observer, resolver, seeder, portal controller tests

2026-05-08 22:39:04 +02:00

Traits

refactor(auth): consolidate to single cookie post single-SPA

2026-05-06 00:24:01 +02:00

AccountController.php

feat: account settings with Vuexy tab pattern and MFA banner fix

2026-04-15 22:18:16 +02:00

AuthRefreshController.php

refactor(auth): consolidate to single cookie post single-SPA

2026-05-06 00:24:01 +02:00

CheckEmailController.php

feat(api): registration auth, account creation, check-email & email notifications

2026-04-13 00:37:04 +02:00

CompanyController.php

feat: companies CRUD with person dialog integration and navigation

2026-04-10 11:16:01 +02:00

CrowdListController.php

security: A01-13 — nest all event routes under organisation prefix

2026-04-14 08:16:36 +02:00

CrowdTypeController.php

feat: crowd types management UI with create/edit/deactivate

2026-04-10 11:15:51 +02:00

EmailChangeController.php

feat: password reset, email change with verification, and password change

2026-04-14 15:38:54 +02:00

EmailLogController.php

feat: complete email infrastructure with queue, templates, logging, and API

2026-04-15 20:12:21 +02:00

EventController.php

security: A01-13 — nest all event routes under organisation prefix

2026-04-14 08:16:36 +02:00

FestivalSectionController.php

security: A01-13 — nest all event routes under organisation prefix

2026-04-14 08:16:36 +02:00

InvitationController.php

refactor(auth): consolidate to single cookie post single-SPA

2026-05-06 00:24:01 +02:00

LocationController.php

security: A01-13 — nest all event routes under organisation prefix

2026-04-14 08:16:36 +02:00

LoginController.php

refactor(auth): consolidate to single cookie post single-SPA

2026-05-06 00:24:01 +02:00

LogoutController.php

refactor(auth): consolidate to single cookie post single-SPA

2026-05-06 00:24:01 +02:00

MeController.php

feat(api): add portal_events to auth/me endpoint

2026-04-13 07:38:59 +02:00

MemberController.php

feat: add "Lid toevoegen als deelnemer" shortcut for org members

2026-04-14 18:38:53 +02:00

OrganisationController.php

feat(organisation): add dashboard-stats endpoint

2026-04-17 10:27:37 +02:00

OrganisationEmailSettingsController.php

feat: complete email infrastructure with queue, templates, logging, and API

2026-04-15 20:12:21 +02:00

OrganisationEmailTemplateController.php

feat: complete email infrastructure with queue, templates, logging, and API

2026-04-15 20:12:21 +02:00

PasswordResetController.php

feat: complete email infrastructure with queue, templates, logging, and API

2026-04-15 20:12:21 +02:00

PersonController.php

S2a: purge legacy Form Builder PHP code and routes

2026-04-17 18:43:00 +02:00

PersonIdentityMatchController.php

feat: complete person identity matching system with fuzzy detection, revert, and manual link

2026-04-14 08:44:24 +02:00

PersonTagController.php

refactor(app): unify settings tab design for tags, templates & crowd types

2026-04-12 23:18:10 +02:00

PortalMeController.php

S2a: purge legacy Form Builder PHP code and routes

2026-04-17 18:43:00 +02:00

PortalTokenController.php

fix(timetable): wire portal-token auth through artist_engagements

2026-05-08 19:15:13 +02:00

ShiftAssignmentController.php

security: A01-13 — nest all event routes under organisation prefix

2026-04-14 08:16:36 +02:00

ShiftController.php

security: A01-13 — nest all event routes under organisation prefix

2026-04-14 08:16:36 +02:00

TimeSlotController.php

feat: fix time slot hierarchy — seeder, API include_children, frontend dropdown, navigation

2026-04-14 22:07:37 +02:00

UploadController.php

feat: registration field polish, multi-category tags, file uploads, Partner icon

2026-04-16 18:03:49 +02:00

UserOrganisationTagController.php

feat: person tags system - org-level skills with self-reported and organiser-assigned sources

2026-04-10 11:15:43 +02:00

VolunteerAvailabilityController.php

security: A01-13 — nest all event routes under organisation prefix

2026-04-14 08:16:36 +02:00