Files
crewli/api/tests/Feature/Artist/ArtistEngagementControllerTest.php
bert.hausmans 996dedc11d test(timetable): Phase C — 57 new tests covering session 2 surface
Nine test files under tests/Feature/Artist/ exercising:

  ArtistEngagementStateMachineTest    8 tests — terminal blocks, conditional
                                       gates (Option/Contracted), full happy
                                       path, cancel cascade
  LaneCascadeServiceTest              5 tests — simple move, cascade-bump,
                                       version mismatch, park, unpark
  BumaVatCalculationTest              6 tests — D26 formula coverage:
                                       Organisation/BookingAgency/NotApplicable,
                                       VAT off, breakdown sum, zero fee
  DemoteExpiredOptionsTest            4 tests — expired demote, future
                                       untouched, non-Option untouched, run
                                       twice → single option_expired entry
  IdempotencyKey60sRedisTest          4 tests — missing header 400, first
                                       cache, replay header, failed not cached
  ArtistControllerTest                8 tests — index/create/destroy + cross-
                                       tenant + duplicate detection + restore
  StageControllerTest                 7 tests — create + uniqueness, destroy
                                       cascade-park, reorder permutation,
                                       replaceDays orphan 409 + force_orphan
  ArtistEngagementControllerTest      5 tests — index/create/update/destroy +
                                       422 on invalid status transition
  TimetableMoveControllerTest         3 tests — happy path with idempotency
                                       header, missing header → 400, version
                                       mismatch → 409
  ArtistPolicyTest                    6 tests — role checks, cross-tenant
                                       denial, super_admin bypass, D27 active-
                                       engagement gate
  ActivityLogShapeTest                4 tests — performance.moved cascade
                                       props, status_changed vs cancelled,
                                       stage.day_added subject + props,
                                       stage.reordered on Event subject

Bug fixes surfaced by Phase C:

  Schema reality: events table uses `start_date`/`end_date` (date), not
  `start_at`/`end_at`. Updated WithinEventBounds rule and the two stage_day
  resolvers (LaneCascadeService + MoveTimetablePerformanceRequest) to
  query the actual columns. ArtistResource.engagements_summary upcoming
  filter likewise.

  performances table has no organisation_id column (FK-chain via
  engagement_id). Removed the org-id filter from the Rule::exists in
  MoveTimetablePerformanceRequest; cross-tenant is caught by the policy
  in TimetableMoveController.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
2026-05-08 21:07:29 +02:00

116 lines
3.5 KiB
PHP

<?php
declare(strict_types=1);
namespace Tests\Feature\Artist;
use App\Enums\Artist\ArtistEngagementStatus;
use App\Models\Artist;
use App\Models\ArtistEngagement;
use App\Models\Event;
use App\Models\Organisation;
use App\Models\User;
use Database\Seeders\RoleSeeder;
use Illuminate\Foundation\Testing\RefreshDatabase;
use Laravel\Sanctum\Sanctum;
use Tests\TestCase;
final class ArtistEngagementControllerTest extends TestCase
{
use RefreshDatabase;
private Organisation $org;
private User $orgAdmin;
private Event $event;
private Artist $artist;
protected function setUp(): void
{
parent::setUp();
$this->seed(RoleSeeder::class);
$this->org = Organisation::factory()->create();
$this->orgAdmin = User::factory()->create();
$this->org->users()->attach($this->orgAdmin, ['role' => 'org_admin']);
$this->event = Event::factory()->create(['organisation_id' => $this->org->id]);
$this->artist = Artist::factory()->create(['organisation_id' => $this->org->id]);
}
private function url(string $tail = ''): string
{
return "/api/v1/organisations/{$this->org->id}/events/{$this->event->id}/engagements{$tail}";
}
public function test_index_returns_engagements(): void
{
$a = Artist::factory()->create(['organisation_id' => $this->org->id]);
$b = Artist::factory()->create(['organisation_id' => $this->org->id]);
ArtistEngagement::factory()->create(['artist_id' => $a->id, 'event_id' => $this->event->id]);
ArtistEngagement::factory()->create(['artist_id' => $b->id, 'event_id' => $this->event->id]);
Sanctum::actingAs($this->orgAdmin);
$this->getJson($this->url())->assertOk()->assertJsonCount(2, 'data');
}
public function test_create_engagement(): void
{
Sanctum::actingAs($this->orgAdmin);
$response = $this->postJson($this->url(), [
'artist_id' => $this->artist->id,
'booking_status' => ArtistEngagementStatus::Draft->value,
]);
$response->assertCreated();
}
public function test_create_with_invalid_status_transition_returns_422(): void
{
Sanctum::actingAs($this->orgAdmin);
$response = $this->postJson($this->url(), [
'artist_id' => $this->artist->id,
'booking_status' => ArtistEngagementStatus::Option->value,
// Missing option_expires_at — service should refuse
]);
$response->assertStatus(422);
}
public function test_update_status_transition(): void
{
$eng = ArtistEngagement::factory()->create([
'artist_id' => $this->artist->id,
'event_id' => $this->event->id,
'booking_status' => ArtistEngagementStatus::Draft,
]);
Sanctum::actingAs($this->orgAdmin);
$response = $this->patchJson($this->url("/{$eng->id}"), [
'booking_status' => ArtistEngagementStatus::Requested->value,
]);
$response->assertOk();
$this->assertSame(
ArtistEngagementStatus::Requested,
$eng->refresh()->booking_status,
);
}
public function test_destroy_soft_deletes(): void
{
$eng = ArtistEngagement::factory()->create([
'artist_id' => $this->artist->id,
'event_id' => $this->event->id,
]);
Sanctum::actingAs($this->orgAdmin);
$this->deleteJson($this->url("/{$eng->id}"))->assertNoContent();
$this->assertSoftDeleted('artist_engagements', ['id' => $eng->id]);
}
}