Files
crewli/api/lang/nl/form_builder_publish_guards.php
bert.hausmans d2059e3cff feat(form-builder): per-schema default_crowd_type_id replaces silent oldest() heuristic (WS-6)
Session 2's PersonProvisioner picked CrowdType::oldest() for the org —
silently wrong for multi-crowd_type orgs (Volunteer + Crew + Press are
three distinct crowd_types in one org). Schemas now declare their
target crowd_type explicitly via form_schemas.default_crowd_type_id.
RequiresDefaultCrowdType publish guard prevents misconfigured
event_registration schemas from publishing.

PersonProvisioner: oldest() fallback removed entirely. Misconfiguration
throws no_default_crowd_type at runtime; publish guard prevents it at
config time.

Migration uses a plain ulid() column without DB-level FK because
SQLite's table-rebuild on ALTER ADD FOREIGN KEY cascade-deletes
form_fields rows (form_fields.form_schema_id has cascadeOnDelete on
form_schemas). Application-level integrity via FormSchema::defaultCrowdType()
belongsTo + the publish guard + the runtime failsafe — three load-bearing
checks, none of which require the DB-level constraint.

Three pre-existing migration backfill tests bumped step counts +1 to
account for the new migration sitting between WS-5c and WS-5d:
FormFieldBindingMigrationTest (16→17, 14→15), FormFieldConfigBackfillAndDropTest
(11→12), FormFieldValidationRuleBackfillTest (14→15),
ConditionalLogicBackfillTest (5→6).

Six event_registration test fixtures updated to set default_crowd_type_id
to satisfy the new publish guard.

FormBuilderDevSeeder.resolveDefaultCrowdTypeId() — VOLUNTEER → first-active
→ create-as-needed fallback chain; documented contract for future seeders.

SCHEMA.md updated to v2.7.
Refs: RFC-WS-6.md v1.1 §3 Q8 addendum (Task 4 of this session)

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
2026-04-27 23:47:32 +02:00

21 lines
1.3 KiB
PHP

<?php
declare(strict_types=1);
/**
* RFC-WS-6 §3 (Q13) — i18n keys for PublishGuardResult::failed() messages.
* Dutch only for v1 per CLAUDE.md (Crewli is Dutch-first).
*/
return [
'requires_default_crowd_type' => 'Schema voor vrijwilligers/crew registratie moet een standaard crowd type hebben.',
'requires_identity_key_binding' => 'Het veld voor :entity.:attribute moet als identity-key zijn aangemerkt.',
'max_one_identity_key_per_target_entity' => 'Per doel-entiteit mag maximaal één binding identity-key zijn.',
'requires_field_type' => 'Dit formulier moet ten minste :min_count veld(en) van type :type bevatten.',
'schema_has_linked_event' => 'Dit formulier moet aan een evenement gekoppeld zijn.',
'tag_categories_configured_on_all_pickers' => 'Alle TAG_PICKER-velden moeten een geconfigureerde categorie hebben.',
'identity_key_bindings_only_in_first_section' => 'Identity-key bindings zijn alleen toegestaan in de eerste sectie wanneer per-sectie inzenden actief is.',
'append_strategy_requires_collection_target' => 'Append-strategie is alleen toegestaan op collectie-typen.',
'no_ambiguous_trust_levels' => 'Twee of meer bindings naar hetzelfde doel hebben hetzelfde trust-niveau — kies een uniek niveau om volgorde te bepalen.',
'conditional' => 'Conditionele eis niet voldaan.',
];