bert.hausmans
b47e096a55
Per-attempt retry history (timestamp, user, outcome, exception detail
if failed) replaces the counter-only retry_count tracking.
Changes:
- New `form_submission_action_failure_retry_attempts` table (cascade on
parent delete, nullOnDelete on user). Explicit short FK names
(`fsafra_failure_fk`, `fsafra_user_fk`) — auto-generated names exceed
MySQL's 64-char identifier limit.
- New FormSubmissionActionFailureRetryAttempt model + factory +
succeeded() state.
- Parent FormSubmissionActionFailure gets retryAttempts() HasMany
relation (latest('attempted_at')).
- New FormFailureRetryService centralises the retry-flow logic. Both
the API controller and the artisan command delegate to it. Service
writes a retry_attempt record per attempt; parent's retry_count
stays as denormalised cache for index-view performance.
- Successful retry: attempt(succeeded) + parent.retry_count++ +
parent.resolved_at + parent.resolved_by_user_id + parent.resolved_note
("Geslaagde retry door {actor.name}" or "Geslaagde retry
(geautomatiseerd)" for command-line invocation without an actor).
- Failed retry: attempt(failed) with NEW exception details +
parent.retry_count++. Parent's exception_class/_message stay
audit-immutable — they represent the FIRST failure.
- canBeRetried() now correctly checks both resolved_at AND
dismissed_at (sessie 2's open question Q2 closure).
- New FailureNotRetriableException (controller → 422) and
ParentSubmissionGoneException (controller → 410) for cleaner
flow control.
12 new tests:
- FormSubmissionActionFailureRetryAttemptTest (5 unit tests)
- RetryFlowProducesRetryAttemptsTest (7 integration tests covering
succeeded path, failed path, resolved/dismissed blocking,
multiple-retries chronological ordering, canBeRetried truth tables)
Pre-existing tests touched:
- FormSubmissionActionFailureTest::test_can_be_retried_only_for_open_state
— updated to reflect Q2 closure (resolved now blocks too).
- Ws6FoundationMigrationTest::test_down_methods_clean_up_columns_and_table
— child table must drop before parent (FK constraint).
- 5 backfill test step-counts bumped +1 (new migration sits at top).
SCHEMA.md → v2.9. Schema dump regenerated.
Refs: RFC-WS-6.md §3 Q5 addendum, sessie 2 Q2
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
62 lines
2.0 KiB
PHP
62 lines
2.0 KiB
PHP
<?php
|
|
|
|
declare(strict_types=1);
|
|
|
|
namespace Tests\Unit\Models\FormBuilder;
|
|
|
|
use App\Models\FormBuilder\FormSubmissionActionFailure;
|
|
use App\Models\FormBuilder\FormSubmissionActionFailureRetryAttempt;
|
|
use App\Models\User;
|
|
use Illuminate\Foundation\Testing\RefreshDatabase;
|
|
use Tests\TestCase;
|
|
|
|
final class FormSubmissionActionFailureRetryAttemptTest extends TestCase
|
|
{
|
|
use RefreshDatabase;
|
|
|
|
public function test_factory_creates_a_valid_record(): void
|
|
{
|
|
$attempt = FormSubmissionActionFailureRetryAttempt::factory()->create();
|
|
|
|
$this->assertSame('failed', $attempt->outcome);
|
|
$this->assertNotEmpty($attempt->exception_class);
|
|
$this->assertNotEmpty($attempt->exception_message);
|
|
}
|
|
|
|
public function test_failure_relation_resolves_to_the_parent(): void
|
|
{
|
|
$failure = FormSubmissionActionFailure::factory()->create();
|
|
$attempt = FormSubmissionActionFailureRetryAttempt::factory()
|
|
->for($failure, 'failure')
|
|
->create();
|
|
|
|
$this->assertSame((string) $failure->id, (string) $attempt->failure->id);
|
|
}
|
|
|
|
public function test_attempted_by_relation_resolves_to_the_user(): void
|
|
{
|
|
$user = User::factory()->create();
|
|
$attempt = FormSubmissionActionFailureRetryAttempt::factory()
|
|
->state(['attempted_by_user_id' => $user->id])
|
|
->create();
|
|
|
|
$this->assertSame((string) $user->id, (string) $attempt->attemptedBy->id);
|
|
}
|
|
|
|
public function test_succeeded_state_produces_null_exception_fields(): void
|
|
{
|
|
$attempt = FormSubmissionActionFailureRetryAttempt::factory()->succeeded()->create();
|
|
|
|
$this->assertSame('succeeded', $attempt->outcome);
|
|
$this->assertNull($attempt->exception_class);
|
|
$this->assertNull($attempt->exception_message);
|
|
}
|
|
|
|
public function test_attempted_at_is_cast_to_datetime(): void
|
|
{
|
|
$attempt = FormSubmissionActionFailureRetryAttempt::factory()->create();
|
|
|
|
$this->assertInstanceOf(\Illuminate\Support\Carbon::class, $attempt->attempted_at);
|
|
}
|
|
}
|