bert.hausmans
2064b9901e
WS-5c commit 1 of 4 — relational infrastructure for the conditional- logic tree that replaces form_fields.conditional_logic JSON (ARCH- FORM-BUILDER §8; addendum Q3 WS-5c). Tables: groups (nesting via parent_group_id) + conditions (leaves, value JSON nullable for empty/not_empty). Simple FK to form_fields — addendum Q3 explicitly excludes form_field_library from conditional_ logic scope, so no polymorphic morph here. OrganisationScope cap raised 3 → 5 hops. The conditions chain is 4 hops (condition → group → field → schema → organisation_id column) and the new cap gives headroom for future deeper trees without denormalising form_field_id onto conditions. Cascade observer (FormFieldChildTablesCascadeObserver) extended to physically delete the new groups table on FormField delete (hard or soft). Conditions cascade automatically via the group_id FK on the groups table. Factories: FormFieldConditionalLogicGroupFactory, FormFieldConditional LogicConditionFactory, and FormFieldFactory::withConditionalLogic($tree) for concise test fixtures. Tests: 16 new under tests/Feature/FormBuilder/ConditionalLogic/ (relation, scope, cascade, enum catalogue). 3 new scope-cap tests in ScopeLeakageTest verify 4/5-hop chains pass and 6-hop throws. Hardcoded rollback step counts in WS-5a/b migration tests bumped for the 2 new WS-5c migrations. Baseline 1104 → 1122 green (2988 → 3032 assertions). Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
110 lines
4.5 KiB
PHP
110 lines
4.5 KiB
PHP
<?php
|
|
|
|
declare(strict_types=1);
|
|
|
|
namespace Tests\Feature\FormBuilder\ConditionalLogic;
|
|
|
|
use App\Enums\FormBuilder\FormFieldConditionalLogicConditionOperator;
|
|
use App\Enums\FormBuilder\FormFieldConditionalLogicGroupOperator;
|
|
use App\Models\FormBuilder\FormField;
|
|
use App\Models\FormBuilder\FormFieldConditionalLogicCondition;
|
|
use App\Models\FormBuilder\FormFieldConditionalLogicGroup;
|
|
use App\Models\FormBuilder\FormSchema;
|
|
use App\Models\Organisation;
|
|
use Illuminate\Foundation\Testing\RefreshDatabase;
|
|
use Tests\TestCase;
|
|
|
|
final class FormFieldConditionalLogicGroupRelationTest extends TestCase
|
|
{
|
|
use RefreshDatabase;
|
|
|
|
public function test_field_has_many_conditional_logic_groups(): void
|
|
{
|
|
$org = Organisation::factory()->create();
|
|
$schema = FormSchema::factory()->create(['organisation_id' => $org->id]);
|
|
$field = FormField::factory()->create(['form_schema_id' => $schema->id]);
|
|
|
|
$root = FormFieldConditionalLogicGroup::factory()
|
|
->forField($field)
|
|
->withOperator(FormFieldConditionalLogicGroupOperator::All)
|
|
->create();
|
|
FormFieldConditionalLogicGroup::factory()
|
|
->nestedUnder($root, 0)
|
|
->withOperator(FormFieldConditionalLogicGroupOperator::Any)
|
|
->create();
|
|
|
|
$groups = $field->fresh()->conditionalLogicGroups;
|
|
$this->assertCount(2, $groups);
|
|
}
|
|
|
|
public function test_root_helper_returns_parentless_group(): void
|
|
{
|
|
$org = Organisation::factory()->create();
|
|
$schema = FormSchema::factory()->create(['organisation_id' => $org->id]);
|
|
$field = FormField::factory()->create(['form_schema_id' => $schema->id]);
|
|
|
|
$root = FormFieldConditionalLogicGroup::factory()->forField($field)->create();
|
|
FormFieldConditionalLogicGroup::factory()->nestedUnder($root, 0)->create();
|
|
FormFieldConditionalLogicGroup::factory()->nestedUnder($root, 1)->create();
|
|
|
|
$found = $field->fresh()->rootConditionalLogicGroup();
|
|
$this->assertNotNull($found);
|
|
$this->assertSame($root->id, $found->id);
|
|
$this->assertNull($found->parent_group_id);
|
|
}
|
|
|
|
public function test_group_relations_parent_and_children(): void
|
|
{
|
|
$org = Organisation::factory()->create();
|
|
$schema = FormSchema::factory()->create(['organisation_id' => $org->id]);
|
|
$field = FormField::factory()->create(['form_schema_id' => $schema->id]);
|
|
|
|
$root = FormFieldConditionalLogicGroup::factory()->forField($field)->create();
|
|
$child1 = FormFieldConditionalLogicGroup::factory()->nestedUnder($root, 0)->create();
|
|
$child2 = FormFieldConditionalLogicGroup::factory()->nestedUnder($root, 1)->create();
|
|
|
|
$this->assertSame($root->id, $child1->fresh()->parentGroup->id);
|
|
$childIds = $root->fresh()->childGroups->pluck('id')->sort()->values()->all();
|
|
$this->assertSame(collect([$child1->id, $child2->id])->sort()->values()->all(), $childIds);
|
|
}
|
|
|
|
public function test_group_has_many_conditions(): void
|
|
{
|
|
$org = Organisation::factory()->create();
|
|
$schema = FormSchema::factory()->create(['organisation_id' => $org->id]);
|
|
$field = FormField::factory()->create(['form_schema_id' => $schema->id]);
|
|
|
|
$group = FormFieldConditionalLogicGroup::factory()->forField($field)->create();
|
|
FormFieldConditionalLogicCondition::factory()->inGroup($group, 0)->create();
|
|
FormFieldConditionalLogicCondition::factory()->inGroup($group, 1)->create();
|
|
|
|
$this->assertCount(2, $group->fresh()->conditions);
|
|
}
|
|
|
|
public function test_operator_enum_casts_roundtrip(): void
|
|
{
|
|
$org = Organisation::factory()->create();
|
|
$schema = FormSchema::factory()->create(['organisation_id' => $org->id]);
|
|
$field = FormField::factory()->create(['form_schema_id' => $schema->id]);
|
|
|
|
$group = FormFieldConditionalLogicGroup::factory()
|
|
->forField($field)
|
|
->withOperator(FormFieldConditionalLogicGroupOperator::Any)
|
|
->create();
|
|
|
|
$fresh = $group->fresh();
|
|
$this->assertSame(FormFieldConditionalLogicGroupOperator::Any, $fresh->operator);
|
|
|
|
$condition = FormFieldConditionalLogicCondition::factory()
|
|
->inGroup($group)
|
|
->withOperator(FormFieldConditionalLogicConditionOperator::GreaterThan, 18)
|
|
->create();
|
|
|
|
$this->assertSame(
|
|
FormFieldConditionalLogicConditionOperator::GreaterThan,
|
|
$condition->fresh()->comparison_operator,
|
|
);
|
|
$this->assertSame(18, $condition->fresh()->value);
|
|
}
|
|
}
|