Files
crewli/api/database/factories/FormBuilder/FormFieldConditionalLogicGroupFactory.php
bert.hausmans 2064b9901e feat(form-builder): form_field_conditional_logic_{groups,conditions} tables + OrganisationScope cap raise to 5
WS-5c commit 1 of 4 — relational infrastructure for the conditional-
logic tree that replaces form_fields.conditional_logic JSON (ARCH-
FORM-BUILDER §8; addendum Q3 WS-5c).

Tables: groups (nesting via parent_group_id) + conditions (leaves,
value JSON nullable for empty/not_empty). Simple FK to form_fields —
addendum Q3 explicitly excludes form_field_library from conditional_
logic scope, so no polymorphic morph here.

OrganisationScope cap raised 3 → 5 hops. The conditions chain is
4 hops (condition → group → field → schema → organisation_id column)
and the new cap gives headroom for future deeper trees without
denormalising form_field_id onto conditions.

Cascade observer (FormFieldChildTablesCascadeObserver) extended to
physically delete the new groups table on FormField delete (hard or
soft). Conditions cascade automatically via the group_id FK on the
groups table.

Factories: FormFieldConditionalLogicGroupFactory, FormFieldConditional
LogicConditionFactory, and FormFieldFactory::withConditionalLogic($tree)
for concise test fixtures.

Tests: 16 new under tests/Feature/FormBuilder/ConditionalLogic/
(relation, scope, cascade, enum catalogue). 3 new scope-cap tests in
ScopeLeakageTest verify 4/5-hop chains pass and 6-hop throws. Hardcoded
rollback step counts in WS-5a/b migration tests bumped for the 2 new
WS-5c migrations. Baseline 1104 → 1122 green (2988 → 3032 assertions).

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
2026-04-24 23:43:34 +02:00

51 lines
1.4 KiB
PHP

<?php
declare(strict_types=1);
namespace Database\Factories\FormBuilder;
use App\Enums\FormBuilder\FormFieldConditionalLogicGroupOperator;
use App\Models\FormBuilder\FormField;
use App\Models\FormBuilder\FormFieldConditionalLogicGroup;
use Illuminate\Database\Eloquent\Factories\Factory;
/** @extends Factory<FormFieldConditionalLogicGroup> */
final class FormFieldConditionalLogicGroupFactory extends Factory
{
protected $model = FormFieldConditionalLogicGroup::class;
/** @return array<string, mixed> */
public function definition(): array
{
return [
'form_field_id' => FormField::factory(),
'parent_group_id' => null,
'operator' => FormFieldConditionalLogicGroupOperator::All->value,
'sort_order' => 0,
];
}
public function forField(FormField $field): static
{
return $this->state(fn () => [
'form_field_id' => $field->id,
]);
}
public function withOperator(FormFieldConditionalLogicGroupOperator $operator): static
{
return $this->state(fn () => [
'operator' => $operator->value,
]);
}
public function nestedUnder(FormFieldConditionalLogicGroup $parent, int $sortOrder = 0): static
{
return $this->state(fn () => [
'form_field_id' => $parent->form_field_id,
'parent_group_id' => $parent->id,
'sort_order' => $sortOrder,
]);
}
}