Files
crewli/api/tests/Feature/FormBuilder/Bindings/PublishChecksRelationalBindingsTest.php
bert.hausmans 7a747382a0 feat(form-builder): integrate PublishGuard framework into FormSchemaService::publish() (WS-6)
assertPublishGuardsSatisfied() runs additively after the existing
assertRequiredBindingsPresent() check. Failures are collected (not
first-fail) so PublishGuardViolationException carries the full list
to the builder UI in one 422 response.

PurposeRequirementsNotMetException remains for missing bindings;
PublishGuardViolationException covers semantic constraints
(is_identity_key flag, no-ambiguous-trust, append-collection-only,
section-aware schemas, conditional triggers).

Two pre-existing tests updated their fixtures to satisfy the new
guards (PublishChecksRelationalBindingsTest +
PurposeSchemaLifecycleTest): EMAIL field type + is_identity_key on
person.email + unique trust levels are now required for
event_registration to publish.

Refs: RFC-WS-6.md §3 (Q13)

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
2026-04-25 23:07:12 +02:00

122 lines
4.5 KiB
PHP

<?php
declare(strict_types=1);
namespace Tests\Feature\FormBuilder\Bindings;
use App\Enums\FormBuilder\FormFieldType;
use App\Enums\FormBuilder\FormPurpose;
use App\Exceptions\FormBuilder\PurposeRequirementsNotMetException;
use App\Models\FormBuilder\FormField;
use App\Models\FormBuilder\FormFieldBinding;
use App\Models\FormBuilder\FormSchema;
use App\Models\Organisation;
use App\Models\User;
use App\Services\FormBuilder\FormSchemaService;
use Database\Seeders\RoleSeeder;
use Illuminate\Foundation\Testing\RefreshDatabase;
use Tests\TestCase;
/**
* The pre-publish check (`FormSchemaService::publish()`,
* `PurposeRequirementsNotMetException`, ARCH §17.3) now reads from
* `form_field_bindings`. External contract (purposeSlug +
* missingBindings[]) unchanged.
*/
final class PublishChecksRelationalBindingsTest extends TestCase
{
use RefreshDatabase;
private Organisation $org;
private User $actor;
private FormSchemaService $service;
protected function setUp(): void
{
parent::setUp();
$this->seed(RoleSeeder::class);
$this->org = Organisation::factory()->create();
$this->actor = User::factory()->create();
$this->org->users()->attach($this->actor, ['role' => 'org_admin']);
$this->actor->assignRole('org_admin');
setPermissionsTeamId($this->org->id);
$this->service = $this->app->make(FormSchemaService::class);
}
public function test_publish_succeeds_when_all_required_bindings_are_in_relational_table(): void
{
$schema = $this->service->create(
$this->org,
['name' => 'ER', 'purpose' => FormPurpose::EVENT_REGISTRATION->value],
$this->actor,
);
// WS-6 publish guards require: EMAIL field type, identity_key flag
// on person.email, unique trust levels per (entity, attribute).
$emailField = FormField::factory()->create([
'form_schema_id' => $schema->id,
'field_type' => FormFieldType::EMAIL->value,
]);
FormFieldBinding::factory()->forField($emailField)->entityOwned('person', 'email')
->create(['is_identity_key' => true, 'trust_level' => 80]);
$firstField = FormField::factory()->create(['form_schema_id' => $schema->id]);
FormFieldBinding::factory()->forField($firstField)->entityOwned('person', 'first_name')
->create(['trust_level' => 70]);
$lastField = FormField::factory()->create(['form_schema_id' => $schema->id]);
FormFieldBinding::factory()->forField($lastField)->entityOwned('person', 'last_name')
->create(['trust_level' => 60]);
$published = $this->service->publish($schema->fresh(), $this->actor);
$this->assertTrue((bool) $published->is_published);
}
public function test_publish_fails_when_required_binding_missing_reports_exact_paths(): void
{
$schema = $this->service->create(
$this->org,
['name' => 'ER-partial', 'purpose' => FormPurpose::EVENT_REGISTRATION->value],
$this->actor,
);
FormField::factory()->withEntityBinding('person', 'email')->create(['form_schema_id' => $schema->id]);
try {
$this->service->publish($schema->fresh(), $this->actor);
$this->fail('Expected PurposeRequirementsNotMetException');
} catch (PurposeRequirementsNotMetException $e) {
$this->assertSame('event_registration', $e->purposeSlug);
$this->assertSame(['person.first_name', 'person.last_name'], $e->missingBindings);
}
}
public function test_publish_ignores_bindings_belonging_to_other_schemas(): void
{
$schemaA = $this->service->create(
$this->org,
['name' => 'A', 'purpose' => FormPurpose::SUPPLIER_INTAKE->value],
$this->actor,
);
$schemaB = $this->service->create(
$this->org,
['name' => 'B', 'purpose' => FormPurpose::SUPPLIER_INTAKE->value],
$this->actor,
);
FormField::factory()->withEntityBinding('company', 'contact_email')->create(['form_schema_id' => $schemaB->id]);
try {
$this->service->publish($schemaA->fresh(), $this->actor);
$this->fail('Expected PurposeRequirementsNotMetException');
} catch (PurposeRequirementsNotMetException $e) {
$this->assertSame('supplier_intake', $e->purposeSlug);
$this->assertSame(['company.name'], $e->missingBindings);
}
}
}