bert.hausmans
f94b3fb329
Per RFC-WS-6 §Q3 v1.3 addition 2 (binding hierarchy) + §Q2 (invariant exception).
- Refactored FormBindingApplicatorException from concrete final to abstract
base. Constructor (submissionId, message, previous?) preserves submissionId
as a public readonly property so D2's outer-transaction handler can write
it structurally to form_submission_action_failures.context JSON without
regex-parsing the message. Replaced public-readonly reasonCode property
with abstract reasonCode(): string method.
- Added 3 reason-coded subclasses:
- FormBindingSchemaConfigException -> 'schema_config_error' (422)
- FormBindingInfraException -> 'temporary_error' (503, NOT final because
Timeout extends it)
- FormBindingDataIntegrityException -> 'data_integrity_error' (422)
- Added FormBindingApplicatorTimeoutException extending FormBindingInfraException
(timeout = temporary infra issue from user perspective; reasonCode inherited).
- Added IdentityMatchInvariantViolation as a sibling DomainException — NOT
in the FormBindingApplicatorException hierarchy because it's thrown
outside the binding-applicator pipeline.
- Migrated 3 existing throw sites in FormBindingApplicator::apply():
- 'no_transaction' -> FormBindingInfraException (developer-error wants
infra-triage workflow: GlitchTip alert + retry-after)
- 'no_schema' -> FormBindingSchemaConfigException
- 'unknown_purpose' -> FormBindingSchemaConfigException
- Updated FormBindingApplicatorIntegrationTest::test_no_transaction_guard_present
to assert against the new throw shape (FormBindingInfraException + new
message string) while preserving the test's intent (guard exists in source).
Wiring (deadline wrapper, classifier integration in listener catch +
retry-service recordFailure) lands in D2.
Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
27 lines
968 B
PHP
27 lines
968 B
PHP
<?php
|
|
|
|
declare(strict_types=1);
|
|
|
|
namespace App\Exceptions\FormBuilder;
|
|
|
|
/**
|
|
* Thrown by the deadline-wrapper around FormBindingApplicator when the
|
|
* inner transaction takes longer than config('form_builder.apply_deadline_seconds')
|
|
* (default 5).
|
|
*
|
|
* Extends FormBindingInfraException because from the user's perspective a
|
|
* timeout is identical to any other temporary infra issue: retry should
|
|
* help. The response-shape classification 'temporary_error' is inherited.
|
|
*
|
|
* Per RFC-WS-6 §Q1 v1.3 addition 4.
|
|
*
|
|
* The deadline-wrapper itself lands in D2 (modification to
|
|
* ApplyBindingsOnFormSubmit's apply call site). This class exists in D1
|
|
* so D2's wiring is straightforward.
|
|
*/
|
|
final class FormBindingApplicatorTimeoutException extends FormBindingInfraException
|
|
{
|
|
// No reasonCode override — inherits 'temporary_error' from FormBindingInfraException.
|
|
// No constructor override — inherits (submissionId, message, previous) from the base.
|
|
}
|