WS-5c commit 2 of 4 — the service layer, backfill migration, and
read-path switch. Per addendum Q3, conditional_logic applies to
FormField only — no library mirror and no copyLogic on
FormFieldService::insertFromLibrary.
FormFieldConditionalLogicService owns every write:
- logicFor(field): depth-limited eager-load of the tree
- replaceLogic(field, tree): transactional structure + operator +
field_slug validation + cycle check + activity-log emit
(field.conditional_logic_replaced)
- toJsonShape(root): reconstructs the canonical ARCH §8
`{show_when: {...}}` shape — single source of truth for the
snapshot writer + API resources
- assertSpecsValid(tree): public boundary guard for the FormRequest
strict validator (WS-5c commit 3 wires this up)
- assertNoCycles(field, tree): contract preserved from
FormFieldService::assertNoConditionalCycle, implementation now
reads the relational adjacency.
Backfill migration translates pre-WS-5c conditional_logic JSON to
rows. Strict dispatch: unknown operators / unknown top-level keys /
malformed groups FAIL the migration — Phase A seed-scan confirmed
the catalogue parity, so any drift is a data bug to fix at source,
not silently absorb. Rollback rebuilds canonical JSON and clears
the relational tree.
FormFieldService.create/update route `conditional_logic` through
the new service (matching the extract-and-delegate pattern from
WS-5a bindings and WS-5b validation rules). Snapshot writer + both
resources (FormFieldResource, PublicFormSchemaResource) read via
`toJsonShape(rootConditionalLogicGroup())` — byte-for-byte parity
with the pre-WS-5c JSON contract.
InvalidConditionalLogicSpecException handled in FormFieldController
as 422, same as FrozenSchemaException / CyclicDependencyException.
Tests: 20 new under tests/Feature/FormBuilder/ConditionalLogic/
(service, cycle detection, backfill forward+rollback+failure cases,
snapshot + resource parity). FormFieldApiTest cyclic rejection test
rewritten to use the new factory state. Rollback step counts in
WS-5a/b migration tests bumped +1 for the new backfill migration.
Baseline 1122 → 1142 green (3032 → 3085 assertions).
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
174 lines
6.7 KiB
PHP
174 lines
6.7 KiB
PHP
<?php
|
|
|
|
declare(strict_types=1);
|
|
|
|
namespace App\Http\Resources\FormBuilder;
|
|
|
|
use App\Enums\FormBuilder\FormFieldType;
|
|
use App\Models\FormBuilder\FormField;
|
|
use App\Models\FormBuilder\FormSchema;
|
|
use App\Models\PersonTag;
|
|
use App\Models\Scopes\OrganisationScope;
|
|
use App\Services\FormBuilder\FormFieldConditionalLogicService;
|
|
use App\Services\FormBuilder\FormFieldConfigService;
|
|
use App\Services\FormBuilder\FormFieldValidationRuleService;
|
|
use Illuminate\Http\Request;
|
|
use Illuminate\Http\Resources\Json\JsonResource;
|
|
|
|
/**
|
|
* Public-facing schema response for /public/forms/{public_token}. Strictly
|
|
* limited per ARCH §10: only fields with is_portal_visible=true AND
|
|
* is_admin_only=false; no PII hints, no role_restrictions bleed, no
|
|
* submissions_count.
|
|
*
|
|
* Carries TAG_PICKER `available_tags` so the portal can render the picker
|
|
* without a second request (S2c D1). Also surfaces `version` + `opened_at`
|
|
* so the portal can later detect schema drift at submit time (D5).
|
|
*
|
|
* @mixin FormSchema
|
|
*/
|
|
final class PublicFormSchemaResource extends JsonResource
|
|
{
|
|
/**
|
|
* @return array<string, mixed>
|
|
*/
|
|
public function toArray(Request $request): array
|
|
{
|
|
// Public endpoints must resolve cross-org — skip OrganisationScope
|
|
// on the FormField / FormSchemaSection relations (both registered
|
|
// via addendum Q2 / WS-4 Commit 3). The schema-level tenant check
|
|
// already happens at PublicFormTokenResolver::resolve().
|
|
$this->resource->loadMissing([
|
|
'fields' => fn ($q) => $q->withoutGlobalScope(OrganisationScope::class),
|
|
'fields.validationRules',
|
|
'fields.configs',
|
|
'sections' => fn ($q) => $q->withoutGlobalScope(OrganisationScope::class),
|
|
]);
|
|
|
|
$visibleFields = $this->fields
|
|
->filter(fn ($f) => (bool) $f->is_portal_visible && ! (bool) $f->is_admin_only)
|
|
->values();
|
|
|
|
$organisationId = $this->organisation_id;
|
|
$availableTagsByCategory = $this->availableTagsByCategory($organisationId, $visibleFields);
|
|
|
|
return [
|
|
'id' => $this->id,
|
|
'name' => $this->name,
|
|
'slug' => $this->slug,
|
|
'purpose' => $this->purpose instanceof \BackedEnum ? $this->purpose->value : $this->purpose,
|
|
'description' => $this->description,
|
|
'locale' => $this->locale,
|
|
'version' => (int) $this->version,
|
|
'opened_at' => now()->toIso8601String(),
|
|
'consent_version' => $this->consent_version,
|
|
'submission_deadline' => optional($this->submission_deadline)->toIso8601String(),
|
|
'section_level_submit' => (bool) $this->section_level_submit,
|
|
'sections' => $this->sections->map(fn ($s) => [
|
|
'id' => $s->id,
|
|
'slug' => $s->slug,
|
|
'name' => $s->name,
|
|
'description' => $s->description,
|
|
'sort_order' => (int) $s->sort_order,
|
|
])->values()->all(),
|
|
'fields' => $visibleFields->map(function (FormField $f) use ($availableTagsByCategory): array {
|
|
$isTagPicker = $f->field_type === FormFieldType::TAG_PICKER->value;
|
|
|
|
return [
|
|
'id' => $f->id,
|
|
'slug' => $f->slug,
|
|
'field_type' => $f->field_type,
|
|
'label' => $f->label,
|
|
'help_text' => $f->help_text,
|
|
'options' => is_array($f->options) ? array_values($f->options) : null,
|
|
'available_tags' => $isTagPicker
|
|
? $this->tagsForField($f, $availableTagsByCategory)
|
|
: null,
|
|
'validation_rules' => app(FormFieldValidationRuleService::class)->toJsonShape(
|
|
$f->validationRules,
|
|
),
|
|
'configs' => app(FormFieldConfigService::class)->toJsonShape($f->configs),
|
|
'is_required' => (bool) $f->is_required,
|
|
'display_width' => $f->display_width instanceof \BackedEnum ? $f->display_width->value : $f->display_width,
|
|
'conditional_logic' => app(FormFieldConditionalLogicService::class)->toJsonShape(
|
|
$f->rootConditionalLogicGroup(),
|
|
),
|
|
'sort_order' => (int) $f->sort_order,
|
|
'form_schema_section_id' => $f->form_schema_section_id,
|
|
];
|
|
})->values()->all(),
|
|
];
|
|
}
|
|
|
|
/**
|
|
* Prefetch every active person_tag for the org once and bucket by
|
|
* category so TAG_PICKER fields can apply their own category filter
|
|
* without N+1 queries.
|
|
*
|
|
* @param \Illuminate\Support\Collection<int, FormField> $visibleFields
|
|
* @return array<string, array<int, array<string, string>>> categoryKey → rows
|
|
*/
|
|
private function availableTagsByCategory(?string $organisationId, $visibleFields): array
|
|
{
|
|
if ($organisationId === null) {
|
|
return [];
|
|
}
|
|
$hasTagPicker = $visibleFields->contains(fn ($f) => $f->field_type === FormFieldType::TAG_PICKER->value);
|
|
if (! $hasTagPicker) {
|
|
return [];
|
|
}
|
|
|
|
// Named-scope bypass only — don't unintentionally strip future
|
|
// soft-delete or is_active scopes if any land later.
|
|
$rows = PersonTag::query()
|
|
->withoutGlobalScope(OrganisationScope::class)
|
|
->where('organisation_id', $organisationId)
|
|
->where('is_active', true)
|
|
->orderBy('sort_order')
|
|
->orderBy('name')
|
|
->get(['id', 'name', 'category']);
|
|
|
|
$grouped = [];
|
|
foreach ($rows as $tag) {
|
|
$category = (string) ($tag->category ?? '');
|
|
$grouped[$category][] = [
|
|
'id' => (string) $tag->id,
|
|
'name' => (string) $tag->name,
|
|
'category' => $category,
|
|
];
|
|
}
|
|
|
|
return $grouped;
|
|
}
|
|
|
|
/**
|
|
* @param array<string, array<int, array<string, string>>> $byCategory
|
|
* @return array<int, array<string, string>>
|
|
*/
|
|
private function tagsForField(FormField $field, array $byCategory): array
|
|
{
|
|
$configs = app(FormFieldConfigService::class)->toJsonShape($field->configs);
|
|
$filter = (array) ($configs['tag_categories']['categories'] ?? []);
|
|
|
|
if ($filter === []) {
|
|
$out = [];
|
|
foreach ($byCategory as $rows) {
|
|
foreach ($rows as $row) {
|
|
$out[] = $row;
|
|
}
|
|
}
|
|
|
|
return $out;
|
|
}
|
|
|
|
$out = [];
|
|
foreach ($filter as $category) {
|
|
foreach ($byCategory[(string) $category] ?? [] as $row) {
|
|
$out[] = $row;
|
|
}
|
|
}
|
|
|
|
return $out;
|
|
}
|
|
}
|