bert.hausmans
2064b9901e
WS-5c commit 1 of 4 — relational infrastructure for the conditional- logic tree that replaces form_fields.conditional_logic JSON (ARCH- FORM-BUILDER §8; addendum Q3 WS-5c). Tables: groups (nesting via parent_group_id) + conditions (leaves, value JSON nullable for empty/not_empty). Simple FK to form_fields — addendum Q3 explicitly excludes form_field_library from conditional_ logic scope, so no polymorphic morph here. OrganisationScope cap raised 3 → 5 hops. The conditions chain is 4 hops (condition → group → field → schema → organisation_id column) and the new cap gives headroom for future deeper trees without denormalising form_field_id onto conditions. Cascade observer (FormFieldChildTablesCascadeObserver) extended to physically delete the new groups table on FormField delete (hard or soft). Conditions cascade automatically via the group_id FK on the groups table. Factories: FormFieldConditionalLogicGroupFactory, FormFieldConditional LogicConditionFactory, and FormFieldFactory::withConditionalLogic($tree) for concise test fixtures. Tests: 16 new under tests/Feature/FormBuilder/ConditionalLogic/ (relation, scope, cascade, enum catalogue). 3 new scope-cap tests in ScopeLeakageTest verify 4/5-hop chains pass and 6-hop throws. Hardcoded rollback step counts in WS-5a/b migration tests bumped for the 2 new WS-5c migrations. Baseline 1104 → 1122 green (2988 → 3032 assertions). Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
258 lines
11 KiB
PHP
258 lines
11 KiB
PHP
<?php
|
|
|
|
declare(strict_types=1);
|
|
|
|
namespace Tests\Feature\FormBuilder\Bindings;
|
|
|
|
use App\Models\FormBuilder\FormSchema;
|
|
use App\Models\Organisation;
|
|
use Illuminate\Foundation\Testing\RefreshDatabase;
|
|
use Illuminate\Support\Facades\DB;
|
|
use Illuminate\Support\Facades\Schema;
|
|
use Illuminate\Support\Str;
|
|
use Tests\TestCase;
|
|
|
|
/**
|
|
* Rolls back both WS-5a migrations (drop-columns + create-table), seeds
|
|
* pre-migration JSON into `form_fields.binding` and
|
|
* `form_field_library.default_binding`, then runs the migrations forward
|
|
* and back asserting:
|
|
*
|
|
* - forward: rows land in form_field_bindings with the correct
|
|
* owner_type/owner_id + translated columns; legacy JSON columns are
|
|
* dropped afterwards.
|
|
* - backward: the rollback pair genuinely reconstructs the JSON shape
|
|
* before dropping the table.
|
|
*
|
|
* The "roll back both steps" contract is explicitly documented in
|
|
* `2026_04_25_100001_drop_binding_json_columns.php`.
|
|
*/
|
|
final class FormFieldBindingMigrationTest extends TestCase
|
|
{
|
|
use RefreshDatabase;
|
|
|
|
public function test_forward_migrations_backfill_rows_from_both_json_sources(): void
|
|
{
|
|
// Roll back to pre-WS-5a state: 2 WS-5c migrations
|
|
// (create-conditional-logic-conditions, create-conditional-logic-groups) +
|
|
// 5 WS-5b migrations (drop-validation-cols, configs-backfill,
|
|
// create-configs, validation-rules-backfill, create-validation-rules) +
|
|
// 2 WS-5a migrations (drop-binding-cols, create-bindings) = 9.
|
|
$this->artisan('migrate:rollback', ['--step' => 9])->assertSuccessful();
|
|
$this->assertFalse(Schema::hasTable('form_field_bindings'));
|
|
$this->assertTrue(Schema::hasColumn('form_fields', 'binding'));
|
|
$this->assertTrue(Schema::hasColumn('form_field_library', 'default_binding'));
|
|
|
|
[$fieldAId, $fieldCId, $fieldDId] = $this->seedFieldsWithBindingJson();
|
|
[$libAId, $libCId] = $this->seedLibraryWithBindingJson();
|
|
|
|
$this->artisan('migrate')->assertSuccessful();
|
|
|
|
$this->assertTrue(Schema::hasTable('form_field_bindings'));
|
|
$this->assertFalse(Schema::hasColumn('form_fields', 'binding'));
|
|
$this->assertFalse(Schema::hasColumn('form_field_library', 'default_binding'));
|
|
|
|
$rows = DB::table('form_field_bindings')->get();
|
|
$this->assertCount(5, $rows, 'Expected 3 field + 2 library rows');
|
|
|
|
$fieldRowA = DB::table('form_field_bindings')
|
|
->where('owner_type', 'form_field')
|
|
->where('owner_id', $fieldAId)
|
|
->first();
|
|
$this->assertSame('person', $fieldRowA->target_entity);
|
|
$this->assertSame('email', $fieldRowA->target_attribute);
|
|
$this->assertSame('entity_owned', $fieldRowA->mode);
|
|
$this->assertNull($fieldRowA->sync_direction);
|
|
$this->assertSame('overwrite', $fieldRowA->merge_strategy);
|
|
$this->assertSame(50, (int) $fieldRowA->trust_level);
|
|
$this->assertSame(0, (int) $fieldRowA->is_identity_key);
|
|
|
|
$fieldRowC = DB::table('form_field_bindings')
|
|
->where('owner_type', 'form_field')
|
|
->where('owner_id', $fieldCId)
|
|
->first();
|
|
$this->assertSame('mirrored', $fieldRowC->mode);
|
|
$this->assertSame('write_on_submit', $fieldRowC->sync_direction);
|
|
$this->assertSame('user_profile', $fieldRowC->target_entity);
|
|
$this->assertSame('emergency_contact_name', $fieldRowC->target_attribute);
|
|
|
|
$fieldRowD = DB::table('form_field_bindings')
|
|
->where('owner_type', 'form_field')
|
|
->where('owner_id', $fieldDId)
|
|
->first();
|
|
$this->assertSame('entity_owned', $fieldRowD->mode);
|
|
|
|
$libRowA = DB::table('form_field_bindings')
|
|
->where('owner_type', 'form_field_library')
|
|
->where('owner_id', $libAId)
|
|
->first();
|
|
$this->assertSame('person', $libRowA->target_entity);
|
|
$this->assertSame('first_name', $libRowA->target_attribute);
|
|
$this->assertSame('entity_owned', $libRowA->mode);
|
|
|
|
$libRowC = DB::table('form_field_bindings')
|
|
->where('owner_type', 'form_field_library')
|
|
->where('owner_id', $libCId)
|
|
->first();
|
|
$this->assertSame('mirrored', $libRowC->mode);
|
|
}
|
|
|
|
public function test_rollback_reconstructs_json_and_drops_table(): void
|
|
{
|
|
// Walk back the full WS-5c + WS-5b + WS-5a stack (9 migrations).
|
|
$this->artisan('migrate:rollback', ['--step' => 9])->assertSuccessful();
|
|
[$fieldAId, , ] = $this->seedFieldsWithBindingJson();
|
|
[$libAId, ] = $this->seedLibraryWithBindingJson();
|
|
|
|
$this->artisan('migrate')->assertSuccessful();
|
|
|
|
// Fully-forward state: binding columns gone, rows in form_field_bindings.
|
|
$this->assertFalse(Schema::hasColumn('form_fields', 'binding'));
|
|
$this->assertSame(5, DB::table('form_field_bindings')->count());
|
|
|
|
// Step back over WS-5c (2 migrations) + WS-5b (5 migrations) in one
|
|
// go → restores the pre-WS-5b state (conditional-logic,
|
|
// validation-rules and configs tables gone, validation_rules JSON
|
|
// columns reappear on source tables; binding contract intact).
|
|
$this->artisan('migrate:rollback', ['--step' => 7])->assertSuccessful();
|
|
$this->assertFalse(Schema::hasTable('form_field_conditional_logic_groups'));
|
|
$this->assertFalse(Schema::hasTable('form_field_conditional_logic_conditions'));
|
|
$this->assertFalse(Schema::hasTable('form_field_validation_rules'));
|
|
$this->assertFalse(Schema::hasTable('form_field_configs'));
|
|
$this->assertTrue(Schema::hasTable('form_field_bindings'));
|
|
|
|
// Step back over drop_binding_json_columns → columns reappear empty.
|
|
$this->artisan('migrate:rollback', ['--step' => 1])->assertSuccessful();
|
|
$this->assertTrue(Schema::hasColumn('form_fields', 'binding'));
|
|
$this->assertNull(DB::table('form_fields')->where('id', $fieldAId)->value('binding'));
|
|
|
|
// Step back over create_form_field_bindings → JSON reconstructed.
|
|
$this->artisan('migrate:rollback', ['--step' => 1])->assertSuccessful();
|
|
$this->assertFalse(Schema::hasTable('form_field_bindings'));
|
|
|
|
$field = DB::table('form_fields')->where('id', $fieldAId)->first();
|
|
$this->assertNotNull($field->binding);
|
|
$this->assertSame([
|
|
'mode' => 'entity_owned',
|
|
'entity' => 'person',
|
|
'column' => 'email',
|
|
], json_decode((string) $field->binding, true));
|
|
|
|
$lib = DB::table('form_field_library')->where('id', $libAId)->first();
|
|
$this->assertNotNull($lib->default_binding);
|
|
$this->assertSame([
|
|
'mode' => 'entity_owned',
|
|
'entity' => 'person',
|
|
'column' => 'first_name',
|
|
], json_decode((string) $lib->default_binding, true));
|
|
}
|
|
|
|
/** @return array{0:string,1:string,2:string} */
|
|
private function seedFieldsWithBindingJson(): array
|
|
{
|
|
$org = Organisation::factory()->create();
|
|
$schema = FormSchema::factory()->create(['organisation_id' => $org->id]);
|
|
|
|
$fieldA = (string) Str::ulid();
|
|
$fieldC = (string) Str::ulid();
|
|
$fieldD = (string) Str::ulid();
|
|
|
|
DB::table('form_fields')->insert([
|
|
[
|
|
'id' => $fieldA,
|
|
'form_schema_id' => $schema->id,
|
|
'field_type' => 'EMAIL',
|
|
'slug' => 'email',
|
|
'label' => 'E-mail',
|
|
'binding' => json_encode(['mode' => 'entity_owned', 'entity' => 'person', 'column' => 'email']),
|
|
'value_storage_hint' => 'indexed',
|
|
'sort_order' => 0,
|
|
'created_at' => now(),
|
|
'updated_at' => now(),
|
|
],
|
|
[
|
|
'id' => $fieldC,
|
|
'form_schema_id' => $schema->id,
|
|
'field_type' => 'TEXT',
|
|
'slug' => 'noodcontact',
|
|
'label' => 'Noodcontact',
|
|
'binding' => json_encode([
|
|
'mode' => 'mirrored',
|
|
'entity' => 'user_profile',
|
|
'column' => 'emergency_contact_name',
|
|
'sync_direction' => 'write_on_submit',
|
|
]),
|
|
'value_storage_hint' => 'indexed',
|
|
'sort_order' => 1,
|
|
'created_at' => now(),
|
|
'updated_at' => now(),
|
|
],
|
|
[
|
|
'id' => $fieldD,
|
|
'form_schema_id' => $schema->id,
|
|
'field_type' => 'TEXT',
|
|
'slug' => 'voornaam',
|
|
'label' => 'Voornaam',
|
|
'binding' => json_encode(['mode' => 'entity_owned', 'entity' => 'person', 'column' => 'first_name']),
|
|
'value_storage_hint' => 'indexed',
|
|
'sort_order' => 2,
|
|
'created_at' => now(),
|
|
'updated_at' => now(),
|
|
],
|
|
]);
|
|
|
|
return [$fieldA, $fieldC, $fieldD];
|
|
}
|
|
|
|
/** @return array{0:string,1:string} */
|
|
private function seedLibraryWithBindingJson(): array
|
|
{
|
|
$org = Organisation::factory()->create();
|
|
|
|
$libA = (string) Str::ulid();
|
|
$libC = (string) Str::ulid();
|
|
|
|
DB::table('form_field_library')->insert([
|
|
[
|
|
'id' => $libA,
|
|
'organisation_id' => $org->id,
|
|
'name' => 'Voornaam bibliotheek',
|
|
'slug' => 'voornaam-lib',
|
|
'field_type' => 'TEXT',
|
|
'label' => 'Voornaam',
|
|
'default_binding' => json_encode(['mode' => 'entity_owned', 'entity' => 'person', 'column' => 'first_name']),
|
|
'default_is_required' => false,
|
|
'default_is_filterable' => false,
|
|
'usage_count' => 0,
|
|
'is_system' => false,
|
|
'is_active' => true,
|
|
'created_at' => now(),
|
|
'updated_at' => now(),
|
|
],
|
|
[
|
|
'id' => $libC,
|
|
'organisation_id' => $org->id,
|
|
'name' => 'Noodcontact bibliotheek',
|
|
'slug' => 'noodcontact-lib',
|
|
'field_type' => 'TEXT',
|
|
'label' => 'Noodcontact',
|
|
'default_binding' => json_encode([
|
|
'mode' => 'mirrored',
|
|
'entity' => 'user_profile',
|
|
'column' => 'emergency_contact_phone',
|
|
'sync_direction' => 'write_on_submit',
|
|
]),
|
|
'default_is_required' => false,
|
|
'default_is_filterable' => false,
|
|
'usage_count' => 0,
|
|
'is_system' => false,
|
|
'is_active' => true,
|
|
'created_at' => now(),
|
|
'updated_at' => now(),
|
|
],
|
|
]);
|
|
|
|
return [$libA, $libC];
|
|
}
|
|
}
|