WS-5c commit 1 of 4 — relational infrastructure for the conditional- logic tree that replaces form_fields.conditional_logic JSON (ARCH- FORM-BUILDER §8; addendum Q3 WS-5c). Tables: groups (nesting via parent_group_id) + conditions (leaves, value JSON nullable for empty/not_empty). Simple FK to form_fields — addendum Q3 explicitly excludes form_field_library from conditional_ logic scope, so no polymorphic morph here. OrganisationScope cap raised 3 → 5 hops. The conditions chain is 4 hops (condition → group → field → schema → organisation_id column) and the new cap gives headroom for future deeper trees without denormalising form_field_id onto conditions. Cascade observer (FormFieldChildTablesCascadeObserver) extended to physically delete the new groups table on FormField delete (hard or soft). Conditions cascade automatically via the group_id FK on the groups table. Factories: FormFieldConditionalLogicGroupFactory, FormFieldConditional LogicConditionFactory, and FormFieldFactory::withConditionalLogic($tree) for concise test fixtures. Tests: 16 new under tests/Feature/FormBuilder/ConditionalLogic/ (relation, scope, cascade, enum catalogue). 3 new scope-cap tests in ScopeLeakageTest verify 4/5-hop chains pass and 6-hop throws. Hardcoded rollback step counts in WS-5a/b migration tests bumped for the 2 new WS-5c migrations. Baseline 1104 → 1122 green (2988 → 3032 assertions). Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
123 lines
4.6 KiB
PHP
123 lines
4.6 KiB
PHP
<?php
|
|
|
|
declare(strict_types=1);
|
|
|
|
namespace Tests\Feature\FormBuilder\ConditionalLogic;
|
|
|
|
use App\Enums\FormBuilder\FormFieldConditionalLogicConditionOperator;
|
|
use App\Models\FormBuilder\FormField;
|
|
use App\Models\FormBuilder\FormFieldConditionalLogicCondition;
|
|
use App\Models\FormBuilder\FormFieldConditionalLogicGroup;
|
|
use App\Models\FormBuilder\FormSchema;
|
|
use App\Models\Organisation;
|
|
use Illuminate\Foundation\Testing\RefreshDatabase;
|
|
use Tests\TestCase;
|
|
|
|
final class FormFieldConditionalLogicConditionRelationTest extends TestCase
|
|
{
|
|
use RefreshDatabase;
|
|
|
|
public function test_condition_belongs_to_group(): void
|
|
{
|
|
$org = Organisation::factory()->create();
|
|
$schema = FormSchema::factory()->create(['organisation_id' => $org->id]);
|
|
$field = FormField::factory()->create(['form_schema_id' => $schema->id]);
|
|
|
|
$group = FormFieldConditionalLogicGroup::factory()->forField($field)->create();
|
|
$condition = FormFieldConditionalLogicCondition::factory()->inGroup($group)->create();
|
|
|
|
$this->assertSame($group->id, $condition->fresh()->group->id);
|
|
}
|
|
|
|
public function test_value_roundtrips_through_json_cast(): void
|
|
{
|
|
$org = Organisation::factory()->create();
|
|
$schema = FormSchema::factory()->create(['organisation_id' => $org->id]);
|
|
$field = FormField::factory()->create(['form_schema_id' => $schema->id]);
|
|
$group = FormFieldConditionalLogicGroup::factory()->forField($field)->create();
|
|
|
|
$stringValue = FormFieldConditionalLogicCondition::factory()
|
|
->inGroup($group)
|
|
->withOperator(FormFieldConditionalLogicConditionOperator::Equals, 'NL')
|
|
->create();
|
|
$this->assertSame('NL', $stringValue->fresh()->value);
|
|
|
|
$arrayValue = FormFieldConditionalLogicCondition::factory()
|
|
->inGroup($group)
|
|
->withOperator(FormFieldConditionalLogicConditionOperator::In, ['a', 'b', 'c'])
|
|
->create();
|
|
$this->assertSame(['a', 'b', 'c'], $arrayValue->fresh()->value);
|
|
|
|
$boolValue = FormFieldConditionalLogicCondition::factory()
|
|
->inGroup($group)
|
|
->withOperator(FormFieldConditionalLogicConditionOperator::Equals, true)
|
|
->create();
|
|
$this->assertTrue($boolValue->fresh()->value);
|
|
}
|
|
|
|
public function test_valueless_operators_store_null(): void
|
|
{
|
|
$org = Organisation::factory()->create();
|
|
$schema = FormSchema::factory()->create(['organisation_id' => $org->id]);
|
|
$field = FormField::factory()->create(['form_schema_id' => $schema->id]);
|
|
$group = FormFieldConditionalLogicGroup::factory()->forField($field)->create();
|
|
|
|
$empty = FormFieldConditionalLogicCondition::factory()
|
|
->inGroup($group)
|
|
->withOperator(FormFieldConditionalLogicConditionOperator::Empty)
|
|
->create();
|
|
$this->assertNull($empty->fresh()->value);
|
|
|
|
$notEmpty = FormFieldConditionalLogicCondition::factory()
|
|
->inGroup($group)
|
|
->withOperator(FormFieldConditionalLogicConditionOperator::NotEmpty)
|
|
->create();
|
|
$this->assertNull($notEmpty->fresh()->value);
|
|
}
|
|
|
|
public function test_enum_catalogue_has_ten_operators(): void
|
|
{
|
|
// Parity check against ARCH §8 / Phase A seed-scan confirmed set.
|
|
$values = array_map(
|
|
fn (FormFieldConditionalLogicConditionOperator $case): string => $case->value,
|
|
FormFieldConditionalLogicConditionOperator::cases(),
|
|
);
|
|
|
|
sort($values);
|
|
$this->assertSame([
|
|
'contains',
|
|
'empty',
|
|
'equals',
|
|
'greater_than',
|
|
'in',
|
|
'less_than',
|
|
'not_contains',
|
|
'not_empty',
|
|
'not_equals',
|
|
'not_in',
|
|
], $values);
|
|
}
|
|
|
|
public function test_field_slug_index_supports_reverse_lookup(): void
|
|
{
|
|
$org = Organisation::factory()->create();
|
|
$schema = FormSchema::factory()->create(['organisation_id' => $org->id]);
|
|
$field = FormField::factory()->create(['form_schema_id' => $schema->id]);
|
|
$group = FormFieldConditionalLogicGroup::factory()->forField($field)->create();
|
|
|
|
FormFieldConditionalLogicCondition::factory()
|
|
->inGroup($group)
|
|
->forFieldSlug('gate')
|
|
->create();
|
|
FormFieldConditionalLogicCondition::factory()
|
|
->inGroup($group)
|
|
->forFieldSlug('region')
|
|
->create();
|
|
|
|
$gateHits = FormFieldConditionalLogicCondition::query()
|
|
->where('field_slug', 'gate')
|
|
->count();
|
|
$this->assertSame(1, $gateHits);
|
|
}
|
|
}
|