bert.hausmans
2064b9901e
WS-5c commit 1 of 4 — relational infrastructure for the conditional- logic tree that replaces form_fields.conditional_logic JSON (ARCH- FORM-BUILDER §8; addendum Q3 WS-5c). Tables: groups (nesting via parent_group_id) + conditions (leaves, value JSON nullable for empty/not_empty). Simple FK to form_fields — addendum Q3 explicitly excludes form_field_library from conditional_ logic scope, so no polymorphic morph here. OrganisationScope cap raised 3 → 5 hops. The conditions chain is 4 hops (condition → group → field → schema → organisation_id column) and the new cap gives headroom for future deeper trees without denormalising form_field_id onto conditions. Cascade observer (FormFieldChildTablesCascadeObserver) extended to physically delete the new groups table on FormField delete (hard or soft). Conditions cascade automatically via the group_id FK on the groups table. Factories: FormFieldConditionalLogicGroupFactory, FormFieldConditional LogicConditionFactory, and FormFieldFactory::withConditionalLogic($tree) for concise test fixtures. Tests: 16 new under tests/Feature/FormBuilder/ConditionalLogic/ (relation, scope, cascade, enum catalogue). 3 new scope-cap tests in ScopeLeakageTest verify 4/5-hop chains pass and 6-hop throws. Hardcoded rollback step counts in WS-5a/b migration tests bumped for the 2 new WS-5c migrations. Baseline 1104 → 1122 green (2988 → 3032 assertions). Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
81 lines
3.6 KiB
PHP
81 lines
3.6 KiB
PHP
<?php
|
|
|
|
declare(strict_types=1);
|
|
|
|
namespace Tests\Feature\FormBuilder\ConditionalLogic;
|
|
|
|
use App\Models\FormBuilder\FormField;
|
|
use App\Models\FormBuilder\FormFieldConditionalLogicCondition;
|
|
use App\Models\FormBuilder\FormFieldConditionalLogicGroup;
|
|
use App\Models\FormBuilder\FormSchema;
|
|
use App\Models\Organisation;
|
|
use Illuminate\Foundation\Testing\RefreshDatabase;
|
|
use Illuminate\Support\Facades\DB;
|
|
use Tests\TestCase;
|
|
|
|
final class FormFieldConditionalLogicCascadeTest extends TestCase
|
|
{
|
|
use RefreshDatabase;
|
|
|
|
public function test_field_hard_delete_cascades_groups_and_conditions(): void
|
|
{
|
|
$org = Organisation::factory()->create();
|
|
$schema = FormSchema::factory()->create(['organisation_id' => $org->id]);
|
|
$field = FormField::factory()->create(['form_schema_id' => $schema->id]);
|
|
|
|
$root = FormFieldConditionalLogicGroup::factory()->forField($field)->create();
|
|
$child = FormFieldConditionalLogicGroup::factory()->nestedUnder($root, 0)->create();
|
|
FormFieldConditionalLogicCondition::factory()->inGroup($root, 0)->create();
|
|
FormFieldConditionalLogicCondition::factory()->inGroup($child, 0)->create();
|
|
|
|
$this->assertSame(2, FormFieldConditionalLogicGroup::query()->count());
|
|
$this->assertSame(2, FormFieldConditionalLogicCondition::query()->count());
|
|
|
|
// Hard delete via raw query bypasses SoftDeletes — exercises the
|
|
// DB-level `ON DELETE CASCADE` on `form_field_id`.
|
|
DB::table('form_fields')->where('id', $field->id)->delete();
|
|
|
|
$this->assertSame(0, FormFieldConditionalLogicGroup::query()->count());
|
|
$this->assertSame(0, FormFieldConditionalLogicCondition::query()->count());
|
|
}
|
|
|
|
public function test_field_soft_delete_cascades_via_observer(): void
|
|
{
|
|
$org = Organisation::factory()->create();
|
|
$schema = FormSchema::factory()->create(['organisation_id' => $org->id]);
|
|
$field = FormField::factory()->create(['form_schema_id' => $schema->id]);
|
|
|
|
$root = FormFieldConditionalLogicGroup::factory()->forField($field)->create();
|
|
FormFieldConditionalLogicCondition::factory()->inGroup($root, 0)->create();
|
|
|
|
$field->delete();
|
|
|
|
// Soft delete keeps the `form_fields` row (deleted_at set) but the
|
|
// cascade observer physically clears child rows — conditional-logic
|
|
// state is current state, not audit.
|
|
$this->assertNotNull($field->fresh()->deleted_at);
|
|
$this->assertSame(0, FormFieldConditionalLogicGroup::query()->count());
|
|
$this->assertSame(0, FormFieldConditionalLogicCondition::query()->count());
|
|
}
|
|
|
|
public function test_parent_group_delete_cascades_to_children_and_conditions(): void
|
|
{
|
|
$org = Organisation::factory()->create();
|
|
$schema = FormSchema::factory()->create(['organisation_id' => $org->id]);
|
|
$field = FormField::factory()->create(['form_schema_id' => $schema->id]);
|
|
|
|
$root = FormFieldConditionalLogicGroup::factory()->forField($field)->create();
|
|
$child = FormFieldConditionalLogicGroup::factory()->nestedUnder($root, 0)->create();
|
|
FormFieldConditionalLogicCondition::factory()->inGroup($root, 0)->create();
|
|
FormFieldConditionalLogicCondition::factory()->inGroup($child, 0)->create();
|
|
|
|
$this->assertSame(2, FormFieldConditionalLogicGroup::query()->count());
|
|
$this->assertSame(2, FormFieldConditionalLogicCondition::query()->count());
|
|
|
|
$root->delete();
|
|
|
|
$this->assertSame(0, FormFieldConditionalLogicGroup::query()->count());
|
|
$this->assertSame(0, FormFieldConditionalLogicCondition::query()->count());
|
|
}
|
|
}
|