Files
crewli/api/database/factories/FormBuilder/FormFieldFactory.php
bert.hausmans 079d10975b refactor(form-builder): strict validator + drop form_fields.conditional_logic JSON column
WS-5c commit 3 of 4. FormRequests (Store/Update) now reject bad
conditional_logic trees at the HTTP boundary — the `after()` hook
unwraps the `show_when` envelope, normalises legacy `{all|any: [...]}`
group shape to the service's internal form, and delegates to
`FormFieldConditionalLogicService::assertSpecsValid()`. Unknown
operators, root conditions, empty groups, and unknown field_slug
references produce a 422 with a readable error before any write.

`form_fields.conditional_logic` JSON column dropped. FormField model
`$fillable` and `$casts` no longer mention the column; factory default
no longer writes `null` to it. Snapshot fixtures in the dev seeder and
the legacy-forms migration command keep `conditional_logic` in their
snapshot JSON shape — that's the schema_snapshot contract, not the DB
column.

FormFieldController now maps InvalidConditionalLogicSpecException to
422 alongside FrozenSchemaException / CyclicDependencyException.

Rollback path: roll back WS-5c commits 1–3 together. Partial rollback
(drop-column reversed but backfill still applied) is not a supported
state — matching the WS-5a/b precedent on the family's full-rollback
contract.

Tests: 6 new (strict FormRequest rejection cases + JSON-column drop
assertion). Rollback step counts in WS-5a/b migration tests bumped +1
for the drop_conditional_logic_json_column migration. Baseline
1142 → 1148 green (3085 → 3099 assertions).

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
2026-04-25 00:03:21 +02:00

202 lines
7.5 KiB
PHP

<?php
declare(strict_types=1);
namespace Database\Factories\FormBuilder;
use App\Enums\FormBuilder\FormFieldBindingMode;
use App\Enums\FormBuilder\FormFieldConditionalLogicConditionOperator;
use App\Enums\FormBuilder\FormFieldConditionalLogicGroupOperator;
use App\Enums\FormBuilder\FormFieldDisplayWidth;
use App\Enums\FormBuilder\FormFieldType;
use App\Enums\FormBuilder\FormFieldValidationRuleType;
use App\Models\FormBuilder\FormField;
use App\Models\FormBuilder\FormFieldBinding;
use App\Models\FormBuilder\FormFieldConditionalLogicCondition;
use App\Models\FormBuilder\FormFieldConditionalLogicGroup;
use App\Models\FormBuilder\FormFieldValidationRule;
use App\Models\FormBuilder\FormSchema;
use Illuminate\Database\Eloquent\Factories\Factory;
use Illuminate\Support\Str;
/** @extends Factory<FormField> */
final class FormFieldFactory extends Factory
{
protected $model = FormField::class;
/** @return array<string, mixed> */
public function definition(): array
{
$fieldType = fake()->randomElement([
FormFieldType::TEXT,
FormFieldType::TEXTAREA,
FormFieldType::EMAIL,
FormFieldType::NUMBER,
FormFieldType::BOOLEAN,
FormFieldType::SELECT,
]);
$label = fake('nl_NL')->randomElement([
'Voornaam', 'Achternaam', 'E-mail', 'Telefoon', 'Opmerkingen',
'Shirtmaat', 'Allergieën', 'Motivatie', 'Geboortedatum',
]);
return [
'form_schema_id' => FormSchema::factory(),
'form_schema_section_id' => null,
'library_field_id' => null,
'field_type' => $fieldType->value,
'slug' => Str::slug($label).'-'.Str::lower(Str::random(4)),
'label' => $label,
'help_text' => fake()->boolean(30) ? fake('nl_NL')->sentence() : null,
'options' => $fieldType === FormFieldType::SELECT
? ['Optie A', 'Optie B', 'Optie C']
: null,
'is_required' => fake()->boolean(40),
'is_filterable' => false,
'is_portal_visible' => true,
'is_admin_only' => false,
'is_unique' => false,
'is_pii' => false,
'display_width' => FormFieldDisplayWidth::FULL,
'role_restrictions' => null,
'translations' => null,
'value_storage_hint' => $fieldType->recommendedValueStorageHint(),
'review_required' => false,
'sort_order' => 0,
];
}
public function ofType(FormFieldType $type): static
{
return $this->state(fn () => [
'field_type' => $type->value,
'value_storage_hint' => $type->recommendedValueStorageHint(),
]);
}
public function filterable(): static
{
return $this->state(fn () => ['is_filterable' => true]);
}
/**
* Attach an entity-binding row in `form_field_bindings` after the field
* is persisted. Use this instead of populating the legacy `binding` JSON
* column — which WS-5a will drop in commit 3.
*/
public function withEntityBinding(
string $entity,
string $attribute,
FormFieldBindingMode $mode = FormFieldBindingMode::EntityOwned,
?string $syncDirection = null,
): static {
return $this->afterCreating(function (FormField $field) use ($entity, $attribute, $mode, $syncDirection): void {
FormFieldBinding::factory()
->forField($field)
->state([
'target_entity' => $entity,
'target_attribute' => $attribute,
'mode' => $mode->value,
'sync_direction' => $mode === FormFieldBindingMode::Mirrored
? ($syncDirection ?? 'write_on_submit')
: null,
])
->create();
});
}
/**
* Attach a validation-rule row in `form_field_validation_rules` after
* the field is persisted. Replaces populating the legacy
* `validation_rules` JSON column — which WS-5b commit 5 drops.
*
* @param array<string, mixed> $parameters
*/
public function withValidationRule(FormFieldValidationRuleType $type, array $parameters): static
{
return $this->afterCreating(function (FormField $field) use ($type, $parameters): void {
FormFieldValidationRule::factory()
->forField($field)
->ofType($type, $parameters)
->create();
});
}
/**
* Build a conditional-logic tree for this field after persistence.
* `$tree` mirrors the canonical ARCH §8 JSON shape without the
* outer `show_when` wrapper — the root must be a group.
*
* Example:
*
* $factory->withConditionalLogic([
* 'operator' => 'all',
* 'children' => [
* ['field_slug' => 'gate', 'operator' => 'equals', 'value' => 'yes'],
* [
* 'operator' => 'any',
* 'children' => [
* ['field_slug' => 'region', 'operator' => 'equals', 'value' => 'NL'],
* ['field_slug' => 'region', 'operator' => 'equals', 'value' => 'BE'],
* ],
* ],
* ],
* ]);
*
* @param array<string, mixed> $tree
*/
public function withConditionalLogic(array $tree): static
{
return $this->afterCreating(function (FormField $field) use ($tree): void {
self::buildLogicTree($field->id, null, $tree, 0);
});
}
/**
* Recursive walker used only by `withConditionalLogic`. The service
* layer (WS-5c commit 2) owns the canonical write path; this helper
* stays minimal and keeps factories self-contained.
*
* @param array<string, mixed> $node
*/
private static function buildLogicTree(string $fieldId, ?string $parentId, array $node, int $sortOrder): void
{
if (isset($node['field_slug'])) {
/** @var string $slug */
$slug = $node['field_slug'];
$rawOperator = isset($node['operator']) && is_string($node['operator'])
? $node['operator']
: FormFieldConditionalLogicConditionOperator::Equals->value;
$operator = FormFieldConditionalLogicConditionOperator::from($rawOperator);
FormFieldConditionalLogicCondition::factory()->create([
'group_id' => $parentId,
'field_slug' => $slug,
'comparison_operator' => $operator->value,
'value' => $operator->isValueless() ? null : ($node['value'] ?? null),
'sort_order' => $sortOrder,
]);
return;
}
$rawOperator = isset($node['operator']) && is_string($node['operator'])
? $node['operator']
: FormFieldConditionalLogicGroupOperator::All->value;
$groupOperator = FormFieldConditionalLogicGroupOperator::from($rawOperator);
$group = FormFieldConditionalLogicGroup::factory()->create([
'form_field_id' => $fieldId,
'parent_group_id' => $parentId,
'operator' => $groupOperator->value,
'sort_order' => $sortOrder,
]);
/** @var array<int, array<string, mixed>> $children */
$children = $node['children'] ?? [];
foreach ($children as $childSortOrder => $child) {
self::buildLogicTree($fieldId, $group->id, $child, $childSortOrder);
}
}
}