bert.hausmans
864cc558e2
Per RFC-WS-PRIMEVUE-PLAN-2-5 §4 AD-2.5-W1 and AD-2.5-B1, §5.4 Fix 4. Changes: - WorkspaceSwitcher: sub field removed from template, WorkspaceDisplay type, and buildDisplay derivation. Stories did not carry sub args (auto-derived from seeded org.role); no WithSub story existed. New regression spec (WorkspaceSwitcher.spec.ts) locks the no-sub render. - SidebarNav: now consumes APP_NAVIGATION from src/config/navigation.ts as the single source of truth (shared with breadcrumb derivation in useNavBreadcrumb). The groups: V2NavGroup[] prop is removed; render walks top-level NavItems (branch nodes render label-heading + children; leaf nodes render as rows; items without routeName render as non-clickable dormant placeholders). Previous nav data source: groups prop fed by useV2Nav(orgNavItems) in OrganizerLayoutV2. - APP_NAVIGATION expanded with 7 entries to preserve visual sidebar continuity (Evenementen at top-level + Beheer branch with 5 children). All new entries use routeName: undefined until the corresponding v2 page lands (TODOs noted per entry); only Dashboard maps to v2-dashboard. - AppSidebar: groups prop removed; passes only :collapsed to SidebarNav. - OrganizerLayoutV2: useV2Nav(orgNavItems) plumbing retired; the layout now renders <AppSidebar /> with no nav-data wiring. - Tests: AppSidebar.spec drops the "passes groups prop to SidebarNav" assertion; OrganizerLayoutV2.spec drops the "forwards orgNavItems" assertion. New WorkspaceSwitcher no-sub regression spec (+2 tests). - Storybook: SidebarNav.stories and AppSidebar.stories updated to no longer thread navFixture/groups; WithActiveItem pushes v2-dashboard. Position of WorkspaceSwitcher (Fix 3), workspace dropdown panel (Fix 5), and AppBreadcrumb wiring (Fix 2) remain unchanged in P4 — both lands in P5. The legacy useBreadcrumb composable also remains untouched until P5 (atomic with AppTopbar refactor). Orphans flagged for follow-up cleanup (intentionally not deleted in P4): useV2Nav composable + spec, V2NavGroup/V2NavItem types, sidebarNavActive helper + spec, navFixture in stories/v2/_helpers.ts. Suite delta: 575 → 575 (+2 WorkspaceSwitcher no-sub spec, -1 AppSidebar groups-prop assertion, -1 OrganizerLayoutV2 groups-forward assertion). vue-tsc clean. Scoped ESLint clean (0 errors). Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
71 lines
2.4 KiB
TypeScript
71 lines
2.4 KiB
TypeScript
import { describe, expect, it } from 'vitest'
|
|
import { mount } from '@vue/test-utils'
|
|
import { createPinia } from 'pinia'
|
|
import { createMemoryHistory, createRouter } from 'vue-router'
|
|
import { defineComponent } from 'vue'
|
|
import OrganizerLayoutV2 from '@/layouts/OrganizerLayoutV2.vue'
|
|
import AppShellV2 from '@/layouts/components/AppShellV2.vue'
|
|
|
|
// Stub the 3 leaf shell components: this test verifies COMPOSITION
|
|
// (right component in right slot), not their internals (those have
|
|
// their own unit tests). Stubs keep jsdom free of PrimeVue teleport/
|
|
// overlay/breakpoint machinery.
|
|
//
|
|
// Plan 2.5 P4 (AD-2.5-B1): AppSidebar no longer takes a `groups` prop
|
|
// — SidebarNav reads APP_NAVIGATION from `@/config/navigation` directly.
|
|
const AppSidebarStub = defineComponent({
|
|
name: 'AppSidebarStub',
|
|
template: '<aside data-testid="sidebar-stub" />',
|
|
})
|
|
|
|
const AppTopbarStub = defineComponent({
|
|
name: 'AppTopbarStub',
|
|
template: '<header data-testid="topbar-stub" />',
|
|
})
|
|
|
|
const RightDrawerStub = defineComponent({
|
|
name: 'RightDrawerStub',
|
|
template: '<aside data-testid="drawer-stub" />',
|
|
})
|
|
|
|
const router = createRouter({
|
|
history: createMemoryHistory(),
|
|
routes: [{ path: '/', name: 'home', component: defineComponent({ template: '<div data-testid="page" />' }) }],
|
|
})
|
|
|
|
async function mountLayout() {
|
|
router.push('/')
|
|
await router.isReady()
|
|
|
|
return mount(OrganizerLayoutV2, {
|
|
global: {
|
|
plugins: [createPinia(), router],
|
|
stubs: {
|
|
AppSidebar: AppSidebarStub,
|
|
AppTopbar: AppTopbarStub,
|
|
RightDrawer: RightDrawerStub,
|
|
},
|
|
},
|
|
})
|
|
}
|
|
|
|
describe('OrganizerLayoutV2 (wired shell)', () => {
|
|
it('composes AppShellV2 with the real shell components in each slot', async () => {
|
|
const wrapper = await mountLayout()
|
|
|
|
expect(wrapper.findComponent(AppShellV2).exists()).toBe(true)
|
|
expect(wrapper.find('[data-testid="appshell-v2"]').exists()).toBe(true)
|
|
expect(wrapper.find('[data-testid="sidebar-stub"]').exists()).toBe(true)
|
|
expect(wrapper.find('[data-testid="topbar-stub"]').exists()).toBe(true)
|
|
expect(wrapper.find('[data-testid="drawer-stub"]').exists()).toBe(true)
|
|
expect(wrapper.find('[data-testid="page"]').exists()).toBe(true)
|
|
})
|
|
|
|
it('no longer renders the Plan-1 skeleton placeholders', async () => {
|
|
const wrapper = await mountLayout()
|
|
|
|
expect(wrapper.text()).not.toContain('skeleton')
|
|
expect(wrapper.text()).not.toContain('Crewli v2')
|
|
})
|
|
})
|