Files
crewli/api/app/Observers/FormBuilder/FormFieldChildTablesCascadeObserver.php
bert.hausmans 11588623c5 feat(form-field): add form_field_options table, service, scope, cascade
Fourth and final WS-5 sibling. Polymorphic morph-owned table for the
RADIO / SELECT / MULTISELECT / CHECKBOX_LIST option rows, shared
between form_fields and form_field_library via the owner_type
discriminator. Matches the WS-5a (bindings) / WS-5b (validation_rules
+ configs) pattern one-for-one: dedicated service as single writer,
UNION-over-two-owner-chains scope, shared cascade observer.

Row shape:
  - value         canonical storage value (string ≤255, UNIQUE per owner)
  - label         default-locale display label (string ≤255)
  - sort_order    int unsigned
  - translations  JSON { "<locale>": "<translated label>" }

The UNIQUE(owner_type, owner_id, value) index ffo_owner_value_unique
is the seed-bug guard — duplicate values per field have no semantic
meaning and must fail at both the service layer (assertSpecsValid)
and the DB level.

Activity log: field.options_replaced emits on FormField subject only,
per the §6.7 WS-5a / §17.4.2 WS-5b convention that library-level
changes are silent in activity log.

No production reads yet. The form_fields.options and
form_field_library.options JSON columns remain the active source of
truth until the commit-3 reader switch — accessing $field->options
still resolves through the JSON cast in commit 1, so model tests
exercise the new morphMany via $field->options() (explicit relation
call). Both FormField and FormFieldLibrary now carry an `options`
morphMany alongside `bindings`, `validation_rules`, and `configs`.

Cascade: FormFieldChildTablesCascadeObserver gains form_field_options
as the fourth child cleaned on owner delete (both FormField soft/
force-delete and FormFieldLibrary delete).

Migration step-count tests in WS-5a/b/c bumped by 1 to account for
the new create_form_field_options_table on the migration stack.

Base scope-class extraction across the four siblings — deliberately
deferred to a follow-up work package per addendum §17.4.3 / §17.5.3.
Now that all four concrete implementations exist, the "what actually
varies" question can be answered empirically.

Tests: 1158 → 1182 green (+24 tests / +42 assertions).

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
2026-04-25 02:07:53 +02:00

80 lines
3.1 KiB
PHP

<?php
declare(strict_types=1);
namespace App\Observers\FormBuilder;
use App\Models\FormBuilder\FormField;
use App\Models\FormBuilder\FormFieldLibrary;
use Illuminate\Support\Facades\DB;
use Illuminate\Support\Facades\Schema;
/**
* Cascades physical deletion of child rows in the relational tables
* that hang off `form_fields` / `form_field_library`:
*
* - `form_field_bindings` (WS-5a)
* - `form_field_validation_rules` (WS-5b)
* - `form_field_configs` (WS-5b commit 5)
* - `form_field_conditional_logic_groups` (WS-5c — FormField only,
* per addendum Q3: library
* is explicitly out of
* scope for conditional_logic)
* - `form_field_options` (WS-5d — both owner types)
*
* The conditions sibling table cascades automatically via the `group_id`
* FK on the groups table — no direct entry here.
*
* Children represent current state (not historical intent) — physically
* deleted even when the owner is only soft-deleted, per addendum Q3: no
* child table in this family carries a soft-delete semantic of its own.
*
* Renamed from `FormFieldBindingsCascadeObserver` during WS-5b commit 1.
* The `Schema::hasTable` guard keeps the observer safe when this code
* runs against a database where a later migration has not yet been
* applied (e.g. during the migration step itself).
*/
final class FormFieldChildTablesCascadeObserver
{
public function deleted(FormField|FormFieldLibrary $owner): void
{
$ownerType = $owner instanceof FormField ? 'form_field' : 'form_field_library';
$ownerId = $owner->getKey();
DB::table('form_field_bindings')
->where('owner_type', $ownerType)
->where('owner_id', $ownerId)
->delete();
if (Schema::hasTable('form_field_validation_rules')) {
DB::table('form_field_validation_rules')
->where('owner_type', $ownerType)
->where('owner_id', $ownerId)
->delete();
}
if (Schema::hasTable('form_field_configs')) {
DB::table('form_field_configs')
->where('owner_type', $ownerType)
->where('owner_id', $ownerId)
->delete();
}
if (Schema::hasTable('form_field_options')) {
DB::table('form_field_options')
->where('owner_type', $ownerType)
->where('owner_id', $ownerId)
->delete();
}
// Conditional-logic groups only apply to FormField (addendum Q3:
// library mirror is out of scope). Condition rows cascade via
// the group_id FK on the conditions table.
if ($owner instanceof FormField && Schema::hasTable('form_field_conditional_logic_groups')) {
DB::table('form_field_conditional_logic_groups')
->where('form_field_id', $ownerId)
->delete();
}
}
}