2 Commits

Author	SHA1	Message	Date
bert.hausmans	996dedc11d	test(timetable): Phase C — 57 new tests covering session 2 surface ... Nine test files under tests/Feature/Artist/ exercising: ArtistEngagementStateMachineTest 8 tests — terminal blocks, conditional gates (Option/Contracted), full happy path, cancel cascade LaneCascadeServiceTest 5 tests — simple move, cascade-bump, version mismatch, park, unpark BumaVatCalculationTest 6 tests — D26 formula coverage: Organisation/BookingAgency/NotApplicable, VAT off, breakdown sum, zero fee DemoteExpiredOptionsTest 4 tests — expired demote, future untouched, non-Option untouched, run twice → single option_expired entry IdempotencyKey60sRedisTest 4 tests — missing header 400, first cache, replay header, failed not cached ArtistControllerTest 8 tests — index/create/destroy + cross- tenant + duplicate detection + restore StageControllerTest 7 tests — create + uniqueness, destroy cascade-park, reorder permutation, replaceDays orphan 409 + force_orphan ArtistEngagementControllerTest 5 tests — index/create/update/destroy + 422 on invalid status transition TimetableMoveControllerTest 3 tests — happy path with idempotency header, missing header → 400, version mismatch → 409 ArtistPolicyTest 6 tests — role checks, cross-tenant denial, super_admin bypass, D27 active- engagement gate ActivityLogShapeTest 4 tests — performance.moved cascade props, status_changed vs cancelled, stage.day_added subject + props, stage.reordered on Event subject Bug fixes surfaced by Phase C: Schema reality: events table uses `start_date`/`end_date` (date), not `start_at`/`end_at`. Updated WithinEventBounds rule and the two stage_day resolvers (LaneCascadeService + MoveTimetablePerformanceRequest) to query the actual columns. ArtistResource.engagements_summary upcoming filter likewise. performances table has no organisation_id column (FK-chain via engagement_id). Removed the org-id filter from the Rule::exists in MoveTimetablePerformanceRequest; cross-tenant is caught by the policy in TimetableMoveController. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>	2026-05-08 21:07:29 +02:00
bert.hausmans	9e94ab78d8	feat(timetable): API resources + LaneResolver helper ... Six resources under app/Http/Resources/Api/V1/Artist/ matching FormSubmissionResource conventions (final class, @mixin model, optional()->toIso8601String, whenLoaded relationships). GenreResource — id, name, color, sort_order, is_active ArtistResource — master + lifetime/upcoming engagement counts computed lazily from the engagements relation ArtistContactResource — paired with ArtistResource.contacts ArtistEngagementResource — full deal block with the RFC D26 Buma/VAT formulas computed live in `computed.*`: buma_amount = fee × buma_pct/100 IFF Organisation handles BUMA vat_grondslag = fee + (buma when Organisation) vat_amount = vat_grondslag × vat_pct/100 when vat_applicable total_cost = fee + buma + vat + Σ breakdown Frontend (Session 5) ports the same formula. StageResource — adds stage_days as a flat array of event_ids (not nested Event resources, to keep payload light) PerformanceResource — `lane` (raw, persisted), `lane_resolved` (computed per D19), `warnings` (overlap + B2B at minimum; capacity-warn refined later) LaneResolver under app/Services/Artist/ is the pure-logic helper that PerformanceResource calls. Greedy lowest-non-conflicting lane assignment over the (stage_id, event_id) cohort sorted by start_at then by raw lane (so cascade-bumped rows stay where they were visually). Frontend port lands in Session 4. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>	2026-05-08 20:53:43 +02:00