0e986f42cb
refactor(form-builder): align binding registry with model column reality (WS-6)
...
Three renames (registry → matches actual Eloquent model column):
- person.phone_number → person.phone
- company.email → company.contact_email
- company.phone_number → company.contact_phone
Six removals (registry attribute does not exist as model column,
intentionally deferred):
- person.dietary_preferences (custom_fields JSON path; BACKLOG
FORM-BINDING-JSON-PATH)
- artist.email (Artist model absent + column absent)
- artist.stage_name (column absent)
- artist.tech_rider (column absent)
- artist.hospitality_rider (column absent)
- artist entity removed entirely (no v1 bindable attributes)
Decisions documented inline in binding_targets.php and tracked
via BACKLOG entries (Task 4 of this session).
Tests touched:
- BindingTypeRegistryTest:
test_resolve_person_dietary_preferences_returns_collection_array →
renamed test_resolve_collection_attribute_returns_collection_array,
uses Config::set to inject a synthetic 'test_entity.tags' collection
target. v1 has no production collection targets (BACKLOG
FORM-BINDING-JSON-PATH).
test_validate_append_strategy_accepts_collection_target — same pattern.
test_entities_returns_known_entities — drop 'artist' from expected list.
test_attributes_for_person_includes_email_and_dietary_preferences →
renamed _includes_email_and_phone (the renamed attribute).
- AppendStrategyRequiresCollectionTargetTest:
test_passes_with_collection_target — same Config::set synthetic-
target pattern.
- MaxOneIdentityKeyPerTargetEntityTest:
test_passes_with_one_identity_key_each_on_different_entities —
'company.email' → 'company.contact_email' to match registry rename.
Refs: WS-6 sessie 3a binding-target drift audit
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com >
2026-04-29 00:14:13 +02:00
0dd991c688
feat(form-builder): add BindingTypeRegistry as single source of truth for target shapes (WS-6)
...
Config-driven mapping from (target_entity, target_attribute) to storage
shape (scalar/collection/relation), PHP type, and identity-key
eligibility. Replaces any name-suffix matching (e.g. _tags, _skills) —
those are convention-not-contract and reject by design.
Used by publish guards now and (in session 2) by FormBindingApplicator.
Refs: RFC-WS-6.md §4 (V1)
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com >
2026-04-25 22:41:25 +02:00
