2 Commits

Author	SHA1	Message	Date
bert.hausmans	bc7d3fcbee	fix(timetable): single activity entry per cascade-move per RFC §8 ... LaneCascadeService::move() now calls disableLogging() before every save inside the transaction (locked performance + cascade-bumped peers + park-path). The two explicit activity('performance') ->event('moved'|'parked') entries with cascade_count + cascaded_ids properties are the only audit records per move, matching RFC §8's "single parent entry summarising the cascade" requirement. Park path additionally writes an explicit 'performance.parked' entry per RFC §8 vocabulary instead of falling back to a generic 'updated' auto-log entry. Two new tests verify: - cascade move with N peers produces exactly 1 activity entry on the moved subject and 0 on each cascade-bumped peer - park writes exactly 1 'parked' entry PerformanceObserver::saving (version bump) is unaffected: disableLogging() suppresses only the activity log trait, not Eloquent model events. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>	2026-05-08 21:29:49 +02:00
bert.hausmans	996dedc11d	test(timetable): Phase C — 57 new tests covering session 2 surface ... Nine test files under tests/Feature/Artist/ exercising: ArtistEngagementStateMachineTest 8 tests — terminal blocks, conditional gates (Option/Contracted), full happy path, cancel cascade LaneCascadeServiceTest 5 tests — simple move, cascade-bump, version mismatch, park, unpark BumaVatCalculationTest 6 tests — D26 formula coverage: Organisation/BookingAgency/NotApplicable, VAT off, breakdown sum, zero fee DemoteExpiredOptionsTest 4 tests — expired demote, future untouched, non-Option untouched, run twice → single option_expired entry IdempotencyKey60sRedisTest 4 tests — missing header 400, first cache, replay header, failed not cached ArtistControllerTest 8 tests — index/create/destroy + cross- tenant + duplicate detection + restore StageControllerTest 7 tests — create + uniqueness, destroy cascade-park, reorder permutation, replaceDays orphan 409 + force_orphan ArtistEngagementControllerTest 5 tests — index/create/update/destroy + 422 on invalid status transition TimetableMoveControllerTest 3 tests — happy path with idempotency header, missing header → 400, version mismatch → 409 ArtistPolicyTest 6 tests — role checks, cross-tenant denial, super_admin bypass, D27 active- engagement gate ActivityLogShapeTest 4 tests — performance.moved cascade props, status_changed vs cancelled, stage.day_added subject + props, stage.reordered on Event subject Bug fixes surfaced by Phase C: Schema reality: events table uses `start_date`/`end_date` (date), not `start_at`/`end_at`. Updated WithinEventBounds rule and the two stage_day resolvers (LaneCascadeService + MoveTimetablePerformanceRequest) to query the actual columns. ArtistResource.engagements_summary upcoming filter likewise. performances table has no organisation_id column (FK-chain via engagement_id). Removed the org-id filter from the Rule::exists in MoveTimetablePerformanceRequest; cross-tenant is caught by the policy in TimetableMoveController. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>	2026-05-08 21:07:29 +02:00