feat(form-builder): exception hierarchy for binding-apply pipeline
Per RFC-WS-6 §Q3 v1.3 addition 2 (binding hierarchy) + §Q2 (invariant exception).
- Refactored FormBindingApplicatorException from concrete final to abstract
base. Constructor (submissionId, message, previous?) preserves submissionId
as a public readonly property so D2's outer-transaction handler can write
it structurally to form_submission_action_failures.context JSON without
regex-parsing the message. Replaced public-readonly reasonCode property
with abstract reasonCode(): string method.
- Added 3 reason-coded subclasses:
- FormBindingSchemaConfigException -> 'schema_config_error' (422)
- FormBindingInfraException -> 'temporary_error' (503, NOT final because
Timeout extends it)
- FormBindingDataIntegrityException -> 'data_integrity_error' (422)
- Added FormBindingApplicatorTimeoutException extending FormBindingInfraException
(timeout = temporary infra issue from user perspective; reasonCode inherited).
- Added IdentityMatchInvariantViolation as a sibling DomainException — NOT
in the FormBindingApplicatorException hierarchy because it's thrown
outside the binding-applicator pipeline.
- Migrated 3 existing throw sites in FormBindingApplicator::apply():
- 'no_transaction' -> FormBindingInfraException (developer-error wants
infra-triage workflow: GlitchTip alert + retry-after)
- 'no_schema' -> FormBindingSchemaConfigException
- 'unknown_purpose' -> FormBindingSchemaConfigException
- Updated FormBindingApplicatorIntegrationTest::test_no_transaction_guard_present
to assert against the new throw shape (FormBindingInfraException + new
message string) while preserving the test's intent (guard exists in source).
Wiring (deadline wrapper, classifier integration in listener catch +
retry-service recordFailure) lands in D2.
Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
This commit is contained in:
@@ -0,0 +1,28 @@
|
||||
<?php
|
||||
|
||||
declare(strict_types=1);
|
||||
|
||||
namespace App\Exceptions\FormBuilder;
|
||||
|
||||
/**
|
||||
* Data shape violation during binding apply.
|
||||
*
|
||||
* Examples: type mismatch between form_value and target attribute;
|
||||
* foreign-key violation when the target references a soft-deleted entity;
|
||||
* attempt to write to a column that has a unique constraint already
|
||||
* violated by another row outside this submission.
|
||||
*
|
||||
* User-perceptible the same as schema_config (organiser fix needed); admin
|
||||
* sees the difference via the exception class on the action-failures row.
|
||||
*
|
||||
* Maps to HTTP 422, failure_response_code='data_integrity_error'.
|
||||
*
|
||||
* Per RFC-WS-6 §Q3 v1.3 addition 2.
|
||||
*/
|
||||
final class FormBindingDataIntegrityException extends FormBindingApplicatorException
|
||||
{
|
||||
public function reasonCode(): string
|
||||
{
|
||||
return 'data_integrity_error';
|
||||
}
|
||||
}
|
||||
Reference in New Issue
Block a user