bert.hausmans/crewli
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

fix: allow registration_banner_url and registration_logo_url on event update

Browse Source 
Missing from UpdateEventRequest rules, so the fields were stripped from
validated() and the uploaded URLs never persisted — the preview showed
briefly in the upload component but disappeared on reload because the
event record still had null.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This commit is contained in:
bert.hausmans
2026-04-16 20:42:25 +02:00
parent b647d2827a
commit ef7c482b4a
2 changed files with 34 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
api/app/Http/Requests/Api/V1/UpdateEventRequest.php
View File

@@ -29,6 +29,8 @@ final class UpdateEventRequest extends FormRequest
'event_type_label' => ['nullable', 'string', 'max:50'], 'event_type_label' => ['nullable', 'string', 'max:50'],
'sub_event_label' => ['nullable', 'string', 'max:50'], 'sub_event_label' => ['nullable', 'string', 'max:50'],
'registration_welcome_text' => ['nullable', 'string', 'max:1000'], 'registration_welcome_text' => ['nullable', 'string', 'max:1000'],
'registration_banner_url' => ['nullable', 'string', 'max:2048'],
'registration_logo_url' => ['nullable', 'string', 'max:2048'],
'registration_show_section_preferences' => ['nullable', 'boolean'], 'registration_show_section_preferences' => ['nullable', 'boolean'],
'registration_show_availability' => ['nullable', 'boolean'], 'registration_show_availability' => ['nullable', 'boolean'],
]; ];

32
api/tests/Feature/Event/EventTest.php
View File

@@ -223,6 +223,38 @@ class EventTest extends TestCase
]); ]);
} }
public function test_org_admin_can_update_registration_banner_and_logo_urls(): void
{
$event = Event::factory()->create([
'organisation_id' => $this->organisation->id,
'registration_banner_url' => null,
'registration_logo_url' => null,
]);
Sanctum::actingAs($this->orgAdmin);
$bannerUrl = 'http://localhost:8000/storage/uploads/banner/abc/banner.png';
$logoUrl = 'http://localhost:8000/storage/uploads/logo/abc/logo.png';
$this->putJson("/api/v1/organisations/{$this->organisation->id}/events/{$event->id}", [
'registration_banner_url' => $bannerUrl,
])->assertOk()->assertJsonPath('data.registration_banner_url', $bannerUrl);
$this->putJson("/api/v1/organisations/{$this->organisation->id}/events/{$event->id}", [
'registration_logo_url' => $logoUrl,
])->assertOk()->assertJsonPath('data.registration_logo_url', $logoUrl);
$this->assertDatabaseHas('events', [
'id' => $event->id,
'registration_banner_url' => $bannerUrl,
'registration_logo_url' => $logoUrl,
]);
$this->putJson("/api/v1/organisations/{$this->organisation->id}/events/{$event->id}", [
'registration_banner_url' => null,
])->assertOk()->assertJsonPath('data.registration_banner_url', null);
}
public function test_event_manager_can_update_event(): void public function test_event_manager_can_update_event(): void
{ {
$event = Event::factory()->create(['organisation_id' => $this->organisation->id]); $event = Event::factory()->create(['organisation_id' => $this->organisation->id]);