feat: complete person identity matching system with fuzzy detection, revert, and manual link
Implements the full identity matching engine: email matching (HIGH confidence), fuzzy name matching with Levenshtein distance (MEDIUM confidence, upgradable to HIGH with DOB tiebreaker), manual link/unlink, revert confirmed matches, and automatic detection via PersonObserver. Includes 33 comprehensive tests, frontend integration with confirm/dismiss/unlink UI, and match indicators in the persons list. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This commit is contained in:
@@ -36,7 +36,7 @@ final class PersonController extends Controller
|
||||
$this->verifyEventBelongsToOrganisation($organisation, $event);
|
||||
Gate::authorize('viewAny', [Person::class, $event]);
|
||||
|
||||
$query = $event->persons()->with(['crowdType', 'pendingIdentityMatch.matchedUser']);
|
||||
$query = $event->persons()->with(['crowdType', 'pendingIdentityMatch.matchedUser', 'user']);
|
||||
|
||||
if ($request->filled('crowd_type_id')) {
|
||||
$query->where('crowd_type_id', $request->input('crowd_type_id'));
|
||||
@@ -77,7 +77,7 @@ final class PersonController extends Controller
|
||||
$this->verifyEventBelongsToOrganisation($organisation, $event);
|
||||
Gate::authorize('view', [$person, $event]);
|
||||
|
||||
$person->load(['crowdType', 'company', 'user']);
|
||||
$person->load(['crowdType', 'company', 'user', 'pendingIdentityMatch.matchedUser']);
|
||||
|
||||
return $this->success(new PersonResource($person));
|
||||
}
|
||||
@@ -89,7 +89,7 @@ final class PersonController extends Controller
|
||||
|
||||
$person = $event->persons()->create($request->validated());
|
||||
|
||||
$this->identityService->detectMatchForPerson($person);
|
||||
// Identity match detection is handled automatically by PersonObserver
|
||||
|
||||
return $this->created(new PersonResource($person->fresh()->load('crowdType')));
|
||||
}
|
||||
|
||||
@@ -7,14 +7,18 @@ namespace App\Http\Controllers\Api\V1;
|
||||
use App\Http\Controllers\Controller;
|
||||
use App\Http\Requests\Api\V1\BulkConfirmIdentityMatchesRequest;
|
||||
use App\Http\Resources\Api\V1\PersonIdentityMatchResource;
|
||||
use App\Http\Resources\Api\V1\PersonResource;
|
||||
use App\Models\Event;
|
||||
use App\Models\Organisation;
|
||||
use App\Models\Person;
|
||||
use App\Models\PersonIdentityMatch;
|
||||
use App\Models\User;
|
||||
use App\Services\PersonIdentityService;
|
||||
use Illuminate\Http\JsonResponse;
|
||||
use Illuminate\Http\Request;
|
||||
use Illuminate\Http\Resources\Json\AnonymousResourceCollection;
|
||||
use Illuminate\Support\Facades\Gate;
|
||||
use Illuminate\Validation\ValidationException;
|
||||
|
||||
final class PersonIdentityMatchController extends Controller
|
||||
{
|
||||
@@ -63,7 +67,7 @@ final class PersonIdentityMatchController extends Controller
|
||||
return $this->error($e->getMessage(), 422);
|
||||
}
|
||||
|
||||
$personIdentityMatch->refresh()->load(['person.crowdType', 'person.event', 'matchedUser', 'resolvedBy']);
|
||||
$personIdentityMatch->refresh()->load(['person.crowdType', 'person.event', 'matchedUser', 'confirmedBy', 'resolvedBy']);
|
||||
|
||||
return $this->success(new PersonIdentityMatchResource($personIdentityMatch));
|
||||
}
|
||||
@@ -88,6 +92,26 @@ final class PersonIdentityMatchController extends Controller
|
||||
return $this->success(new PersonIdentityMatchResource($personIdentityMatch));
|
||||
}
|
||||
|
||||
public function revert(Request $request, Organisation $organisation, PersonIdentityMatch $personIdentityMatch): JsonResponse
|
||||
{
|
||||
// Verify match belongs to this organisation
|
||||
if ($personIdentityMatch->person->event->organisation_id !== $organisation->id) {
|
||||
return $this->notFound('Match not found.');
|
||||
}
|
||||
|
||||
Gate::authorize('confirm', $personIdentityMatch);
|
||||
|
||||
try {
|
||||
$this->identityService->revertMatch($personIdentityMatch, $request->user());
|
||||
} catch (\DomainException $e) {
|
||||
return $this->error($e->getMessage(), 422);
|
||||
}
|
||||
|
||||
$personIdentityMatch->refresh()->load(['person.crowdType', 'person.event', 'matchedUser', 'revertedBy']);
|
||||
|
||||
return $this->success(new PersonIdentityMatchResource($personIdentityMatch));
|
||||
}
|
||||
|
||||
public function bulkConfirm(BulkConfirmIdentityMatchesRequest $request, Organisation $organisation): JsonResponse
|
||||
{
|
||||
Gate::authorize('bulkConfirm', [PersonIdentityMatch::class, $organisation]);
|
||||
@@ -107,12 +131,14 @@ final class PersonIdentityMatchController extends Controller
|
||||
|
||||
if ($match === null) {
|
||||
$errors[] = ['match_id' => $matchId, 'error' => 'Match not found.'];
|
||||
|
||||
continue;
|
||||
}
|
||||
|
||||
$response = Gate::inspect('update', [$match->person, $match->person->event]);
|
||||
if ($response->denied()) {
|
||||
$errors[] = ['match_id' => $matchId, 'error' => 'Unauthorized.'];
|
||||
|
||||
continue;
|
||||
}
|
||||
|
||||
@@ -129,4 +155,35 @@ final class PersonIdentityMatchController extends Controller
|
||||
'errors' => $errors,
|
||||
]);
|
||||
}
|
||||
|
||||
public function manualLink(Request $request, Organisation $organisation, Event $event, Person $person): JsonResponse
|
||||
{
|
||||
Gate::authorize('update', [$person, $event]);
|
||||
|
||||
$validated = $request->validate([
|
||||
'user_id' => ['required', 'string', 'exists:users,id'],
|
||||
]);
|
||||
|
||||
try {
|
||||
$user = User::findOrFail($validated['user_id']);
|
||||
$match = $this->identityService->manualLink($person, $user, $request->user());
|
||||
} catch (ValidationException $e) {
|
||||
return $this->error($e->getMessage(), 422);
|
||||
}
|
||||
|
||||
return $this->success(new PersonIdentityMatchResource($match->load(['person.crowdType', 'matchedUser'])));
|
||||
}
|
||||
|
||||
public function unlink(Request $request, Organisation $organisation, Event $event, Person $person): JsonResponse
|
||||
{
|
||||
Gate::authorize('update', [$person, $event]);
|
||||
|
||||
try {
|
||||
$person = $this->identityService->unlinkDirect($person, $request->user());
|
||||
} catch (ValidationException $e) {
|
||||
return $this->error($e->getMessage(), 422);
|
||||
}
|
||||
|
||||
return $this->success(new PersonResource($person->load(['crowdType', 'user'])));
|
||||
}
|
||||
}
|
||||
|
||||
Reference in New Issue
Block a user