test(timetable): Phase C — artist domain coverage + cross-cutting fixes
New Phase C test files: - tests/Unit/Models/Artist/ArtistDomainModelsTest.php — relationships, casts, soft-delete trait presence, slug uniqueness within/across organisations, isParked() helper, AdvanceSection's primary scope, PURPOSE_SUBJECT_FQCN['artist'] resolves to instantiable class. - tests/Feature/Artist/ArtistEngagementObserverTest.php — auto-fill organisation_id from artist, cross-tenant guard throws, soft-delete cascades to performances + hard-deletes advance_sections. - tests/Feature/Artist/PerformanceObserverTest.php — version starts at 0, increments by 1 per UPDATE, no bump on no-op save. - tests/Feature/Artist/ArtistDomainScopeLeakageTest.php — 5 scoped models (Artist/Genre/Engagement direct + Stage/Performance FK-chain) isolate cross-org queries. - tests/Feature/Artist/ArtistTimetableDevSeederTest.php — fixture-count smoke (4 stages, 12 stage_days, 6 artists, 12 engagements, 13 performances incl. 1 parked). Cross-cutting fixes that Phase C surfaced: - AppServiceProvider: morph-map block 2 extended with the 8 new artist-domain models (artist_engagement, artist_contact, genre, stage, stage_day, performance, advance_section, advance_submission). Block 1 'artist' alias was already wired via PurposeRegistry. - 5 form-builder backfill tests bumped --step rollback counts by +10 to account for the 10 new May 8 migrations sitting at HEAD between the test's calibration point and current head. - phpstan-baseline.neon regenerated (1631 entries) — all errors are same patterns existing baselined code already exhibits (Factory generic typing, Model property docblock gaps). Tracked systematically under TECH-LARASTAN-* in BACKLOG. Tests: 1646 passing (was 1624 pre-Session-1 → +22 net, no losses). Larastan: 0 errors over baseline. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This commit is contained in:
@@ -323,6 +323,17 @@ class AppServiceProvider extends ServiceProvider
|
||||
'user_organisation_tag' => UserOrganisationTag::class,
|
||||
'volunteer_availability' => VolunteerAvailability::class,
|
||||
|
||||
// RFC-TIMETABLE v0.2 artist-domain models (Session 1). Artist
|
||||
// itself is in Block 1 via PurposeRegistry.
|
||||
'artist_engagement' => \App\Models\ArtistEngagement::class,
|
||||
'artist_contact' => \App\Models\ArtistContact::class,
|
||||
'genre' => \App\Models\Genre::class,
|
||||
'stage' => \App\Models\Stage::class,
|
||||
'stage_day' => \App\Models\StageDay::class,
|
||||
'performance' => \App\Models\Performance::class,
|
||||
'advance_section' => \App\Models\AdvanceSection::class,
|
||||
'advance_submission' => \App\Models\AdvanceSubmission::class,
|
||||
|
||||
// Form-builder models used as activity-log subjects and (S2+)
|
||||
// polymorphic webhook payload subjects.
|
||||
'form_schema' => FormSchema::class,
|
||||
|
||||
Reference in New Issue
Block a user