bert.hausmans/crewli
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

chore(apps/app): drop unnecessary async on synchronous error handlers

Browse Source 
Both interceptor error handlers in lib/axios.ts were declared
`async` but contain zero `await` calls — the request handler
just rethrows, and the response handler walks a synchronous
status-code branching tree before rethrowing. axios accepts both
sync and async handler signatures, so dropping the keyword is
mechanical and behavior-neutral.

Co-Authored-By: Claude <noreply@anthropic.com>
This commit is contained in:
bert.hausmans
2026-05-04 22:40:12 +02:00
parent 853939e8b8
commit de07ccac8e
1 changed files with 2 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
apps/app/src/lib/axios.ts
View File

@@ -41,7 +41,7 @@ export function registerInterceptors(client: AxiosInstance, deps: AxiosBindingsD
return config return config
}, },
async error => { throw error }, error => { throw error },
) )
client.interceptors.response.use( client.interceptors.response.use(
@@ -51,7 +51,7 @@ export function registerInterceptors(client: AxiosInstance, deps: AxiosBindingsD
return response return response
}, },
async error => { error => {
if (import.meta.env.DEV) if (import.meta.env.DEV)
console.error(`❌ ${error.response?.status} ${error.config?.url}`, error.response?.data) console.error(`❌ ${error.response?.status} ${error.config?.url}`, error.response?.data)