feat: split name into first_name + last_name across users, persons, and companies
Cross-cutting migration affecting the entire stack: - Database: 3 migrations splitting name columns with data migration - Models: first_name/last_name on User, Person; contact_first_name/contact_last_name on Company; backward-compatible name accessors - API: all resources return first_name, last_name, full_name; assignablePersons endpoint updated - Requests: validation rules updated for all person/user/company forms - Services: VolunteerRegistrationService, ShiftAssignmentService, InvitationService updated - Frontend: TypeScript types, Zod schemas, all forms split into Voornaam/Achternaam fields - Display: all person/user name references use full_name; initials use first_name[0]+last_name[0] - Tests: all 371 tests passing - Docs: SCHEMA.md and API.md updated Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This commit is contained in:
@@ -22,7 +22,8 @@ final class AcceptInvitationRequest extends FormRequest
|
||||
$userExists = $invitation && User::where('email', $invitation->email)->exists();
|
||||
|
||||
return [
|
||||
'name' => [$userExists ? 'nullable' : 'required', 'string', 'max:255'],
|
||||
'first_name' => [$userExists ? 'nullable' : 'required', 'string', 'max:255'],
|
||||
'last_name' => [$userExists ? 'nullable' : 'required', 'string', 'max:255'],
|
||||
'password' => [$userExists ? 'nullable' : 'required', 'string', 'min:8', 'confirmed'],
|
||||
];
|
||||
}
|
||||
|
||||
@@ -19,7 +19,8 @@ final class StoreCompanyRequest extends FormRequest
|
||||
return [
|
||||
'name' => ['required', 'string', 'max:100'],
|
||||
'type' => ['required', 'in:supplier,partner,agency,venue,other'],
|
||||
'contact_name' => ['nullable', 'string', 'max:100'],
|
||||
'contact_first_name' => ['nullable', 'string', 'max:100'],
|
||||
'contact_last_name' => ['nullable', 'string', 'max:100'],
|
||||
'contact_email' => ['nullable', 'email', 'max:100'],
|
||||
'contact_phone' => ['nullable', 'string', 'max:30'],
|
||||
];
|
||||
|
||||
@@ -18,7 +18,8 @@ final class StorePersonRequest extends FormRequest
|
||||
{
|
||||
return [
|
||||
'crowd_type_id' => ['required', 'ulid', 'exists:crowd_types,id'],
|
||||
'name' => ['required', 'string', 'max:255'],
|
||||
'first_name' => ['required', 'string', 'max:255'],
|
||||
'last_name' => ['required', 'string', 'max:255'],
|
||||
'email' => ['required', 'email', 'max:255'],
|
||||
'phone' => ['nullable', 'string', 'max:30'],
|
||||
'company_id' => ['nullable', 'ulid', 'exists:companies,id'],
|
||||
|
||||
@@ -19,7 +19,8 @@ final class UpdateCompanyRequest extends FormRequest
|
||||
return [
|
||||
'name' => ['sometimes', 'string', 'max:100'],
|
||||
'type' => ['sometimes', 'in:supplier,partner,agency,venue,other'],
|
||||
'contact_name' => ['nullable', 'string', 'max:100'],
|
||||
'contact_first_name' => ['nullable', 'string', 'max:100'],
|
||||
'contact_last_name' => ['nullable', 'string', 'max:100'],
|
||||
'contact_email' => ['nullable', 'email', 'max:100'],
|
||||
'contact_phone' => ['nullable', 'string', 'max:30'],
|
||||
];
|
||||
|
||||
@@ -18,7 +18,8 @@ final class UpdatePersonRequest extends FormRequest
|
||||
{
|
||||
return [
|
||||
'crowd_type_id' => ['sometimes', 'ulid', 'exists:crowd_types,id'],
|
||||
'name' => ['sometimes', 'string', 'max:255'],
|
||||
'first_name' => ['sometimes', 'string', 'max:255'],
|
||||
'last_name' => ['sometimes', 'string', 'max:255'],
|
||||
'email' => ['sometimes', 'email', 'max:255'],
|
||||
'phone' => ['nullable', 'string', 'max:30'],
|
||||
'company_id' => ['nullable', 'ulid', 'exists:companies,id'],
|
||||
|
||||
@@ -19,7 +19,8 @@ final class VolunteerRegistrationRequest extends FormRequest
|
||||
|
||||
if ($user) {
|
||||
$this->merge([
|
||||
'name' => $user->name,
|
||||
'first_name' => $user->first_name,
|
||||
'last_name' => $user->last_name,
|
||||
'email' => $user->email,
|
||||
'_authenticated' => true,
|
||||
]);
|
||||
@@ -30,7 +31,8 @@ final class VolunteerRegistrationRequest extends FormRequest
|
||||
public function rules(): array
|
||||
{
|
||||
return [
|
||||
'name' => ['required_without:_authenticated', 'string', 'max:255'],
|
||||
'first_name' => ['required_without:_authenticated', 'string', 'max:255'],
|
||||
'last_name' => ['required_without:_authenticated', 'string', 'max:255'],
|
||||
'email' => ['required_without:_authenticated', 'email', 'max:255'],
|
||||
'phone' => ['nullable', 'string', 'max:50'],
|
||||
|
||||
|
||||
Reference in New Issue
Block a user