test(forms): model tests, multi-tenancy, migration rollback (Phase 9)
UserProfileTest: belongs-to user, fillable/non-fillable boundaries, settings cast, lastSubmittedAt accessor (null + max from user-subject submissions only, ignoring drafts and is_test rows). FormSchemaTest: ULID PK, OrganisationScope filtering, polymorphic owner resolution to Event, purpose enum cast, hasMany fields/submissions, and logSchemaChange() actually creates an activity-log entry. FormFieldTest: belongs-to schema, field_type stored as string (not DB enum), binding/translations array casts, hasMany values, soft-delete preserves historical values, logFieldChange() creates an entry. FormSubmissionTest: belongs-to schema, polymorphic subject resolution, status enum cast, schema_snapshot array cast, hasMany values. FormValueTest: belongs-to submission/field, value array cast, hasMany options pivot rebuilt by observer, unique-pair DB constraint enforced. MultiTenancyTest: OrganisationScope correctly filters FormSchema / FormTemplate / FormFieldLibrary by route-resolved organisation. Pins the FormSchemaWebhook un-scoped behaviour explicitly so a future scope addition is an intentional decision, not an accident. MigrationRollbackTest (group 'slow'): full migrate:fresh → rollback 14 S1 steps → assert all 13 form-builder tables dropped + legacy tables intentionally retained → re-migrate and assert table list matches snapshot. Plus a separate test exercising the populate-user-profiles migration's down(). Supporting tweaks: - UserProfile::lastSubmittedAt accessor now returns Carbon|null instead of a raw timestamp string — testable, and matches Eloquent convention. - UserProfileFactory cooperates with UserObserver via newModel override (updates the auto-created row instead of inserting a duplicate). - AppServiceProvider morph map extended with all 12 form-builder model keys so logSchemaChange/logFieldChange resolve under enforceMorphMap. Suite: 945 passed (was 911), 2671 assertions. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This commit is contained in:
95
api/tests/Unit/Models/FormBuilder/FormFieldTest.php
Normal file
95
api/tests/Unit/Models/FormBuilder/FormFieldTest.php
Normal file
@@ -0,0 +1,95 @@
|
||||
<?php
|
||||
|
||||
declare(strict_types=1);
|
||||
|
||||
namespace Tests\Unit\Models\FormBuilder;
|
||||
|
||||
use App\Enums\FormBuilder\FormFieldType;
|
||||
use App\Models\FormBuilder\FormField;
|
||||
use App\Models\FormBuilder\FormSchema;
|
||||
use App\Models\FormBuilder\FormSubmission;
|
||||
use App\Models\FormBuilder\FormValue;
|
||||
use Illuminate\Foundation\Testing\RefreshDatabase;
|
||||
use Spatie\Activitylog\Models\Activity;
|
||||
use Tests\TestCase;
|
||||
|
||||
final class FormFieldTest extends TestCase
|
||||
{
|
||||
use RefreshDatabase;
|
||||
|
||||
public function test_form_field_belongs_to_schema(): void
|
||||
{
|
||||
$schema = FormSchema::factory()->create();
|
||||
$field = FormField::factory()->for($schema, 'schema')->create();
|
||||
|
||||
$this->assertSame($schema->id, $field->schema->id);
|
||||
}
|
||||
|
||||
public function test_form_field_stores_field_type_as_string(): void
|
||||
{
|
||||
$field = FormField::factory()->ofType(FormFieldType::SELECT)->create();
|
||||
$this->assertSame('SELECT', $field->fresh()->field_type);
|
||||
$this->assertIsString($field->fresh()->field_type);
|
||||
}
|
||||
|
||||
public function test_form_field_casts_binding_and_translations_to_array(): void
|
||||
{
|
||||
$field = FormField::factory()->create([
|
||||
'binding' => ['mode' => 'entity_owned', 'entity' => 'person', 'column' => 'first_name'],
|
||||
'translations' => ['en' => ['label' => 'First name']],
|
||||
]);
|
||||
$fresh = $field->fresh();
|
||||
|
||||
$this->assertIsArray($fresh->binding);
|
||||
$this->assertSame('entity_owned', $fresh->binding['mode']);
|
||||
$this->assertIsArray($fresh->translations);
|
||||
$this->assertSame('First name', $fresh->translations['en']['label']);
|
||||
}
|
||||
|
||||
public function test_form_field_has_many_values(): void
|
||||
{
|
||||
$schema = FormSchema::factory()->create();
|
||||
$field = FormField::factory()->for($schema, 'schema')->create();
|
||||
$submissions = FormSubmission::factory()->count(2)->create(['form_schema_id' => $schema->id]);
|
||||
foreach ($submissions as $submission) {
|
||||
FormValue::create([
|
||||
'form_field_id' => $field->id,
|
||||
'form_submission_id' => $submission->id,
|
||||
'value' => ['value' => 'x'],
|
||||
]);
|
||||
}
|
||||
|
||||
$this->assertCount(2, $field->fresh()->values);
|
||||
}
|
||||
|
||||
public function test_form_field_soft_deletes_preserve_values(): void
|
||||
{
|
||||
$schema = FormSchema::factory()->create();
|
||||
$field = FormField::factory()->for($schema, 'schema')->create();
|
||||
$submission = FormSubmission::factory()->create(['form_schema_id' => $schema->id]);
|
||||
$value = FormValue::factory()->create([
|
||||
'form_field_id' => $field->id,
|
||||
'form_submission_id' => $submission->id,
|
||||
]);
|
||||
|
||||
$field->delete();
|
||||
|
||||
$this->assertNotNull(FormValue::find($value->id));
|
||||
}
|
||||
|
||||
public function test_log_field_change_creates_activity_entry(): void
|
||||
{
|
||||
Activity::query()->delete();
|
||||
$field = FormField::factory()->create();
|
||||
|
||||
$field->logFieldChange('field.binding_changed', ['from' => null, 'to' => ['mode' => 'entity_owned']]);
|
||||
|
||||
$entry = Activity::query()
|
||||
->where('subject_type', $field->getMorphClass())
|
||||
->where('subject_id', $field->id)
|
||||
->first();
|
||||
|
||||
$this->assertNotNull($entry);
|
||||
$this->assertSame('field.binding_changed', $entry->description);
|
||||
}
|
||||
}
|
||||
Reference in New Issue
Block a user