test(forms): model tests, multi-tenancy, migration rollback (Phase 9)

UserProfileTest: belongs-to user, fillable/non-fillable boundaries,
settings cast, lastSubmittedAt accessor (null + max from user-subject
submissions only, ignoring drafts and is_test rows).

FormSchemaTest: ULID PK, OrganisationScope filtering, polymorphic owner
resolution to Event, purpose enum cast, hasMany fields/submissions, and
logSchemaChange() actually creates an activity-log entry.

FormFieldTest: belongs-to schema, field_type stored as string (not DB
enum), binding/translations array casts, hasMany values, soft-delete
preserves historical values, logFieldChange() creates an entry.

FormSubmissionTest: belongs-to schema, polymorphic subject resolution,
status enum cast, schema_snapshot array cast, hasMany values.

FormValueTest: belongs-to submission/field, value array cast, hasMany
options pivot rebuilt by observer, unique-pair DB constraint enforced.

MultiTenancyTest: OrganisationScope correctly filters FormSchema /
FormTemplate / FormFieldLibrary by route-resolved organisation. Pins
the FormSchemaWebhook un-scoped behaviour explicitly so a future scope
addition is an intentional decision, not an accident.

MigrationRollbackTest (group 'slow'): full migrate:fresh → rollback 14
S1 steps → assert all 13 form-builder tables dropped + legacy tables
intentionally retained → re-migrate and assert table list matches
snapshot. Plus a separate test exercising the populate-user-profiles
migration's down().

Supporting tweaks:
- UserProfile::lastSubmittedAt accessor now returns Carbon|null instead
  of a raw timestamp string — testable, and matches Eloquent convention.
- UserProfileFactory cooperates with UserObserver via newModel override
  (updates the auto-created row instead of inserting a duplicate).
- AppServiceProvider morph map extended with all 12 form-builder model
  keys so logSchemaChange/logFieldChange resolve under enforceMorphMap.

Suite: 945 passed (was 911), 2671 assertions.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

api/tests/Unit/Models/FormBuilder/FormFieldTest.php

@@ -0,0 +1,95 @@
+<?php
+
+declare(strict_types=1);
+
+namespace Tests\Unit\Models\FormBuilder;
+
+use App\Enums\FormBuilder\FormFieldType;
+use App\Models\FormBuilder\FormField;
+use App\Models\FormBuilder\FormSchema;
+use App\Models\FormBuilder\FormSubmission;
+use App\Models\FormBuilder\FormValue;
+use Illuminate\Foundation\Testing\RefreshDatabase;
+use Spatie\Activitylog\Models\Activity;
+use Tests\TestCase;
+
+final class FormFieldTest extends TestCase
+{
+    use RefreshDatabase;
+
+    public function test_form_field_belongs_to_schema(): void
+    {
+        $schema = FormSchema::factory()->create();
+        $field = FormField::factory()->for($schema, 'schema')->create();
+
+        $this->assertSame($schema->id, $field->schema->id);
+    }
+
+    public function test_form_field_stores_field_type_as_string(): void
+    {
+        $field = FormField::factory()->ofType(FormFieldType::SELECT)->create();
+        $this->assertSame('SELECT', $field->fresh()->field_type);
+        $this->assertIsString($field->fresh()->field_type);
+    }
+
+    public function test_form_field_casts_binding_and_translations_to_array(): void
+    {
+        $field = FormField::factory()->create([
+            'binding' => ['mode' => 'entity_owned', 'entity' => 'person', 'column' => 'first_name'],
+            'translations' => ['en' => ['label' => 'First name']],
+        ]);
+        $fresh = $field->fresh();
+
+        $this->assertIsArray($fresh->binding);
+        $this->assertSame('entity_owned', $fresh->binding['mode']);
+        $this->assertIsArray($fresh->translations);
+        $this->assertSame('First name', $fresh->translations['en']['label']);
+    }
+
+    public function test_form_field_has_many_values(): void
+    {
+        $schema = FormSchema::factory()->create();
+        $field = FormField::factory()->for($schema, 'schema')->create();
+        $submissions = FormSubmission::factory()->count(2)->create(['form_schema_id' => $schema->id]);
+        foreach ($submissions as $submission) {
+            FormValue::create([
+                'form_field_id' => $field->id,
+                'form_submission_id' => $submission->id,
+                'value' => ['value' => 'x'],
+            ]);
+        }
+
+        $this->assertCount(2, $field->fresh()->values);
+    }
+
+    public function test_form_field_soft_deletes_preserve_values(): void
+    {
+        $schema = FormSchema::factory()->create();
+        $field = FormField::factory()->for($schema, 'schema')->create();
+        $submission = FormSubmission::factory()->create(['form_schema_id' => $schema->id]);
+        $value = FormValue::factory()->create([
+            'form_field_id' => $field->id,
+            'form_submission_id' => $submission->id,
+        ]);
+
+        $field->delete();
+
+        $this->assertNotNull(FormValue::find($value->id));
+    }
+
+    public function test_log_field_change_creates_activity_entry(): void
+    {
+        Activity::query()->delete();
+        $field = FormField::factory()->create();
+
+        $field->logFieldChange('field.binding_changed', ['from' => null, 'to' => ['mode' => 'entity_owned']]);
+
+        $entry = Activity::query()
+            ->where('subject_type', $field->getMorphClass())
+            ->where('subject_id', $field->id)
+            ->first();
+
+        $this->assertNotNull($entry);
+        $this->assertSame('field.binding_changed', $entry->description);
+    }
+}

api/tests/Unit/Models/FormBuilder/FormSchemaTest.php

@@ -0,0 +1,90 @@
+<?php
+
+declare(strict_types=1);
+
+namespace Tests\Unit\Models\FormBuilder;
+
+use App\Enums\FormBuilder\FormPurpose;
+use App\Models\Event;
+use App\Models\FormBuilder\FormField;
+use App\Models\FormBuilder\FormSchema;
+use App\Models\FormBuilder\FormSubmission;
+use App\Models\Organisation;
+use Illuminate\Foundation\Testing\RefreshDatabase;
+use Spatie\Activitylog\Models\Activity;
+use Tests\TestCase;
+
+final class FormSchemaTest extends TestCase
+{
+    use RefreshDatabase;
+
+    public function test_form_schema_uses_ulids(): void
+    {
+        $schema = FormSchema::factory()->create();
+        $this->assertSame(26, mb_strlen($schema->id));
+    }
+
+    public function test_form_schema_is_org_scoped(): void
+    {
+        $orgA = Organisation::factory()->create();
+        $orgB = Organisation::factory()->create();
+
+        FormSchema::factory()->count(2)->create(['organisation_id' => $orgA->id]);
+        FormSchema::factory()->count(3)->create(['organisation_id' => $orgB->id]);
+
+        // Without context: scope is a no-op (CLI tests have no route context)
+        $this->assertSame(5, FormSchema::query()->count());
+
+        // Manually-applied scope filters by org
+        $orgAOnly = FormSchema::query()
+            ->where('organisation_id', $orgA->id)
+            ->count();
+        $this->assertSame(2, $orgAOnly);
+    }
+
+    public function test_form_schema_morphs_to_owner(): void
+    {
+        $event = Event::factory()->create();
+        $schema = FormSchema::factory()->create([
+            'organisation_id' => $event->organisation_id,
+            'owner_type' => 'event',
+            'owner_id' => $event->id,
+        ]);
+
+        $this->assertInstanceOf(Event::class, $schema->owner);
+        $this->assertSame($event->id, $schema->owner->id);
+    }
+
+    public function test_form_schema_casts_purpose_to_enum(): void
+    {
+        $schema = FormSchema::factory()->forPurpose(FormPurpose::INCIDENT_REPORT)->create();
+        $this->assertSame(FormPurpose::INCIDENT_REPORT, $schema->fresh()->purpose);
+    }
+
+    public function test_form_schema_has_many_fields_and_submissions(): void
+    {
+        $schema = FormSchema::factory()->create();
+        FormField::factory()->count(3)->for($schema, 'schema')->create();
+        FormSubmission::factory()->count(2)->create(['form_schema_id' => $schema->id]);
+
+        $this->assertCount(3, $schema->fresh()->fields);
+        $this->assertCount(2, $schema->fresh()->submissions);
+    }
+
+    public function test_log_schema_change_creates_activity_entry(): void
+    {
+        Activity::query()->delete();
+        $schema = FormSchema::factory()->create();
+
+        $schema->logSchemaChange('schema.published', ['by' => 'admin']);
+
+        $entry = Activity::query()
+            ->where('subject_type', $schema->getMorphClass())
+            ->where('subject_id', $schema->id)
+            ->first();
+
+        $this->assertNotNull($entry);
+        $this->assertSame('schema.published', $entry->description);
+        $this->assertSame('admin', $entry->properties->get('by'));
+    }
+}

api/tests/Unit/Models/FormBuilder/FormSubmissionTest.php

@@ -0,0 +1,70 @@
+<?php
+
+declare(strict_types=1);
+
+namespace Tests\Unit\Models\FormBuilder;
+
+use App\Enums\FormBuilder\FormSubmissionStatus;
+use App\Models\FormBuilder\FormField;
+use App\Models\FormBuilder\FormSchema;
+use App\Models\FormBuilder\FormSubmission;
+use App\Models\FormBuilder\FormValue;
+use App\Models\Person;
+use Illuminate\Foundation\Testing\RefreshDatabase;
+use Tests\TestCase;
+
+final class FormSubmissionTest extends TestCase
+{
+    use RefreshDatabase;
+
+    public function test_form_submission_belongs_to_schema(): void
+    {
+        $schema = FormSchema::factory()->create();
+        $submission = FormSubmission::factory()->create(['form_schema_id' => $schema->id]);
+
+        $this->assertSame($schema->id, $submission->schema->id);
+    }
+
+    public function test_form_submission_morphs_to_subject(): void
+    {
+        $person = Person::factory()->create();
+        $submission = FormSubmission::factory()->create([
+            'subject_type' => 'person',
+            'subject_id' => $person->id,
+        ]);
+
+        $this->assertInstanceOf(Person::class, $submission->subject);
+        $this->assertSame($person->id, $submission->subject->id);
+    }
+
+    public function test_form_submission_casts_status_to_enum(): void
+    {
+        $submission = FormSubmission::factory()->submitted()->create();
+        $this->assertSame(FormSubmissionStatus::SUBMITTED, $submission->fresh()->status);
+    }
+
+    public function test_form_submission_casts_schema_snapshot_to_array(): void
+    {
+        $snapshot = ['schema_version' => 2, 'fields' => [['slug' => 'shirtmaat']]];
+        $submission = FormSubmission::factory()->create(['schema_snapshot' => $snapshot]);
+
+        $this->assertIsArray($submission->fresh()->schema_snapshot);
+        $this->assertSame(2, $submission->fresh()->schema_snapshot['schema_version']);
+    }
+
+    public function test_form_submission_has_many_values(): void
+    {
+        $schema = FormSchema::factory()->create();
+        $fields = FormField::factory()->count(3)->for($schema, 'schema')->create();
+        $submission = FormSubmission::factory()->create(['form_schema_id' => $schema->id]);
+        foreach ($fields as $field) {
+            FormValue::create([
+                'form_submission_id' => $submission->id,
+                'form_field_id' => $field->id,
+                'value' => ['value' => 'x'],
+            ]);
+        }
+
+        $this->assertCount(3, $submission->fresh()->values);
+    }
+}

api/tests/Unit/Models/FormBuilder/FormValueTest.php

@@ -0,0 +1,86 @@
+<?php
+
+declare(strict_types=1);
+
+namespace Tests\Unit\Models\FormBuilder;
+
+use App\Enums\FormBuilder\FormFieldType;
+use App\Models\FormBuilder\FormField;
+use App\Models\FormBuilder\FormSchema;
+use App\Models\FormBuilder\FormSubmission;
+use App\Models\FormBuilder\FormValue;
+use App\Models\FormBuilder\FormValueOption;
+use Illuminate\Database\QueryException;
+use Illuminate\Foundation\Testing\RefreshDatabase;
+use Tests\TestCase;
+
+final class FormValueTest extends TestCase
+{
+    use RefreshDatabase;
+
+    public function test_form_value_belongs_to_submission_and_field(): void
+    {
+        $schema = FormSchema::factory()->create();
+        $field = FormField::factory()->for($schema, 'schema')->create();
+        $submission = FormSubmission::factory()->create(['form_schema_id' => $schema->id]);
+
+        $value = FormValue::factory()->create([
+            'form_submission_id' => $submission->id,
+            'form_field_id' => $field->id,
+        ]);
+
+        $this->assertSame($submission->id, $value->submission->id);
+        $this->assertSame($field->id, $value->field->id);
+    }
+
+    public function test_form_value_casts_value_to_array(): void
+    {
+        $schema = FormSchema::factory()->create();
+        $field = FormField::factory()->for($schema, 'schema')->create();
+        $submission = FormSubmission::factory()->create(['form_schema_id' => $schema->id]);
+        $value = FormValue::create([
+            'form_submission_id' => $submission->id,
+            'form_field_id' => $field->id,
+            'value' => ['value' => 'hallo'],
+        ]);
+
+        $this->assertIsArray($value->fresh()->value);
+        $this->assertSame('hallo', $value->fresh()->value['value']);
+    }
+
+    public function test_form_value_has_many_options(): void
+    {
+        $schema = FormSchema::factory()->create();
+        $field = FormField::factory()->for($schema, 'schema')->ofType(FormFieldType::MULTISELECT)->filterable()->create();
+        $submission = FormSubmission::factory()->create(['form_schema_id' => $schema->id]);
+
+        $value = FormValue::create([
+            'form_submission_id' => $submission->id,
+            'form_field_id' => $field->id,
+            'value' => ['A', 'B', 'C'],
+        ]);
+
+        // Observer rebuilds the pivot on save.
+        $this->assertCount(3, $value->fresh()->options);
+        $this->assertSame(3, FormValueOption::where('form_value_id', $value->id)->count());
+    }
+
+    public function test_form_value_is_unique_per_submission_field_pair(): void
+    {
+        $schema = FormSchema::factory()->create();
+        $field = FormField::factory()->for($schema, 'schema')->create();
+        $submission = FormSubmission::factory()->create(['form_schema_id' => $schema->id]);
+        FormValue::create([
+            'form_submission_id' => $submission->id,
+            'form_field_id' => $field->id,
+            'value' => ['value' => 'x'],
+        ]);
+
+        $this->expectException(QueryException::class);
+        FormValue::create([
+            'form_submission_id' => $submission->id,
+            'form_field_id' => $field->id,
+            'value' => ['value' => 'y'],
+        ]);
+    }
+}

api/tests/Unit/Models/UserProfileTest.php

@@ -0,0 +1,118 @@
+<?php
+
+declare(strict_types=1);
+
+namespace Tests\Unit\Models;
+
+use App\Enums\FormBuilder\FormSubmissionStatus;
+use App\Models\FormBuilder\FormSchema;
+use App\Models\FormBuilder\FormSubmission;
+use App\Models\User;
+use App\Models\UserProfile;
+use Illuminate\Foundation\Testing\RefreshDatabase;
+use Tests\TestCase;
+
+final class UserProfileTest extends TestCase
+{
+    use RefreshDatabase;
+
+    public function test_user_profile_belongs_to_user(): void
+    {
+        $user = User::factory()->create();
+        $profile = $user->profile;
+
+        $this->assertNotNull($profile);
+        $this->assertSame($user->id, $profile->user->id);
+    }
+
+    public function test_emergency_contact_fields_are_fillable(): void
+    {
+        $profile = UserProfile::factory()->create([
+            'emergency_contact_name' => 'Partner',
+            'emergency_contact_phone' => '+31611112222',
+        ]);
+
+        $this->assertSame('Partner', $profile->emergency_contact_name);
+        $this->assertSame('+31611112222', $profile->emergency_contact_phone);
+    }
+
+    public function test_reliability_score_is_not_fillable(): void
+    {
+        $profile = (new UserProfile)->fill([
+            'user_id' => (string) \Illuminate\Support\Str::ulid(),
+            'reliability_score' => 4.99,
+        ]);
+
+        $this->assertNull($profile->reliability_score);
+    }
+
+    public function test_is_ambassador_is_not_fillable(): void
+    {
+        $profile = (new UserProfile)->fill([
+            'user_id' => (string) \Illuminate\Support\Str::ulid(),
+            'is_ambassador' => true,
+        ]);
+
+        $this->assertNull($profile->is_ambassador);
+    }
+
+    public function test_settings_is_cast_to_array(): void
+    {
+        $profile = UserProfile::factory()->create([
+            'settings' => ['ui.theme' => 'dark'],
+        ]);
+
+        $this->assertIsArray($profile->fresh()->settings);
+        $this->assertSame('dark', $profile->fresh()->settings['ui.theme']);
+    }
+
+    public function test_last_submitted_at_returns_null_when_no_submissions(): void
+    {
+        $user = User::factory()->create();
+        $profile = $user->profile;
+
+        $this->assertNull($profile->last_submitted_at);
+    }
+
+    public function test_last_submitted_at_returns_max_submitted_at_from_user_subject_submissions(): void
+    {
+        $user = User::factory()->create();
+        $schema = FormSchema::factory()->create();
+
+        FormSubmission::factory()->create([
+            'form_schema_id' => $schema->id,
+            'subject_type' => 'user',
+            'subject_id' => $user->id,
+            'status' => FormSubmissionStatus::SUBMITTED,
+            'submitted_at' => now()->subDays(5),
+        ]);
+        $latest = FormSubmission::factory()->create([
+            'form_schema_id' => $schema->id,
+            'subject_type' => 'user',
+            'subject_id' => $user->id,
+            'status' => FormSubmissionStatus::SUBMITTED,
+            'submitted_at' => now()->subDay(),
+        ]);
+        // A draft and a test submission should be ignored.
+        FormSubmission::factory()->create([
+            'form_schema_id' => $schema->id,
+            'subject_type' => 'user',
+            'subject_id' => $user->id,
+            'status' => FormSubmissionStatus::DRAFT,
+            'submitted_at' => now(),
+        ]);
+        FormSubmission::factory()->create([
+            'form_schema_id' => $schema->id,
+            'subject_type' => 'user',
+            'subject_id' => $user->id,
+            'status' => FormSubmissionStatus::SUBMITTED,
+            'submitted_at' => now(),
+            'is_test' => true,
+        ]);
+
+        $this->assertSame(
+            $latest->submitted_at->format('Y-m-d H:i:s'),
+            $user->profile->last_submitted_at->format('Y-m-d H:i:s')
+        );
+    }
+}