feat: crowd lists audit, enum, factory, service and tests
Audit and complete the Crowd Lists module: - Add CrowdListType enum (internal/external) with proper casts - Create CrowdListService for business logic (add/remove person, max_persons enforcement, auto_approve, activity logging) - Create CrowdListFactory with Dutch names and states - Create AddPersonToCrowdListRequest form request - Fix FormRequests to use Rule::enum instead of hardcoded strings - Fix CrowdListResource to use enum->value and add is_full field - Refactor controller to be thin (delegates to service) - Add eager loading for crowdType and recipientCompany - Write 18 comprehensive tests (CRUD, auth, edge cases) - Update API.md with request/response documentation Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This commit is contained in:
@@ -5,24 +5,32 @@ declare(strict_types=1);
|
||||
namespace App\Http\Controllers\Api\V1;
|
||||
|
||||
use App\Http\Controllers\Controller;
|
||||
use App\Http\Requests\Api\V1\AddPersonToCrowdListRequest;
|
||||
use App\Http\Requests\Api\V1\StoreCrowdListRequest;
|
||||
use App\Http\Requests\Api\V1\UpdateCrowdListRequest;
|
||||
use App\Http\Resources\Api\V1\CrowdListResource;
|
||||
use App\Models\CrowdList;
|
||||
use App\Models\Event;
|
||||
use App\Models\Person;
|
||||
use App\Services\CrowdListService;
|
||||
use Illuminate\Http\JsonResponse;
|
||||
use Illuminate\Http\Request;
|
||||
use Illuminate\Http\Resources\Json\AnonymousResourceCollection;
|
||||
use Illuminate\Support\Facades\Gate;
|
||||
|
||||
final class CrowdListController extends Controller
|
||||
{
|
||||
public function __construct(
|
||||
private readonly CrowdListService $crowdListService,
|
||||
) {}
|
||||
|
||||
public function index(Event $event): AnonymousResourceCollection
|
||||
{
|
||||
Gate::authorize('viewAny', [CrowdList::class, $event]);
|
||||
|
||||
$crowdLists = $event->crowdLists()->withCount('persons')->get();
|
||||
$crowdLists = $event->crowdLists()
|
||||
->with(['crowdType', 'recipientCompany'])
|
||||
->withCount('persons')
|
||||
->get();
|
||||
|
||||
return CrowdListResource::collection($crowdLists);
|
||||
}
|
||||
@@ -31,43 +39,36 @@ final class CrowdListController extends Controller
|
||||
{
|
||||
Gate::authorize('create', [CrowdList::class, $event]);
|
||||
|
||||
$crowdList = $event->crowdLists()->create($request->validated());
|
||||
$crowdList = $this->crowdListService->create($event, $request->validated(), $request->user());
|
||||
|
||||
return $this->created(new CrowdListResource($crowdList));
|
||||
return $this->created(new CrowdListResource($crowdList->loadCount('persons')));
|
||||
}
|
||||
|
||||
public function update(UpdateCrowdListRequest $request, Event $event, CrowdList $crowdList): JsonResponse
|
||||
{
|
||||
Gate::authorize('update', [$crowdList, $event]);
|
||||
|
||||
$crowdList->update($request->validated());
|
||||
$crowdList = $this->crowdListService->update($crowdList, $request->validated(), $request->user());
|
||||
|
||||
return $this->success(new CrowdListResource($crowdList->fresh()));
|
||||
return $this->success(new CrowdListResource($crowdList->loadCount('persons')));
|
||||
}
|
||||
|
||||
public function destroy(Event $event, CrowdList $crowdList): JsonResponse
|
||||
{
|
||||
Gate::authorize('delete', [$crowdList, $event]);
|
||||
|
||||
$crowdList->delete();
|
||||
$this->crowdListService->delete($crowdList, request()->user());
|
||||
|
||||
return response()->json(null, 204);
|
||||
}
|
||||
|
||||
public function addPerson(Request $request, Event $event, CrowdList $crowdList): JsonResponse
|
||||
public function addPerson(AddPersonToCrowdListRequest $request, Event $event, CrowdList $crowdList): JsonResponse
|
||||
{
|
||||
Gate::authorize('managePerson', [$crowdList, $event]);
|
||||
|
||||
$validated = $request->validate([
|
||||
'person_id' => ['required', 'ulid', 'exists:persons,id'],
|
||||
]);
|
||||
$person = Person::findOrFail($request->validated('person_id'));
|
||||
|
||||
$crowdList->persons()->syncWithoutDetaching([
|
||||
$validated['person_id'] => [
|
||||
'added_at' => now(),
|
||||
'added_by_user_id' => $request->user()->id,
|
||||
],
|
||||
]);
|
||||
$this->crowdListService->addPerson($crowdList, $person, $request->user());
|
||||
|
||||
return $this->success(new CrowdListResource($crowdList->fresh()->loadCount('persons')));
|
||||
}
|
||||
@@ -76,7 +77,7 @@ final class CrowdListController extends Controller
|
||||
{
|
||||
Gate::authorize('managePerson', [$crowdList, $event]);
|
||||
|
||||
$crowdList->persons()->detach($person->id);
|
||||
$this->crowdListService->removePerson($crowdList, $person, request()->user());
|
||||
|
||||
return response()->json(null, 204);
|
||||
}
|
||||
|
||||
Reference in New Issue
Block a user