feat(form-builder): add FormSubmissionActionFailure model + apply_status casts (WS-6)

- FormSubmissionActionFailure: audit model, no organisation_id (FK-chain
  tenancy per RFC V3), open/resolved/dismissed scopes, canBeRetried()
  helper. Morph alias 'form_submission_action_failure' registered for
  future activity-log subject references.
- FormSubmission: apply_status (ApplyStatus enum cast),
  apply_completed_at (datetime), actionFailures() HasMany,
  scopePendingApply().

Refs: RFC-WS-6.md §3 (Q5), §4 (V3)

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This commit is contained in:
2026-04-25 22:47:06 +02:00
parent 0dd991c688
commit c5b0210ae7
6 changed files with 372 additions and 0 deletions

View File

@@ -0,0 +1,74 @@
<?php
declare(strict_types=1);
namespace Tests\Feature\FormBuilder;
use App\Enums\FormBuilder\ApplyStatus;
use App\Models\FormBuilder\FormSchema;
use App\Models\FormBuilder\FormSubmission;
use App\Models\Organisation;
use Illuminate\Foundation\Testing\RefreshDatabase;
use Illuminate\Support\Facades\DB;
use Illuminate\Support\Str;
use Tests\TestCase;
final class FormSubmissionApplyStatusCastTest extends TestCase
{
use RefreshDatabase;
public function test_apply_status_round_trips_as_enum(): void
{
$submission = FormSubmission::factory()->create();
$submission->apply_status = ApplyStatus::COMPLETED;
$submission->save();
$reloaded = FormSubmission::query()->find($submission->id);
$this->assertSame(ApplyStatus::COMPLETED, $reloaded->apply_status);
}
public function test_apply_status_null_round_trip(): void
{
$submission = FormSubmission::factory()->create();
$this->assertNull($submission->apply_status);
$submission->apply_status = null;
$submission->save();
$reloaded = FormSubmission::query()->find($submission->id);
$this->assertNull($reloaded->apply_status);
}
public function test_legacy_seed_row_without_apply_status_remains_null(): void
{
$organisation = Organisation::factory()->create();
$schema = FormSchema::factory()->for($organisation)->create();
$id = (string) Str::ulid();
DB::table('form_submissions')->insert([
'id' => $id,
'form_schema_id' => $schema->id,
'organisation_id' => $organisation->id,
'status' => 'submitted',
'is_test' => false,
'auto_save_count' => 0,
'created_at' => now(),
'updated_at' => now(),
]);
$reloaded = FormSubmission::query()->find($id);
$this->assertNull($reloaded->apply_status);
}
public function test_pending_apply_scope_filters_correctly(): void
{
FormSubmission::factory()->create(['apply_status' => ApplyStatus::PENDING]);
FormSubmission::factory()->create(['apply_status' => ApplyStatus::COMPLETED]);
FormSubmission::factory()->create(['apply_status' => ApplyStatus::FAILED]);
FormSubmission::factory()->create(); // null
$pending = FormSubmission::query()->pendingApply()->get();
$this->assertCount(1, $pending);
$this->assertSame(ApplyStatus::PENDING, $pending->first()->apply_status);
}
}

View File

@@ -0,0 +1,95 @@
<?php
declare(strict_types=1);
namespace Tests\Unit\Models\FormBuilder;
use App\Enums\FormBuilder\DismissalReasonType;
use App\Models\FormBuilder\FormSubmission;
use App\Models\FormBuilder\FormSubmissionActionFailure;
use Illuminate\Foundation\Testing\RefreshDatabase;
use Illuminate\Support\Facades\Schema;
use Tests\TestCase;
final class FormSubmissionActionFailureTest extends TestCase
{
use RefreshDatabase;
public function test_factory_creates_row_with_sensible_defaults(): void
{
$failure = FormSubmissionActionFailure::factory()->create();
$this->assertNotEmpty($failure->id);
$this->assertSame(0, $failure->retry_count);
$this->assertNull($failure->resolved_at);
$this->assertNull($failure->dismissed_at);
$this->assertNotEmpty($failure->context);
}
public function test_submission_relation_returns_parent(): void
{
$submission = FormSubmission::factory()->create();
$failure = FormSubmissionActionFailure::factory()
->for($submission, 'submission')
->create();
$this->assertSame($submission->id, $failure->submission->id);
}
public function test_binding_relation_is_nullable(): void
{
$failure = FormSubmissionActionFailure::factory()->create();
$this->assertNull($failure->binding);
}
public function test_open_scope_excludes_resolved_and_dismissed(): void
{
FormSubmissionActionFailure::factory()->create();
FormSubmissionActionFailure::factory()->resolved()->create();
FormSubmissionActionFailure::factory()->dismissed()->create();
$this->assertSame(1, FormSubmissionActionFailure::query()->open()->count());
$this->assertSame(1, FormSubmissionActionFailure::query()->resolved()->count());
$this->assertSame(1, FormSubmissionActionFailure::query()->dismissed()->count());
}
public function test_dismissed_reason_type_round_trips_as_enum(): void
{
$failure = FormSubmissionActionFailure::factory()->create([
'dismissed_reason_type' => DismissalReasonType::DATA_QUALITY_ISSUE,
'dismissed_at' => now(),
]);
$reloaded = FormSubmissionActionFailure::query()->find($failure->id);
$this->assertSame(DismissalReasonType::DATA_QUALITY_ISSUE, $reloaded->dismissed_reason_type);
}
public function test_context_round_trips_as_array(): void
{
$failure = FormSubmissionActionFailure::factory()->create([
'context' => ['target_entity' => 'company', 'target_attribute' => 'kvk_number'],
]);
$reloaded = FormSubmissionActionFailure::query()->find($failure->id);
$this->assertSame('company', $reloaded->context['target_entity']);
}
public function test_can_be_retried_false_when_dismissed(): void
{
$open = FormSubmissionActionFailure::factory()->create();
$resolved = FormSubmissionActionFailure::factory()->resolved()->create();
$dismissed = FormSubmissionActionFailure::factory()->dismissed()->create();
$this->assertTrue($open->canBeRetried());
$this->assertTrue($resolved->canBeRetried());
$this->assertFalse($dismissed->canBeRetried());
}
public function test_table_has_no_organisation_id_column_per_rfc_v3(): void
{
$this->assertFalse(
Schema::hasColumn('form_submission_action_failures', 'organisation_id'),
'Tenant scope must flow via FK chain to form_submissions.organisation_id (RFC V3)',
);
}
}