feat(form-builder): form_field_bindings table + polymorphic owner + cascade observer

WS-5a commit 1 of 4 per ARCH-CONSOLIDATION-ADDENDUM-2026-04-24 Q3. Creates the relational home for what was form_fields.binding JSON and form_field_library.default_binding JSON. Owner discriminator is polymorphic morph (owner_type/owner_id) — the pattern the rest of WS-5 (5b validation_rules, 5d options) will reuse. Migration backfills rows from both JSON sources in a single transaction and is genuinely reversible (rollback reconstructs the JSON). Old columns remain in place until commit 3 has switched all readers. Pattern B (binding=null) is represented by absence of row. mode enum covers entity_owned / mirrored only. Cascade on owner delete via observer — bindings are physical state, not historical audit. FormFieldBindingScope enforces multi-tenancy via UNION over both owner chains (form_field → schema → org OR form_field_library → org) — Q2's declarative tenantScopeStrategy() can't walk morph parents. Tests: migration forward/back, morph relation, cascade observer, scope isolation, enum coverage. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
2026-04-24 18:43:11 +02:00
parent 76090b934e
commit af8a9da038
17 changed files with 1081 additions and 0 deletions
--- a/api/tests/Feature/FormBuilder/Bindings/FormFieldBindingCascadeTest.php
+++ b/api/tests/Feature/FormBuilder/Bindings/FormFieldBindingCascadeTest.php
@@ -0,0 +1,86 @@
+<?php
+
+declare(strict_types=1);
+
+namespace Tests\Feature\FormBuilder\Bindings;
+
+use App\Models\FormBuilder\FormField;
+use App\Models\FormBuilder\FormFieldBinding;
+use App\Models\FormBuilder\FormFieldLibrary;
+use App\Models\FormBuilder\FormSchema;
+use App\Models\Organisation;
+use Illuminate\Foundation\Testing\RefreshDatabase;
+use Tests\TestCase;
+
+final class FormFieldBindingCascadeTest extends TestCase
+{
+    use RefreshDatabase;
+
+    public function test_soft_delete_of_field_cascades_bindings(): void
+    {
+        $org = Organisation::factory()->create();
+        $schema = FormSchema::factory()->create(['organisation_id' => $org->id]);
+        $field = FormField::factory()->create(['form_schema_id' => $schema->id]);
+        FormFieldBinding::factory()->forField($field)->entityOwned('person', 'email')->create();
+        FormFieldBinding::factory()->forField($field)->mirrored('user_profile', 'bio')->create();
+
+        $this->assertSame(2, FormFieldBinding::query()
+            ->withoutGlobalScopes()
+            ->where('owner_type', 'form_field')
+            ->where('owner_id', $field->id)
+            ->count(),
+        );
+
+        $field->delete(); // soft delete on FormField
+
+        $this->assertSame(0, FormFieldBinding::query()
+            ->withoutGlobalScopes()
+            ->where('owner_type', 'form_field')
+            ->where('owner_id', $field->id)
+            ->count(),
+        );
+    }
+
+    public function test_delete_of_library_entry_cascades_bindings(): void
+    {
+        $org = Organisation::factory()->create();
+        $library = FormFieldLibrary::factory()->create(['organisation_id' => $org->id]);
+        FormFieldBinding::factory()->forLibrary($library)->entityOwned('person', 'first_name')->create();
+
+        $this->assertSame(1, FormFieldBinding::query()
+            ->withoutGlobalScopes()
+            ->where('owner_type', 'form_field_library')
+            ->where('owner_id', $library->id)
+            ->count(),
+        );
+
+        $library->delete();
+
+        $this->assertSame(0, FormFieldBinding::query()
+            ->withoutGlobalScopes()
+            ->where('owner_type', 'form_field_library')
+            ->where('owner_id', $library->id)
+            ->count(),
+        );
+    }
+
+    public function test_deleting_one_field_does_not_cascade_others(): void
+    {
+        $org = Organisation::factory()->create();
+        $schema = FormSchema::factory()->create(['organisation_id' => $org->id]);
+        $a = FormField::factory()->create(['form_schema_id' => $schema->id]);
+        $b = FormField::factory()->create(['form_schema_id' => $schema->id]);
+
+        FormFieldBinding::factory()->forField($a)->entityOwned('person', 'email')->create();
+        FormFieldBinding::factory()->forField($b)->entityOwned('person', 'phone')->create();
+
+        $a->delete();
+
+        $this->assertSame(1, FormFieldBinding::query()
+            ->withoutGlobalScopes()
+            ->where('owner_type', 'form_field')
+            ->where('owner_id', $b->id)
+            ->count(),
+        );
+    }
+}