test(timetable): Phase C — 57 new tests covering session 2 surface

Nine test files under tests/Feature/Artist/ exercising:

  ArtistEngagementStateMachineTest    8 tests — terminal blocks, conditional
                                       gates (Option/Contracted), full happy
                                       path, cancel cascade
  LaneCascadeServiceTest              5 tests — simple move, cascade-bump,
                                       version mismatch, park, unpark
  BumaVatCalculationTest              6 tests — D26 formula coverage:
                                       Organisation/BookingAgency/NotApplicable,
                                       VAT off, breakdown sum, zero fee
  DemoteExpiredOptionsTest            4 tests — expired demote, future
                                       untouched, non-Option untouched, run
                                       twice → single option_expired entry
  IdempotencyKey60sRedisTest          4 tests — missing header 400, first
                                       cache, replay header, failed not cached
  ArtistControllerTest                8 tests — index/create/destroy + cross-
                                       tenant + duplicate detection + restore
  StageControllerTest                 7 tests — create + uniqueness, destroy
                                       cascade-park, reorder permutation,
                                       replaceDays orphan 409 + force_orphan
  ArtistEngagementControllerTest      5 tests — index/create/update/destroy +
                                       422 on invalid status transition
  TimetableMoveControllerTest         3 tests — happy path with idempotency
                                       header, missing header → 400, version
                                       mismatch → 409
  ArtistPolicyTest                    6 tests — role checks, cross-tenant
                                       denial, super_admin bypass, D27 active-
                                       engagement gate
  ActivityLogShapeTest                4 tests — performance.moved cascade
                                       props, status_changed vs cancelled,
                                       stage.day_added subject + props,
                                       stage.reordered on Event subject

Bug fixes surfaced by Phase C:

  Schema reality: events table uses `start_date`/`end_date` (date), not
  `start_at`/`end_at`. Updated WithinEventBounds rule and the two stage_day
  resolvers (LaneCascadeService + MoveTimetablePerformanceRequest) to
  query the actual columns. ArtistResource.engagements_summary upcoming
  filter likewise.

  performances table has no organisation_id column (FK-chain via
  engagement_id). Removed the org-id filter from the Rule::exists in
  MoveTimetablePerformanceRequest; cross-tenant is caught by the policy
  in TimetableMoveController.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

api/tests/Feature/Artist/DemoteExpiredOptionsTest.php

@@ -0,0 +1,116 @@
+<?php
+
+declare(strict_types=1);
+
+namespace Tests\Feature\Artist;
+
+use App\Enums\Artist\ArtistEngagementStatus;
+use App\Models\Artist;
+use App\Models\ArtistEngagement;
+use App\Models\Event;
+use App\Models\Organisation;
+use Database\Seeders\RoleSeeder;
+use Illuminate\Foundation\Testing\RefreshDatabase;
+use Spatie\Activitylog\Models\Activity;
+use Tests\TestCase;
+
+final class DemoteExpiredOptionsTest extends TestCase
+{
+    use RefreshDatabase;
+
+    private Organisation $org;
+
+    private Event $event;
+
+    private Artist $artist;
+
+    protected function setUp(): void
+    {
+        parent::setUp();
+        $this->seed(RoleSeeder::class);
+
+        $this->org = Organisation::factory()->create();
+        $this->event = Event::factory()->create(['organisation_id' => $this->org->id]);
+        $this->artist = Artist::factory()->create(['organisation_id' => $this->org->id]);
+    }
+
+    public function test_expired_option_demoted_to_draft(): void
+    {
+        $eng = ArtistEngagement::factory()->create([
+            'artist_id' => $this->artist->id,
+            'event_id' => $this->event->id,
+            'booking_status' => ArtistEngagementStatus::Option,
+            'option_expires_at' => now()->subMinute(),
+        ]);
+
+        $this->artisan('artist:demote-expired-options')->assertSuccessful();
+
+        $this->assertSame(
+            ArtistEngagementStatus::Draft,
+            $eng->refresh()->booking_status,
+        );
+
+        $this->assertTrue(
+            Activity::query()
+                ->where('subject_type', $eng->getMorphClass())
+                ->where('subject_id', $eng->id)
+                ->where('event', 'option_expired')
+                ->exists(),
+        );
+    }
+
+    public function test_future_option_untouched(): void
+    {
+        $eng = ArtistEngagement::factory()->create([
+            'artist_id' => $this->artist->id,
+            'event_id' => $this->event->id,
+            'booking_status' => ArtistEngagementStatus::Option,
+            'option_expires_at' => now()->addHour(),
+        ]);
+
+        $this->artisan('artist:demote-expired-options')->assertSuccessful();
+
+        $this->assertSame(
+            ArtistEngagementStatus::Option,
+            $eng->refresh()->booking_status,
+        );
+    }
+
+    public function test_non_option_status_untouched(): void
+    {
+        $eng = ArtistEngagement::factory()->create([
+            'artist_id' => $this->artist->id,
+            'event_id' => $this->event->id,
+            'booking_status' => ArtistEngagementStatus::Confirmed,
+            'option_expires_at' => now()->subDay(),
+        ]);
+
+        $this->artisan('artist:demote-expired-options')->assertSuccessful();
+
+        $this->assertSame(
+            ArtistEngagementStatus::Confirmed,
+            $eng->refresh()->booking_status,
+        );
+    }
+
+    public function test_running_twice_writes_only_one_option_expired_entry(): void
+    {
+        $eng = ArtistEngagement::factory()->create([
+            'artist_id' => $this->artist->id,
+            'event_id' => $this->event->id,
+            'booking_status' => ArtistEngagementStatus::Option,
+            'option_expires_at' => now()->subMinute(),
+        ]);
+
+        $this->artisan('artist:demote-expired-options')->assertSuccessful();
+        $this->artisan('artist:demote-expired-options')->assertSuccessful();
+
+        $count = Activity::query()
+            ->where('subject_type', $eng->getMorphClass())
+            ->where('subject_id', $eng->id)
+            ->where('event', 'option_expired')
+            ->count();
+
+        $this->assertSame(1, $count);
+    }
+}