security: A01-13 — nest all event routes under organisation prefix
Move all authenticated organiser-facing event sub-resource routes from
/events/{event}/... to /organisations/{organisation}/events/{event}/...
to enforce multi-tenancy at the routing layer.
Changes:
- Routes: restructured api.php to nest all event sub-resources under
the existing organisation prefix group
- Controllers: added Organisation parameter and VerifiesOrganisationEvent
trait to all 12 affected controllers (sections, time-slots, shifts,
persons, crowd-lists, locations, shift-assignments, registration-fields,
availabilities, field-values, section-preferences, stats)
- Tests: updated all 20 feature test files with new route paths
- Frontend: updated 8 API composables and 20 Vue components/pages
- API.md: updated documentation to reflect new route structure
Portal routes, public routes (volunteer-register), and invitation routes
remain unchanged as they operate without organisation context.
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This commit is contained in:
@@ -5,9 +5,11 @@ declare(strict_types=1);
|
||||
namespace App\Http\Controllers\Api\V1;
|
||||
|
||||
use App\Http\Controllers\Controller;
|
||||
use App\Http\Controllers\Api\V1\Traits\VerifiesOrganisationEvent;
|
||||
use App\Http\Requests\Api\V1\UpsertPersonFieldValuesRequest;
|
||||
use App\Http\Resources\Api\V1\PersonFieldValueResource;
|
||||
use App\Models\Event;
|
||||
use App\Models\Organisation;
|
||||
use App\Models\Person;
|
||||
use App\Services\RegistrationFormFieldService;
|
||||
use Illuminate\Http\JsonResponse;
|
||||
@@ -16,12 +18,15 @@ use Illuminate\Support\Facades\Gate;
|
||||
|
||||
final class PersonFieldValueController extends Controller
|
||||
{
|
||||
use VerifiesOrganisationEvent;
|
||||
|
||||
public function __construct(
|
||||
private readonly RegistrationFormFieldService $service,
|
||||
) {}
|
||||
|
||||
public function index(Event $event, Person $person): AnonymousResourceCollection
|
||||
public function index(Organisation $organisation, Event $event, Person $person): AnonymousResourceCollection
|
||||
{
|
||||
$this->verifyEventBelongsToOrganisation($organisation, $event);
|
||||
Gate::authorize('view', [$person, $event]);
|
||||
|
||||
$values = $this->service->getPersonValues($person);
|
||||
@@ -29,8 +34,9 @@ final class PersonFieldValueController extends Controller
|
||||
return PersonFieldValueResource::collection($values);
|
||||
}
|
||||
|
||||
public function upsert(UpsertPersonFieldValuesRequest $request, Event $event, Person $person): JsonResponse
|
||||
public function upsert(UpsertPersonFieldValuesRequest $request, Organisation $organisation, Event $event, Person $person): JsonResponse
|
||||
{
|
||||
$this->verifyEventBelongsToOrganisation($organisation, $event);
|
||||
Gate::authorize('update', [$person, $event]);
|
||||
|
||||
$this->service->upsertPersonValues($person, $request->validated()['values']);
|
||||
|
||||
Reference in New Issue
Block a user