bert.hausmans/crewli
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

feat: allow organizer overbooking with confirmation dialog

Browse Source 
Remove capacity and status validation from organizer assign flow so
organizers can intentionally overbook shifts. Log overbooked assignments
for audit trail. Volunteer claims still enforce hard limits. Frontend
shows a warning banner when a shift is full and requires confirmation
before overbooking.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This commit is contained in:
bert.hausmans
2026-04-10 21:09:11 +02:00
parent 212db0d3cb
commit 78cc19373e
4 changed files with 110 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
api/tests/Feature/Api/V1/ShiftAssignmentWorkflowTest.php
View File

@@ -289,7 +289,7 @@ class ShiftAssignmentWorkflowTest extends TestCase
$response->assertCreated();
}
public function test_assign_rejected_when_capacity_full(): void
public function test_assign_allows_overbooking_when_capacity_full(): void
{
$shift = $this->createOpenShift(['slots_total' => 1]);
@@ -310,7 +310,13 @@ class ShiftAssignmentWorkflowTest extends TestCase
['person_id' => $this->person->id],
);
$response->assertUnprocessable();
$response->assertCreated();
$this->assertDatabaseHas('shift_assignments', [
'shift_id' => $shift->id,
'person_id' => $this->person->id,
'status' => 'approved',
]);
}
public function test_assign_rejected_with_conflict(): void

10
api/tests/Feature/Shift/ShiftTest.php
View File

@@ -284,7 +284,7 @@ class ShiftTest extends TestCase
$response->assertCreated();
}
public function test_assign_full_shift_returns_422(): void
public function test_assign_full_shift_allows_overbooking(): void
{
$shift = Shift::factory()->create([
'festival_section_id' => $this->section->id,
@@ -317,7 +317,13 @@ class ShiftTest extends TestCase
'person_id' => $person2->id,
]);
$response->assertUnprocessable();
$response->assertCreated();
$this->assertDatabaseHas('shift_assignments', [
'shift_id' => $shift->id,
'person_id' => $person2->id,
'status' => 'approved',
]);
}
public function test_claim_no_claimable_slots_returns_422(): void