bert.hausmans/crewli
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

fix(gui-v2): rename AppDialog test stub off reserved HTML name "Dialog"

Browse Source 
vue/no-reserved-component-names is error-level; <dialog> is native HTML.
Matching is via the stubs key + findComponent reference, not the stub's
own name, so the rename is behaviour-neutral (14/14 tests still pass).

Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
This commit is contained in:
bert.hausmans
2026-05-16 21:55:14 +02:00
parent 3685797e18
commit 6e5c5bbec3
1 changed files with 6 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

7
apps/app/src/components-v2/shared/__tests__/AppDialog.spec.ts
View File

@@ -37,7 +37,12 @@ import AppDialog from '@/components-v2/shared/AppDialog.vue'
* without inspecting internal Vue internals. * without inspecting internal Vue internals.
*/ */
const DialogStub = defineComponent({ const DialogStub = defineComponent({
name: 'Dialog', // Not `name: 'Dialog'` — <dialog> is a native HTML element and
// vue/no-reserved-component-names (error) forbids it. VTU matches this
// stub via the `stubs: { Dialog: DialogStub }` key (AppDialog's import
// name) and `findComponent(DialogStub)` by reference, NOT this `name`,
// so renaming it here is behaviour-neutral.
name: 'DialogStub',
props: { props: {
visible: { type: Boolean, default: false }, visible: { type: Boolean, default: false },
modal: { type: Boolean, default: false }, modal: { type: Boolean, default: false },