bert.hausmans/crewli
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

fix(theme): remove webfontloader Public Sans path (AD-2.5-T1 completion)

Browse Source 
P2 reverted CSS font-family to Inter but missed the JS font-loading
path: src/plugins/webfontloader.ts loaded Public Sans from Google
Fonts via WebFont.load(). The wf-publicsans-n4-active class on <html>
(found during P5 manual smoke) proved Public Sans was still loaded at
runtime, plus an external Google Fonts CDN request — both contrary to
AD-2.5-T1 (local @fontsource/inter, no CDN).

Audit context: the plugin was auto-registered via the Vuexy
registerPlugins() glob (src/@core/utils/plugins.ts walks
plugins/*.{ts,js}). No explicit import / call site to delete — file
removal is enough. The plugin only ever loaded Public Sans (no other
families), so full deletion is correct.

Changes:
- Removed src/plugins/webfontloader.ts (auto-registration falls away
  with the file itself; no manual unregister needed).
- Removed webfontloader (1.6.28) + @types/webfontloader (1.6.38) from
  package.json / pnpm-lock.yaml.
- Strengthened tests/unit/styles/typography.spec.ts with a new
  describe block that scans every src/plugins/*.ts for: any
  webfontloader reference, any WebFont.load call, any "Public Sans"
  spelling, any fonts.googleapis.com URL. Plus a regression-lock
  spec asserting webfontloader.ts itself stays deleted.

Suite delta: 552 → 554 (+2 new JS-path specs). vue-tsc clean.
Scoped ESLint clean (0 errors).

Manual smoke pending (Bert): hard-reload /v2/dashboard, confirm
- wf-publicsans-* and wf-active classes are gone from <html>
- computed font-family on body text starts with "Inter"
- Network tab has no fonts.googleapis.com request

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This commit is contained in:
bert.hausmans
2026-05-20 22:25:28 +02:00
parent 30be9aa331
commit 641ca5131d
4 changed files with 40 additions and 38 deletions
Download Patch File Download Diff File Expand all files Collapse all files

41
apps/app/tests/unit/styles/typography.spec.ts
View File

@@ -16,7 +16,7 @@
* If either file is moved, update the path constants below.
*/
import { readFileSync } from 'node:fs'
import { existsSync, readFileSync, readdirSync } from 'node:fs'
import { resolve } from 'node:path'
import { describe, expect, it } from 'vitest'
@@ -30,9 +30,24 @@ const VUEXY_VARIABLES_PATH = resolve(
'../../../src/@core/scss/template/libs/vuetify/_variables.scss',
)
const PLUGINS_DIR = resolve(__dirname, '../../../src/plugins')
const tailwindCss = readFileSync(TAILWIND_CSS_PATH, 'utf-8')
const vuexyVariables = readFileSync(VUEXY_VARIABLES_PATH, 'utf-8')
/**
* All TypeScript plugin files under `apps/app/src/plugins/`, flat-only (the
* `registerPlugins` glob also picks up `plugins/*\/index.ts`, but those
* sub-plugins are folder-namespaced and unlikely to load fonts — flat
* coverage matches where webfontloader.ts lived and where any future
* font-loading regression would most likely surface).
*/
const pluginFiles: Array<{ path: string; content: string }> = existsSync(PLUGINS_DIR)
? readdirSync(PLUGINS_DIR)
.filter(f => f.endsWith('.ts'))
.map(f => ({ path: f, content: readFileSync(resolve(PLUGINS_DIR, f), 'utf-8') }))
: []
/**
* Pulls every `font-family: …;` or `--<name>font<name>: …;` declaration
* from a CSS source. Skips `var(...)` indirections — those are pointers
@@ -91,3 +106,27 @@ describe('Typography regression lock (AD-2.5-T1)', () => {
expect(vuexyVariables).not.toMatch(/public-sans/i)
})
})
/**
* AD-2.5-T1 completion (P2-followup): the JS font-loading path.
*
* P2 inspected CSS only and missed `src/plugins/webfontloader.ts`, which
* loaded Public Sans from the Google Fonts CDN via WebFont.load(). This
* block locks the JS path so the same drift cannot recur: no plugin may
* load fonts via webfontloader, the Google Fonts CDN, or reference
* Public Sans by any spelling.
*/
describe('Typography regression lock — JS font-loading path (AD-2.5-T1 completion)', () => {
it('no plugin loads fonts via webfontloader / Google Fonts CDN / Public Sans', () => {
for (const { path, content } of pluginFiles) {
expect(content, `${path} references webfontloader`).not.toMatch(/webfontloader/i)
expect(content, `${path} calls WebFont.load`).not.toMatch(/WebFont\.load/)
expect(content, `${path} references Public Sans`).not.toMatch(/Public.?Sans/i)
expect(content, `${path} references fonts.googleapis.com`).not.toMatch(/fonts\.googleapis\.com/)
}
})
it('webfontloader.ts plugin no longer exists', () => {
expect(existsSync(resolve(PLUGINS_DIR, 'webfontloader.ts'))).toBe(false)
})
})