bert.hausmans/crewli
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

fix(theme): remove webfontloader Public Sans path (AD-2.5-T1 completion)

Browse Source 
P2 reverted CSS font-family to Inter but missed the JS font-loading
path: src/plugins/webfontloader.ts loaded Public Sans from Google
Fonts via WebFont.load(). The wf-publicsans-n4-active class on <html>
(found during P5 manual smoke) proved Public Sans was still loaded at
runtime, plus an external Google Fonts CDN request — both contrary to
AD-2.5-T1 (local @fontsource/inter, no CDN).

Audit context: the plugin was auto-registered via the Vuexy
registerPlugins() glob (src/@core/utils/plugins.ts walks
plugins/*.{ts,js}). No explicit import / call site to delete — file
removal is enough. The plugin only ever loaded Public Sans (no other
families), so full deletion is correct.

Changes:
- Removed src/plugins/webfontloader.ts (auto-registration falls away
  with the file itself; no manual unregister needed).
- Removed webfontloader (1.6.28) + @types/webfontloader (1.6.38) from
  package.json / pnpm-lock.yaml.
- Strengthened tests/unit/styles/typography.spec.ts with a new
  describe block that scans every src/plugins/*.ts for: any
  webfontloader reference, any WebFont.load call, any "Public Sans"
  spelling, any fonts.googleapis.com URL. Plus a regression-lock
  spec asserting webfontloader.ts itself stays deleted.

Suite delta: 552 → 554 (+2 new JS-path specs). vue-tsc clean.
Scoped ESLint clean (0 errors).

Manual smoke pending (Bert): hard-reload /v2/dashboard, confirm
- wf-publicsans-* and wf-active classes are gone from <html>
- computed font-family on body text starts with "Inter"
- Network tab has no fonts.googleapis.com request

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This commit is contained in:
bert.hausmans
2026-05-20 22:25:28 +02:00
parent 30be9aa331
commit 641ca5131d
4 changed files with 40 additions and 38 deletions
Download Patch File Download Diff File Expand all files Collapse all files

19
apps/app/src/plugins/webfontloader.ts
View File

@@ -1,19 +0,0 @@
/**
* plugins/webfontloader.js
*
* webfontloader documentation: https://github.com/typekit/webfontloader
*/
export async function loadFonts() {
const webFontLoader = await import(/* webpackChunkName: "webfontloader" */'webfontloader')
webFontLoader.load({
google: {
families: ['Public+Sans:ital,wght@0,300;0,400;0,500;0,600;0,700;1,300;1,400;1,500;1,600;1,700&display=swap'],
},
})
}
export default function () {
loadFonts()
}