security: round 3 — token security (crypto random, hashed storage, portal middleware)
Token generation: - Replace Str::ulid() with bin2hex(random_bytes(32)) for 256-bit entropy - Store SHA-256 hash in database, never plaintext tokens - Hash input before lookup on all token endpoints Invitation tokens: - InvitationService: generate crypto random, store hash, pass plain token transiently for email URL via UserInvitation::$plainToken - InvitationController show/accept: hash input before DB lookup - AcceptInvitationRequest: hash token before invitation lookup - Migration: widen user_invitations.token and artists.portal_token from char(26) to char(64) for SHA-256 hex digests Portal token auth: - PortalTokenController: remove Schema::hasTable() runtime checks, hash token before lookup, return shaped response via PortalEventResource instead of raw model data - Create PortalEventResource (name, dates, status only — no internals) - Handle missing production_requests table gracefully via try/catch Portal token middleware: - Implement full token validation: extract from Bearer header or ?token= query param, hash, look up in artists/production_requests, verify event exists and is not draft/closed, set portal context on request - Return generic 401 on any failure (no information leakage) Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This commit is contained in:
@@ -11,7 +11,6 @@ use App\Models\UserInvitation;
|
||||
use Illuminate\Support\Facades\Mail;
|
||||
use Illuminate\Support\Str;
|
||||
use Illuminate\Validation\ValidationException;
|
||||
use Spatie\Activitylog\Facades\LogActivity;
|
||||
|
||||
final class InvitationService
|
||||
{
|
||||
@@ -37,15 +36,20 @@ final class InvitationService
|
||||
]);
|
||||
}
|
||||
|
||||
$plainToken = bin2hex(random_bytes(32));
|
||||
|
||||
$invitation = new UserInvitation(['email' => $email]);
|
||||
$invitation->invited_by_user_id = $invitedBy->id;
|
||||
$invitation->organisation_id = $org->id;
|
||||
$invitation->role = $role;
|
||||
$invitation->token = strtolower((string) Str::ulid());
|
||||
$invitation->token = hash('sha256', $plainToken);
|
||||
$invitation->status = 'pending';
|
||||
$invitation->expires_at = now()->addDays(7);
|
||||
$invitation->save();
|
||||
|
||||
// Set transient plain token for use in the email URL
|
||||
$invitation->plainToken = $plainToken;
|
||||
|
||||
Mail::to($email)->queue(new InvitationMail($invitation));
|
||||
|
||||
activity('invitation')
|
||||
|
||||
Reference in New Issue
Block a user