security: migrate auth tokens to httpOnly cookies (hybrid bearer token approach)
Backend: - CookieBearerToken middleware reads httpOnly cookie and injects Authorization header before Sanctum validates (prepended to API middleware group) - SetAuthCookie trait provides cookie creation/expiry helpers with per-app cookie names (crewli_admin_token, crewli_app_token, crewli_portal_token) - LoginController sets token via Set-Cookie, removes it from JSON body - LogoutController expires the auth cookie on logout - AuthRefreshController (POST /auth/refresh) rotates tokens with new cookie - InvitationController accept also sets token via cookie, not JSON body - All cookies: httpOnly, SameSite=Strict, Secure (in production) Frontend (all three SPAs): - Removed all localStorage token storage (apps/app, apps/portal) - Removed all JS-readable cookie token storage (apps/admin) - Removed Authorization: Bearer header interceptors from axios - Auth stores now rely on GET /auth/me to validate httpOnly cookie - Admin app: new Pinia auth store replaces useCookie-based auth pattern - withCredentials: true ensures browser sends cookies automatically Fixes security findings A13-1 (localStorage tokens) and A13-2 (admin cookie flags). Tokens are now invisible to JavaScript. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This commit is contained in:
@@ -159,7 +159,9 @@ class InvitationTest extends TestCase
|
||||
]);
|
||||
|
||||
$response->assertOk();
|
||||
$response->assertJsonStructure(['data' => ['user' => ['id', 'first_name', 'last_name', 'full_name', 'email'], 'token']]);
|
||||
$response->assertJsonStructure(['data' => ['user' => ['id', 'first_name', 'last_name', 'full_name', 'email']]]);
|
||||
// Token must NOT be in response body (set via httpOnly cookie)
|
||||
$this->assertArrayNotHasKey('token', $response->json('data'));
|
||||
|
||||
$this->assertDatabaseHas('users', ['email' => 'newuser@test.nl']);
|
||||
$this->assertDatabaseHas('organisation_user', [
|
||||
@@ -187,7 +189,9 @@ class InvitationTest extends TestCase
|
||||
$response = $this->postJson("/api/v1/invitations/{$invitation->plainToken}/accept");
|
||||
|
||||
$response->assertOk();
|
||||
$response->assertJsonStructure(['data' => ['user', 'token']]);
|
||||
$response->assertJsonStructure(['data' => ['user']]);
|
||||
// Token must NOT be in response body (set via httpOnly cookie)
|
||||
$this->assertArrayNotHasKey('token', $response->json('data'));
|
||||
|
||||
$this->assertDatabaseHas('organisation_user', [
|
||||
'user_id' => $existingUser->id,
|
||||
|
||||
Reference in New Issue
Block a user