docs(plan-2.5): closure — RFC supersession, BACKLOG landing, applyDomAttributes dedupe
Plan 2.5 final phase (P8). Closes the PrimeVue shell-migration workstream. - RFC-WS-PRIMEVUE-PLAN-2-5: added Supersessions section recording the governing-RFC divergences (§4 dark mode `<body>`→`<html>` per AD-2.5-D1; §7.4 workspace sub option A reversed to placeholder after visual review). Added closure summary (phases, ADs, brand-square recipe, suite delta, lessons). Status → COMPLETE. - BACKLOG: landed 8 items surfaced during Plan 2.5 (MOBILE-SHELL-PARITY, WORKSPACE-DROPDOWN-SUB-CONTENT, DENSITY-AWARE-SPACING, TOPBAR-H-VAR- DECLARE, CSP-FONT-SRC-LOCKDOWN, AUTO-IMPORTS-V2-SCAN, PNPM-RESOLUTIONS- ROOT, SHELLUI-STALE-DATA-THEME-CLEANUP). Marked GRADIENT-BRAND- ALIGNMENT as resolved. - useShellUiStore.toggleDensity: removed redundant applyDomAttributes() call (the AppShellV2 watch already covers density changes). Moved the DOM-write assertion to AppShellV2 watcher-coverage specs. Plan 2.5 status: COMPLETE. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This commit is contained in:
@@ -2,7 +2,7 @@
|
||||
|
||||
| Field | Value |
|
||||
| ------------------------ | ------------------------------------------------------------------------------------------------------------------------------ |
|
||||
| **Status** | Draft — awaiting approval |
|
||||
| **Status** | ✅ Complete (2026-06-03) |
|
||||
| **Date** | 2026-05-19 |
|
||||
| **Author** | Bert + Claude Chat |
|
||||
| **Predecessors** | Plan 2 (`1429abf4` on `main`), Plan 3 (range `537ec098..637d77b3`, suite 564, 4 DEFERRED-HITL baselines) |
|
||||
@@ -26,6 +26,28 @@ Closure of Plan 2.5 unblocks Plan 3 parity-batch baseline capture and establishe
|
||||
|
||||
---
|
||||
|
||||
## Supersessions vs the governing RFC (RFC-WS-GUI-REDESIGN-CREWLI-STARTER)
|
||||
|
||||
During implementation, two decisions diverged from the governing RFC. Both are deliberate and documented here:
|
||||
|
||||
### §4 — Dark mode selector
|
||||
|
||||
- Governing RFC specified: `.dark` class on `<body>`.
|
||||
- Plan 2.5 implemented (AD-2.5-D1, P3 commit `d0dd45c0`): `.dark` on `<html>`.
|
||||
- Rationale: PrimeVue's `darkModeSelector` and Tailwind v4's `@custom-variant dark (&:where(.dark, .dark *))` both target the document root by convention; placing the class on `<html>` aligns the entire dark-mode stack (PrimeVue + Tailwind + Crewli utilities) and avoids the cascading mismatch where AppTopbar reacted but downstream surfaces did not.
|
||||
- Regression lock: `useShellUiStore.applyDomAttributes()` writes the class to `document.documentElement`.
|
||||
|
||||
### §7.4 — Workspace switcher sub line
|
||||
|
||||
- Governing RFC specified option A: no sub line under the workspace name.
|
||||
- Plan 2.5 initially implemented option A (P4–P5).
|
||||
- After visual review against the crewli-starter SoT, **reversed**: a light-grey placeholder sub line is now rendered in the expanded trigger and dropdown rows; collapsed remains bare. The placeholder is a neutral string ('Organisatie'); real type + metrics data is deferred under backlog `WORKSPACE-DROPDOWN-SUB-CONTENT` (future backend work).
|
||||
- Rationale: the two-line layout reads materially better; the placeholder honors the no-backend constraint without sacrificing the visual.
|
||||
|
||||
> **Cross-doc note.** Appendix A of this RFC asks for per-section supersession notes in `RFC-WS-GUI-REDESIGN-CREWLI-STARTER.md` §4 / §7.4. That file does not have discrete dark-mode / workspace-sub sections under those numbers (its §4 is "Out of scope"; there is no §7.4) — the §4 / §7.4 numbering above refers to the design SoT, per §1.2 of this RFC. A single top-level pointer was added to the governing RFC's status block instead; **this Supersessions section is authoritative.**
|
||||
|
||||
---
|
||||
|
||||
## 1. Context
|
||||
|
||||
### 1.1 Where Plan 2 / Plan 3 landed
|
||||
@@ -978,6 +1000,46 @@ Plan 4 designs and implements the **template layer** — `PageTemplate`, `DataTa
|
||||
|
||||
---
|
||||
|
||||
## Plan 2.5 Closure (June 2026)
|
||||
|
||||
### Phases completed
|
||||
|
||||
- **P1** — Navigation registry + breadcrumb refactor
|
||||
- **P2** — Inter typography via @fontsource/inter (+ P2-followup: removed webfontloader Public Sans JS path)
|
||||
- **P3** — Dark mode mechanism (`.dark` on `<html>` + Tailwind v4 `@custom-variant dark`)
|
||||
- **P4** — WorkspaceSwitcher refactor + APP_NAVIGATION as single SoT
|
||||
- **P5** — Shell parity fixes 1–5 (breadcrumb retirement, dropdown panel structure)
|
||||
- **P6** — Shell parity fixes 6–10 (sidebar height, density toggle, divider)
|
||||
- **P6 followups** — brand-square symmetry, logo anchor (no-jump), switcher align/spacing/sub/hover/parity (the inset-shadow unification ended the recurring "not identical" perception)
|
||||
- **P7** — CREWLI-DESIGN-TOKENS.md (Track B foundation doc) + gradient brand-alignment fix (palette diversification + Crewli teal anchor)
|
||||
- **P8** — Closure (this phase): RFC supersession notes, BACKLOG landing, applyDomAttributes dedupe
|
||||
|
||||
### Architectural decisions of record
|
||||
|
||||
- **AD-2.5-T1** — Inter via @fontsource/inter (local, weights 400/500/600/700); Public Sans fully removed from BOTH CSS and JS webfontloader paths. Regression-locked.
|
||||
- **AD-2.5-D1** — `.dark` on `<html>` (supersedes governing RFC §4)
|
||||
- **AD-2.5-W1** — Option A (no sub) initially implemented, then reversed to placeholder sub after visual review (supersedes governing RFC §7.4)
|
||||
- **AD-2.5-B1** — APP_NAVIGATION as single source of truth for sidebar + breadcrumb (eliminates legacy meta-based breadcrumb)
|
||||
|
||||
### Brand square recipe (cemented)
|
||||
|
||||
- 32px (`w-8 h-8`), `rounded-lg`, shared `shadow-[inset_0_-2px_0_#00000014]` utility on BOTH the header logo and the workspace avatar (single source — cannot drift). Offset 16px from the rail edge; collapsed rail width 64px = 32 + 2×16 keeps the square stationary across collapse toggle.
|
||||
|
||||
### Suite delta
|
||||
|
||||
Plan 2.5 added ~50 specs across phases (baseline → P8 final = **574 verified**, 84 files). Notable regression locks: typography (Inter on both CSS and JS paths), gradient palette (brand-teal slot pinned to #0D9394), avatar/logo size + shadow parity. P8 itself: the store's `toggleDensity` DOM-write assertion moved to AppShellV2's watcher-coverage specs (−1 assertion in the store spec, +2 specs in `AppShellV2.spec.ts`).
|
||||
|
||||
### Lessons of record
|
||||
|
||||
- **Audit-first beats pixel-math.** The recurring switcher iterations came from prescribing pixel values without first measuring rendered state. The final parity pass succeeded because it produced a precise side-by-side comparison table BEFORE editing.
|
||||
- **Sub-perceptual divergences need spec locks.** The inset-shadow 8% vs 10% mismatch and the gradient #0D9394 vs #0d9488 mismatch were both invisible to eyeballing; only hex-value specs catch them.
|
||||
- **Shared definitions prevent drift.** The header logo and workspace avatar now reference the same Tailwind utility classes for size/radius/shadow — structurally impossible to diverge.
|
||||
- **One DOM-write authority.** P8 collapsed the density toggle's redundant `applyDomAttributes()` call into AppShellV2's `watch([theme, density])`, so `toggleDensity` and `setTheme` are now both pure state mutations — the watcher is the single root-attribute writer.
|
||||
|
||||
### Status: COMPLETE
|
||||
|
||||
---
|
||||
|
||||
## Appendix A — Cross-doc updates required at closure
|
||||
|
||||
At Plan 2.5 closure, the following dev-docs receive **content updates** (not just SHA bumps in the sync manifest):
|
||||
|
||||
Reference in New Issue
Block a user